[GitHub] [iceberg] jackye1995 commented on a diff in pull request #7444: AWS: Add SQS MetricsReporter

["jackye1995 (via GitHub)" <gi...@apache.org>]

jackye1995 commented on code in PR #7444:
URL: https://github.com/apache/iceberg/pull/7444#discussion_r1178659108


##########
aws/src/main/java/org/apache/iceberg/aws/AwsProperties.java:
##########
@@ -760,6 +763,8 @@ public class AwsProperties implements Serializable {
   private String restSecretAccessKey;
   private String restSessionToken;
 
+  private String sqsQueueUrl;

Review Comment:
   Start from this, let's separate the properties from `AwsProperties` and put it in a different class like `SqsMetricsReporterProperties`. We will gradually also separate other properties to complete the refactoring so that we no longer depend on the client factory for all AWS clients



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org