You are viewing a plain text version of this content. The canonical link for it is here.
Posted to server-dev@james.apache.org by "François-Denis Gonthier (JIRA)" <se...@james.apache.org> on 2010/09/21 20:13:35 UTC
[jira] Created: (IMAP-217) Remove methods findMailboxById and
deleteAll from MailboxMapper
Remove methods findMailboxById and deleteAll from MailboxMapper
----------------------------------------------------------------
Key: IMAP-217
URL: https://issues.apache.org/jira/browse/IMAP-217
Project: JAMES Imap
Issue Type: Bug
Components: Store
Affects Versions: 0.1, 0.2
Reporter: François-Denis Gonthier
findMailboxById and deleteAll are either not really used, or totally unused.
>From Norman:
I just reviewed the code and you are right.. We should remove both
methods form the interface (KISS).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
[jira] Updated: (IMAP-217) Remove methods findMailboxById and
deleteAll from MailboxMapper
Posted by "Norman Maurer (JIRA)" <se...@james.apache.org>.
[ https://issues.apache.org/jira/browse/IMAP-217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Norman Maurer updated IMAP-217:
-------------------------------
Issue Type: Improvement (was: Bug)
> Remove methods findMailboxById and deleteAll from MailboxMapper
> ----------------------------------------------------------------
>
> Key: IMAP-217
> URL: https://issues.apache.org/jira/browse/IMAP-217
> Project: JAMES Imap
> Issue Type: Improvement
> Components: Store
> Affects Versions: 0.1, 0.2
> Reporter: François-Denis Gonthier
> Assignee: Norman Maurer
> Fix For: 0.2
>
>
> findMailboxById and deleteAll are either not really used, or totally unused.
> From Norman:
> I just reviewed the code and you are right.. We should remove both
> methods form the interface (KISS).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
[jira] Commented: (IMAP-217) Remove methods findMailboxById and
deleteAll from MailboxMapper
Posted by "Eric Charles (JIRA)" <se...@james.apache.org>.
[ https://issues.apache.org/jira/browse/IMAP-217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12913464#action_12913464 ]
Eric Charles commented on IMAP-217:
-----------------------------------
InMemoryMailboxSessionMapperFactory uses mapper.deleteAll
mailbox-memory project does not compile on my side.
public void deleteAll() throws MailboxException {
final MailboxMapper<Long> mapper = mailboxMapper;
mapper.execute(new Mapper.VoidTransaction() {
public void runVoid() throws MailboxException {
mapper.deleteAll();
}
});
((InMemoryMessageMapper) messageMapper).deleteAll();
((InMemorySubscriptionMapper) subscriptionMapper).deleteAll();
}
> Remove methods findMailboxById and deleteAll from MailboxMapper
> ----------------------------------------------------------------
>
> Key: IMAP-217
> URL: https://issues.apache.org/jira/browse/IMAP-217
> Project: JAMES Imap
> Issue Type: Improvement
> Components: Store
> Affects Versions: 0.1, 0.2
> Reporter: François-Denis Gonthier
> Assignee: Norman Maurer
> Fix For: 0.2
>
>
> findMailboxById and deleteAll are either not really used, or totally unused.
> From Norman:
> I just reviewed the code and you are right.. We should remove both
> methods form the interface (KISS).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
[jira] Updated: (IMAP-217) Remove methods findMailboxById and
deleteAll from MailboxMapper
Posted by "Norman Maurer (JIRA)" <se...@james.apache.org>.
[ https://issues.apache.org/jira/browse/IMAP-217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Norman Maurer updated IMAP-217:
-------------------------------
Fix Version/s: (was: 0.2)
0.2-M1
> Remove methods findMailboxById and deleteAll from MailboxMapper
> ----------------------------------------------------------------
>
> Key: IMAP-217
> URL: https://issues.apache.org/jira/browse/IMAP-217
> Project: JAMES Imap
> Issue Type: Improvement
> Components: Store
> Affects Versions: 0.1, 0.2
> Reporter: François-Denis Gonthier
> Assignee: Norman Maurer
> Fix For: 0.2-M1
>
>
> findMailboxById and deleteAll are either not really used, or totally unused.
> From Norman:
> I just reviewed the code and you are right.. We should remove both
> methods form the interface (KISS).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
[jira] Resolved: (IMAP-217) Remove methods findMailboxById and
deleteAll from MailboxMapper
Posted by "Norman Maurer (JIRA)" <se...@james.apache.org>.
[ https://issues.apache.org/jira/browse/IMAP-217?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Norman Maurer resolved IMAP-217.
--------------------------------
Assignee: Norman Maurer
Fix Version/s: 0.2
Resolution: Fixed
Removed.. Thx
> Remove methods findMailboxById and deleteAll from MailboxMapper
> ----------------------------------------------------------------
>
> Key: IMAP-217
> URL: https://issues.apache.org/jira/browse/IMAP-217
> Project: JAMES Imap
> Issue Type: Bug
> Components: Store
> Affects Versions: 0.1, 0.2
> Reporter: François-Denis Gonthier
> Assignee: Norman Maurer
> Fix For: 0.2
>
>
> findMailboxById and deleteAll are either not really used, or totally unused.
> From Norman:
> I just reviewed the code and you are right.. We should remove both
> methods form the interface (KISS).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
[jira] Commented: (IMAP-217) Remove methods findMailboxById and
deleteAll from MailboxMapper
Posted by "Eric Charles (JIRA)" <se...@james.apache.org>.
[ https://issues.apache.org/jira/browse/IMAP-217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12913481#action_12913481 ]
Eric Charles commented on IMAP-217:
-----------------------------------
http://svn.apache.org/viewvc?rev=999839&view=rev
+ http://svn.apache.org/viewvc?rev=999850&view=rev
should do the job
please review :)
- eric
> Remove methods findMailboxById and deleteAll from MailboxMapper
> ----------------------------------------------------------------
>
> Key: IMAP-217
> URL: https://issues.apache.org/jira/browse/IMAP-217
> Project: JAMES Imap
> Issue Type: Improvement
> Components: Store
> Affects Versions: 0.1, 0.2
> Reporter: François-Denis Gonthier
> Assignee: Norman Maurer
> Fix For: 0.2
>
>
> findMailboxById and deleteAll are either not really used, or totally unused.
> From Norman:
> I just reviewed the code and you are right.. We should remove both
> methods form the interface (KISS).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
[jira] Commented: (IMAP-217) Remove methods findMailboxById and
deleteAll from MailboxMapper
Posted by "Norman Maurer (JIRA)" <se...@james.apache.org>.
[ https://issues.apache.org/jira/browse/IMAP-217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12913470#action_12913470 ]
Norman Maurer commented on IMAP-217:
------------------------------------
Shit, I missed a cast. I will fix it when I have a chance to do so. If you like and are faster just commit the fix
> Remove methods findMailboxById and deleteAll from MailboxMapper
> ----------------------------------------------------------------
>
> Key: IMAP-217
> URL: https://issues.apache.org/jira/browse/IMAP-217
> Project: JAMES Imap
> Issue Type: Improvement
> Components: Store
> Affects Versions: 0.1, 0.2
> Reporter: François-Denis Gonthier
> Assignee: Norman Maurer
> Fix For: 0.2
>
>
> findMailboxById and deleteAll are either not really used, or totally unused.
> From Norman:
> I just reviewed the code and you are right.. We should remove both
> methods form the interface (KISS).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org