You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Niklas Nielsen <ni...@qni.dk> on 2014/05/07 19:59:09 UTC
Review Request 21167: Added user field to CommandInfo.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21167/
-----------------------------------------------------------
Review request for mesos, Adam B, Benjamin Hindman, and Vinod Kone.
Bugs: MESOS-1141
https://issues.apache.org/jira/browse/MESOS-1141
Repository: mesos-git
Description
-------
Enables individual executors and tasks to run as a specific user. If
the user field is present both in FrameworkInfo and here, the
CommandInfo user value takes precedence.
Diffs
-----
include/mesos/mesos.proto e48e50a
src/slave/slave.hpp ed20dca
src/slave/slave.cpp 2a48266
src/tests/slave_tests.cpp 0982455
Diff: https://reviews.apache.org/r/21167/diff/
Testing
-------
make check as root on Linux. Tests are guarded/only run when running
as root as the containerizer needs to execute chown. Running tests as
root on Mac OS X is currently broken.
Thanks,
Niklas Nielsen
Re: Review Request 21167: Added user field to CommandInfo.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21167/#review42428
-----------------------------------------------------------
Patch looks great!
Reviews applied: [21167]
All tests passed.
- Mesos ReviewBot
On May 7, 2014, 5:59 p.m., Niklas Nielsen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21167/
> -----------------------------------------------------------
>
> (Updated May 7, 2014, 5:59 p.m.)
>
>
> Review request for mesos, Adam B, Benjamin Hindman, and Vinod Kone.
>
>
> Bugs: MESOS-1141
> https://issues.apache.org/jira/browse/MESOS-1141
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Enables individual executors and tasks to run as a specific user. If
> the user field is present both in FrameworkInfo and here, the
> CommandInfo user value takes precedence.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto e48e50a
> src/slave/slave.hpp ed20dca
> src/slave/slave.cpp 2a48266
> src/tests/slave_tests.cpp 0982455
>
> Diff: https://reviews.apache.org/r/21167/diff/
>
>
> Testing
> -------
>
> make check as root on Linux. Tests are guarded/only run when running
> as root as the containerizer needs to execute chown. Running tests as
> root on Mac OS X is currently broken.
>
>
> Thanks,
>
> Niklas Nielsen
>
>
Re: Review Request 21167: Added user field to CommandInfo.
Posted by Niklas Nielsen <ni...@qni.dk>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21167/
-----------------------------------------------------------
(Updated May 8, 2014, 12:04 p.m.)
Review request for mesos, Adam B, Benjamin Hindman, and Vinod Kone.
Changes
-------
Addressed BenH's comments.
Bugs: MESOS-1141
https://issues.apache.org/jira/browse/MESOS-1141
Repository: mesos-git
Description
-------
Enables individual executors and tasks to run as a specific user. If
the user field is present both in FrameworkInfo and here, the
CommandInfo user value takes precedence.
Diffs (updated)
-----
include/mesos/mesos.proto e48e50a
src/slave/slave.cpp a7c0e4d
src/tests/slave_tests.cpp 0982455
Diff: https://reviews.apache.org/r/21167/diff/
Testing
-------
make check as root on Linux. Tests are guarded/only run when running
as root as the containerizer needs to execute chown. Running tests as
root on Mac OS X is currently broken.
Thanks,
Niklas Nielsen