[jira] [Commented] (METRON-1129) Management UI - Package Node Dependencies in RPM

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/METRON-1129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16138590#comment-16138590 ] 

ASF GitHub Bot commented on METRON-1129:
----------------------------------------

Github user ottobackwards commented on a diff in the pull request:

    https://github.com/apache/metron/pull/712#discussion_r134802794
  
    --- Diff: metron-deployment/packaging/docker/rpm-docker/Dockerfile ---
    @@ -27,3 +27,7 @@ RUN mv apache-maven-3.2.5 /opt/maven
     RUN ln -s /opt/maven/bin/mvn /usr/bin/mvn
     RUN yum -y install asciidoc rpm-build rpm2cpio tar unzip xmlto zip rpmlint && yum clean all
     WORKDIR /root
    +
    +# install node so that the node dependencies can be packaged into the RPMs
    +RUN curl --silent --location https://rpm.nodesource.com/setup_6.x | bash -
    +RUN yum -y install gcc-c++ make nodejs
    --- End diff --
    
    Right now, we copy everything we need into the docker rpm environment using assembly and resource copy.  Since we have *just* built the node stuff in the build phase, is there a way we can assemble and resource copy the node dependencies in?  or does this have to be done on the spot regardless.


> Management UI - Package Node Dependencies in RPM
> ------------------------------------------------
>
>                 Key: METRON-1129
>                 URL: https://issues.apache.org/jira/browse/METRON-1129
>             Project: Metron
>          Issue Type: Improvement
>    Affects Versions: 0.4.0
>            Reporter: Nick Allen
>            Assignee: Nick Allen
>             Fix For: Next + 1
>
>
> If you install the Management UI using the RPM, it will not install all of the required Node dependencies.  You have to manually run `npm install ...` to get those dependencies installed.  
> This works just fine in an environment that can access the interwebs.  This does not work so well when installing in an offline environment with no interweb access.  If we package all Node dependencies in the RPM itself, this makes it much simpler to install in an offline environment.  And this, of course, will also work in an online environment and removes a manual steps.  So win, win.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)