[GitHub] [hudi] vinothchandar commented on a change in pull request #2496: [HUDI-1554] Introduced buffering for streams in HUDI.

[GitBox <gi...@apache.org>]

vinothchandar commented on a change in pull request #2496:
URL: https://github.com/apache/hudi/pull/2496#discussion_r565725066



##########
File path: hudi-common/src/main/java/org/apache/hudi/common/fs/FSUtils.java
##########
@@ -79,6 +79,11 @@
 
   private static final PathFilter ALLOW_ALL_FILTER = file -> true;
 
+  private static final Set<String> DATA_FILE_EXTENSIONS = Arrays.stream(HoodieFileFormat.values())

Review comment:
       For naming we stick to `base file` over data file. the last of the data file references have a PR open to remove. So kindly rename to `BASE_FILE_EXTENSIONS` and can this be in `HoodieFileFormat` itself ? 

##########
File path: hudi-common/src/main/java/org/apache/hudi/common/fs/FSUtils.java
##########
@@ -415,17 +420,18 @@ public static boolean isLogFile(Path logPath) {
     return matcher.find() && logPath.getName().contains(".log");
   }
 
+  public static boolean isDataFile(Path path) {

Review comment:
       this can be ba method of `HoodieFileFormat`, rather than a util method here.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org