[GitHub] [arrow] kou commented on a diff in pull request #36016: GH-36013: [C++] Disabling bundled OpenTelemetry

["kou (via GitHub)" <gi...@apache.org>]

kou commented on code in PR #36016:
URL: https://github.com/apache/arrow/pull/36016#discussion_r1224998638


##########
cpp/cmake_modules/ThirdpartyToolchain.cmake:
##########
@@ -4511,6 +4511,7 @@ endif()
 
 macro(build_opentelemetry)
   message(STATUS "Building OpenTelemetry from source")
+  message(WARNING "This can lead to build errors due to conflicting abseil (GH-36013).")

Review Comment:
   How about reporting an error if Protobuf is 3.22 or later?
   
   ```suggestion
     if(Protobuf_VERSION VERSION_GREATER_EQUAL 3.22)
       message(FATAL_ERROR "GH-36013: Can't use bundled OpenTelemetry with Protobuf 3.22 or later: ${Protobuf_VERSION}")
     endif()
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org