You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by abdelhakim deneche <ad...@gmail.com> on 2015/03/20 19:43:42 UTC

Review Request 32322: DRILL-2507: most TestParquetWriter tests aren't actually launching the test queries

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32322/
-----------------------------------------------------------

Review request for drill and Jason Altekruse.


Bugs: DRILL-2507
    https://issues.apache.org/jira/browse/DRILL-2507


Repository: drill-git


Description
-------

Fixed TestParquetWriter.runTestAndValidate() to launch the test built. Had to make changes to 2 unit tests that were failing once the test was built


Diffs
-----

  exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/writer/TestParquetWriter.java 76328c6 

Diff: https://reviews.apache.org/r/32322/diff/


Testing
-------

unit tests, functional/customer and tpch100


Thanks,

abdelhakim deneche


Re: Review Request 32322: DRILL-2507: most TestParquetWriter tests aren't actually launching the test queries

Posted by Jason Altekruse <al...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32322/#review77590
-----------------------------------------------------------

Ship it!


Ship It!

- Jason Altekruse


On March 20, 2015, 6:43 p.m., abdelhakim deneche wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32322/
> -----------------------------------------------------------
> 
> (Updated March 20, 2015, 6:43 p.m.)
> 
> 
> Review request for drill and Jason Altekruse.
> 
> 
> Bugs: DRILL-2507
>     https://issues.apache.org/jira/browse/DRILL-2507
> 
> 
> Repository: drill-git
> 
> 
> Description
> -------
> 
> Fixed TestParquetWriter.runTestAndValidate() to launch the test built. Had to make changes to 2 unit tests that were failing once the test was built
> 
> 
> Diffs
> -----
> 
>   exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/writer/TestParquetWriter.java 76328c6 
> 
> Diff: https://reviews.apache.org/r/32322/diff/
> 
> 
> Testing
> -------
> 
> unit tests, functional/customer and tpch100
> 
> 
> Thanks,
> 
> abdelhakim deneche
> 
>