[log4j2] Flume appender compiler warnings

[Gary Gregory <ga...@gmail.com>]

What should we do here:

[INFO] --- maven-compiler-plugin:3.7.0:compile (default-compile) @
log4j-flume-ng ---
[INFO] Changes detected - recompiling the module!
[INFO] Compiling 11 source files to
C:\vcs\git\apache\logging\logging-log4j2\log4j-flume-ng\target\classes
Processing annotations
Annotations processed
Processing annotations
No elements to process
[WARNING]
C:\vcs\git\apache\logging\logging-log4j2\log4j-flume-ng\src\main\java\org\apache\logging\log4j\flume\appender\FlumeEvent.java:[339,32]
getContextMap() in org.apache.logging.log4j.core.LogEvent has been
deprecated
[WARNING]
C:\vcs\git\apache\logging\logging-log4j2\log4j-flume-ng\src\main\java\org\apache\logging\log4j\flume\appender\FlumeEvent.java:[96,50]
[StringSplitter] String.split(String) has surprising behavior
    (see http://errorprone.info/bugpattern/StringSplitter)
  Did you mean 'final List<String> array =
Splitter.on(Patterns.COMMA_SEPARATOR).splitToList(includes);'?
[WARNING]
C:\vcs\git\apache\logging\logging-log4j2\log4j-flume-ng\src\main\java\org\apache\logging\log4j\flume\appender\FlumeEvent.java:[106,50]
[StringSplitter] String.split(String) has surprising behavior
    (see http://errorprone.info/bugpattern/StringSplitter)
  Did you mean 'final List<String> array =
Splitter.on(Patterns.COMMA_SEPARATOR).splitToList(excludes);'?
[WARNING]
C:\vcs\git\apache\logging\logging-log4j2\log4j-flume-ng\src\main\java\org\apache\logging\log4j\flume\appender\FlumeEvent.java:[123,50]
[StringSplitter] String.split(String) has surprising behavior
    (see http://errorprone.info/bugpattern/StringSplitter)
  Did you mean 'final List<String> array =
Splitter.on(Patterns.COMMA_SEPARATOR).splitToList(required);'?
[WARNING]
C:\vcs\git\apache\logging\logging-log4j2\log4j-flume-ng\src\main\java\org\apache\logging\log4j\flume\appender\FlumePersistentManager.java:[174,17]
[UnsynchronizedOverridesSynchronized] Unsynchronized method send overrides
synchronized method in FlumeAvroManager
    (see
http://errorprone.info/bugpattern/UnsynchronizedOverridesSynchronized)
  Did you mean 'public synchronized void send(final Event event)  {'?
[WARNING]
C:\vcs\git\apache\logging\logging-log4j2\log4j-flume-ng\src\main\java\org\apache\logging\log4j\flume\appender\FlumePersistentManager.java:[447,106]
[ClassNewInstance] Class.newInstance() bypasses exception checking; prefer
getDeclaredConstructor().newInstance()
    (see http://errorprone.info/bugpattern/ClassNewInstance)
  Did you mean 'final SecretKeyProvider provider = (SecretKeyProvider)
cl.getDeclaredConstructor().newInstance();'?
[WARNING]
C:\vcs\git\apache\logging\logging-log4j2\log4j-flume-ng\src\main\java\org\apache\logging\log4j\flume\appender\FlumePersistentManager.java:[488,94]
[InconsistentCapitalization] Found the field 'batchSize' with the same name
as the parameter 'batchsize' but with different capitalization.
    (see http://errorprone.info/bugpattern/InconsistentCapitalization)
  Did you mean 'final FlumePersistentManager manager, final Gate gate,
final int batchSize,'?
[WARNING]
C:\vcs\git\apache\logging\logging-log4j2\log4j-flume-ng\src\main\java\org\apache\logging\log4j\flume\appender\FlumePersistentManager.java:[520,57]
[OperatorPrecedence] Use grouping parenthesis to make the operator
precedence explicit
    (see http://errorprone.info/bugpattern/OperatorPrecedence)
  Did you mean 'if (dbCount >= batchSize || (dbCount > 0 && nextBatchMillis
<= nowMillis)) {'?
[WARNING]
C:\vcs\git\apache\logging\logging-log4j2\log4j-flume-ng\src\main\java\org\apache\logging\log4j\flume\appender\FlumePersistentManager.java:[846,17]
[WaitNotInLoop] Because of spurious wakeups, wait(long) must always be
called in a loop
    (see http://errorprone.info/bugpattern/WaitNotInLoop)
[WARNING]
C:\vcs\git\apache\logging\logging-log4j2\log4j-flume-ng\src\main\java\org\apache\logging\log4j\flume\appender\FlumeAppender.java:[286,41]
non-varargs call of varargs method with inexact argument type for last
parameter;
  cast to java.lang.Object for a varargs call
  cast to java.lang.Object[] for a non-varargs call and to suppress this
warning
[WARNING]
C:\vcs\git\apache\logging\logging-log4j2\log4j-flume-ng\src\main\java\org\apache\logging\log4j\flume\appender\FlumeAppender.java:[274,55]
[StringSplitter] String.split(String) has surprising behavior
    (see http://errorprone.info/bugpattern/StringSplitter)
  Did you mean 'final List<String> hostports =
Splitter.on(',').splitToList(hosts);'?
[WARNING]
C:\vcs\git\apache\logging\logging-log4j2\log4j-flume-ng\src\main\java\org\apache\logging\log4j\flume\appender\FlumeAppender.java:[277,58]
[StringSplitter] String.split(String) has surprising behavior
    (see http://errorprone.info/bugpattern/StringSplitter)
  Did you mean 'final List<String> h =
Splitter.on(':').splitToList(hostports[i]);'?

?

Gary