You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@rya.apache.org by jacstrong <gi...@git.apache.org> on 2018/01/29 17:31:45 UTC
[GitHub] incubator-rya pull request #270: Update readme.md
GitHub user jacstrong opened a pull request:
https://github.com/apache/incubator-rya/pull/270
Update readme.md
Added missing spaces to headers in the "Other useful commands" section. Before appeared as #####section now appears as <h5>section</h5> (markdown equivalent)
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
## Description
>What Changed?
readme.md was edited. There were missing spaces between the "#"s and the section title. The spaces were added.
### Tests
>Coverage?
[Description of what tests were written]
### Links
[Jira](https://issues.apache.org/jira/browse/RYA-NUMBER)
### Checklist
- [ ] Code Review
- [ ] Squash Commits
#### People To Reivew
[Add those who should review this]
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jacstrong/incubator-rya master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-rya/pull/270.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #270
----
commit 2244b03465b06957419d5e1d383809c127c11f04
Author: Jacob Strong <ja...@...>
Date: 2018-01-29T17:27:33Z
Update readme.md
Added missing spaces to headers in the "Other useful commands" section. Before appeared as #####section now appears as <h5>section</h5>
----
---
[GitHub] incubator-rya issue #270: Update readme.md
Posted by jdasch <gi...@git.apache.org>.
Github user jdasch commented on the issue:
https://github.com/apache/incubator-rya/pull/270
asfbot build
---
[GitHub] incubator-rya issue #270: Update readme.md
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit commented on the issue:
https://github.com/apache/incubator-rya/pull/270
Can one of the admins verify this patch?
---
[GitHub] incubator-rya issue #270: Update readme.md
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit commented on the issue:
https://github.com/apache/incubator-rya/pull/270
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-rya-master-with-optionals-pull-requests/684/
---
[GitHub] incubator-rya issue #270: Update readme.md
Posted by pujav65 <gi...@git.apache.org>.
Github user pujav65 commented on the issue:
https://github.com/apache/incubator-rya/pull/270
hey @jacstrong I was going to pull this in, but I can't find a branch to pull it in off of. What am I missing here? I can find change on your master branch, but there is a check in after that that I cannot/do not want to pull in (the "this is stupid" one. Can you update the pull request to point to an existing branch on your repo?
---