You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Andriy Babiichuk <ab...@hortonworks.com> on 2017/03/03 18:07:12 UTC
Review Request 57296: Full-height modals overflow viewport vertically
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57296/
-----------------------------------------------------------
Review request for Ambari and Aleksandr Kovalenko.
Bugs: AMBARI-20311
https://issues.apache.org/jira/browse/AMBARI-20311
Repository: ambari
Description
-------
Modal popups that occupy all available height (i.e., containing background operations logs) overflow viewport vertically.
Diffs
-----
ambari-web/app/styles/common.less ad1da66
ambari-web/app/styles/log_file_search.less cf5ef29
ambari-web/app/templates/common/host_progress_popup.hbs ae411b1
ambari-web/app/views/common/host_progress_popup_body_view.js f119c3b
ambari-web/app/views/common/modal_popup.js f09ae62
Diff: https://reviews.apache.org/r/57296/diff/1/
Testing
-------
20575 passing (18s)
153 pending
Thanks,
Andriy Babiichuk
Re: Review Request 57296: Full-height modals overflow viewport
vertically
Posted by Aleksandr Kovalenko <ak...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57296/#review167852
-----------------------------------------------------------
Ship it!
Ship It!
- Aleksandr Kovalenko
On \u041c\u0430\u0440\u0442 3, 2017, 6:07 \u043f.\u043f., Andriy Babiichuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57296/
> -----------------------------------------------------------
>
> (Updated \u041c\u0430\u0440\u0442 3, 2017, 6:07 \u043f.\u043f.)
>
>
> Review request for Ambari and Aleksandr Kovalenko.
>
>
> Bugs: AMBARI-20311
> https://issues.apache.org/jira/browse/AMBARI-20311
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Modal popups that occupy all available height (i.e., containing background operations logs) overflow viewport vertically.
>
>
> Diffs
> -----
>
> ambari-web/app/styles/common.less ad1da66
> ambari-web/app/styles/log_file_search.less cf5ef29
> ambari-web/app/templates/common/host_progress_popup.hbs ae411b1
> ambari-web/app/views/common/host_progress_popup_body_view.js f119c3b
> ambari-web/app/views/common/modal_popup.js f09ae62
>
>
> Diff: https://reviews.apache.org/r/57296/diff/1/
>
>
> Testing
> -------
>
> 20575 passing (18s)
> 153 pending
>
>
> Thanks,
>
> Andriy Babiichuk
>
>