[GitHub] [hive] ayushtkn commented on a diff in pull request #3577: HIVE-26519: Iceberg: Add support for CTLT queries.

[GitBox <gi...@apache.org>]

ayushtkn commented on code in PR #3577:
URL: https://github.com/apache/hive/pull/3577#discussion_r965991159


##########
ql/src/java/org/apache/hadoop/hive/ql/parse/StorageFormat.java:
##########
@@ -48,16 +48,30 @@ public class StorageFormat {
   private final Map<String, String> serdeProps;
 
   private enum StorageHandlerTypes {
-    ICEBERG("\'org.apache.iceberg.mr.hive.HiveIcebergStorageHandler\'");
+    ICEBERG("\'org.apache.iceberg.mr.hive.HiveIcebergStorageHandler\'",
+        "org.apache.iceberg.mr.hive.HiveIcebergInputFormat", "org.apache.iceberg.mr.hive.HiveIcebergOutputFormat");
 
     private final String className;
-    StorageHandlerTypes(String className) {
+    private final String inputFormat;
+    private final String outputFormat;
+
+    StorageHandlerTypes(String className, String inputFormat, String outputFormat) {

Review Comment:
   Done



##########
iceberg/iceberg-handler/src/test/java/org/apache/iceberg/mr/hive/TestHiveIcebergStorageHandlerNoScan.java:
##########
@@ -1576,6 +1576,20 @@ public void testAlterTableToIcebergAndMetadataLocation() throws IOException {
         });
   }
 
+  @Test
+  public void testCTLT() {
+    // Create a normal table and add some data
+    shell.executeStatement("CREATE TABLE source(a int)");
+    shell.executeStatement("insert into source values(1)");
+
+    shell.executeStatement(String.format("CREATE TABLE dest LIKE source STORED BY ICEBERG %s ",
+        testTables.locationForCreateTableSQL(TableIdentifier.of("default", "dest"))));
+
+    // Try a select query and check if the table is empty .
+    String result = shell.executeAndStringify("select a from " + TableIdentifier.of("default", "dest").name());

Review Comment:
   Added



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org