You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2020/10/01 03:56:57 UTC
[GitHub] [incubator-pinot] fx19880617 commented on a change in pull request #6087: Fix StarTreeClusterIntegrationTest by not removing the segments
fx19880617 commented on a change in pull request #6087:
URL: https://github.com/apache/incubator-pinot/pull/6087#discussion_r497970028
##########
File path: pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/StarTreeClusterIntegrationTest.java
##########
@@ -135,14 +140,15 @@ public void setUp()
List<File> avroFiles = unpackAvroData(_tempDir);
// Create and upload segments
- ClusterIntegrationTestUtils.buildSegmentsFromAvro(avroFiles, defaultTableConfig, schema, 0, _segmentDir, _tarDir);
- uploadSegments(DEFAULT_TABLE_NAME, _tarDir);
- TestUtils.ensureDirectoriesExistAndEmpty(_segmentDir, _tarDir);
- ClusterIntegrationTestUtils.buildSegmentsFromAvro(avroFiles, starTreeTableConfig, schema, 0, _segmentDir, _tarDir);
- uploadSegments(STAR_TREE_TABLE_NAME, _tarDir);
+ ClusterIntegrationTestUtils
+ .buildSegmentsFromAvro(avroFiles, defaultTableConfig, schema, 0, defaultTableSegmentDir, defaultTableTarDir);
+ uploadSegments(DEFAULT_TABLE_NAME, defaultTableTarDir);
+ ClusterIntegrationTestUtils
+ .buildSegmentsFromAvro(avroFiles, starTreeTableConfig, schema, 0, starTreeTableSegmentDir, starTreeTableTarDir);
+ uploadSegments(STAR_TREE_TABLE_NAME, starTreeTableTarDir);
// Set up the query generators
- SegmentInfoProvider segmentInfoProvider = new SegmentInfoProvider(_tarDir.getPath());
Review comment:
shall this be `starTreeTableTarDir` or it doesn't matter?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org