You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/10/29 18:06:32 UTC
[GitHub] [spark] imback82 commented on a change in pull request #34429: [SPARK-37150][SQL] Migrate DESCRIBE NAMESPACE to use V2 command by default
imback82 commented on a change in pull request #34429:
URL: https://github.com/apache/spark/pull/34429#discussion_r739438963
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/command/DescribeNamespaceSuiteBase.scala
##########
@@ -47,4 +48,21 @@ trait DescribeNamespaceSuiteBase extends QueryTest with DDLCommandTestUtils {
// TODO: Move this to DropNamespaceSuite when the test suite is introduced.
sql(s"DROP NAMESPACE IF EXISTS $catalog.$ns")
}
+
+ test("Keep the legacy output schema") {
Review comment:
This is now run for both v1/v2 catalogs.
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/execution/command/v1/DescribeNamespaceSuite.scala
##########
@@ -43,35 +43,21 @@ trait DescribeNamespaceSuiteBase extends command.DescribeNamespaceSuiteBase {
.where("key not like 'Owner%'") // filter for consistency with in-memory catalog
.collect()
+ val namePrefix = if (conf.useV1Command) "Database" else "Namespace"
Review comment:
This will be the only difference b/w v1 and v2 command.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org