You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2020/11/16 13:13:16 UTC
[GitHub] [geode-native] mkevo opened a new pull request #693: GEODE-8442: Exception in server not identified correctly in client
mkevo opened a new pull request #693:
URL: https://github.com/apache/geode-native/pull/693
HandleReplay is already commented in other functions as replay is unsupported, this change will not translate the real exception to UnknownException.
User will got correct exception and will know how to handle it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode-native] mkevo commented on pull request #693: GEODE-8442: Exception in server not identified correctly in client
Posted by GitBox <gi...@apache.org>.
mkevo commented on pull request #693:
URL: https://github.com/apache/geode-native/pull/693#issuecomment-732005727
Just to add that this reproduction steps can lead to the few exceptions, depends on which state of the transaction it fail(It can be MessageException for CacheTransactionManager::failover or UnknownException for TransactionDataNodeHasDepartedException).
Also the help is needed for writing a test as I need to do containsKeyOnServer and killing server lead in parallel, but don't have an idea how to do this in tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode-native] mkevo commented on pull request #693: GEODE-8442: Exception in server not identified correctly in client
Posted by GitBox <gi...@apache.org>.
mkevo commented on pull request #693:
URL: https://github.com/apache/geode-native/pull/693#issuecomment-743028961
Hi @moleske ,
I tried with rebase, bit the same thing happened.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode-native] mkevo commented on pull request #693: GEODE-8442: Exception in server not identified correctly in client
Posted by GitBox <gi...@apache.org>.
mkevo commented on pull request #693:
URL: https://github.com/apache/geode-native/pull/693#issuecomment-742458577
Hi @echobravopapa,
I wrote a test, but now have a problem with LGTM check. I saw on other PR that this also happened today. Do you maybe know how to fix it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode-native] moleske commented on pull request #693: GEODE-8442: Exception in server not identified correctly in client
Posted by GitBox <gi...@apache.org>.
moleske commented on pull request #693:
URL: https://github.com/apache/geode-native/pull/693#issuecomment-742862808
> I wrote a test, but now have a problem with LGTM check. I saw on other PR that this also happened today. Do you maybe know how to fix it?
Looking a [the output of LGTM](https://lgtm.com/projects/g/apache/geode-native/logs/rev/pr-d830587f41dd9f18339edc0e8866570fd9e44ab6/lang:cpp/stage:Build%20merge_d3f6b1592a01fd440ae19b9cb4772495d3f37649), it seems like it failed to merge with develop. When I've hit this in the past, a rebase usually solves the problem.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode-native] mkevo closed pull request #693: GEODE-8442: Exception in server not identified correctly in client
Posted by GitBox <gi...@apache.org>.
mkevo closed pull request #693:
URL: https://github.com/apache/geode-native/pull/693
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode-native] mkevo commented on pull request #693: GEODE-8442: Exception in server not identified correctly in client
Posted by GitBox <gi...@apache.org>.
mkevo commented on pull request #693:
URL: https://github.com/apache/geode-native/pull/693#issuecomment-728731731
I'm trying to write a test for this, as I reproduce it manually. There are steps to reproduce the issue:
1. Start locator and three servers.
2. Run some puts and then run containsKeyOnServer function with transactions.
3. While containsKeyOnServer is executing kill lead server.
4. You will got UnknownException without this change.
So if you have some idea how to do this containsKeyOnServer and killing server lead in parallel, it will help a lot.
@echobravopapa , yes, I intend this to be a draft.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode-native] mkevo commented on pull request #693: GEODE-8442: Exception in server not identified correctly in client
Posted by GitBox <gi...@apache.org>.
mkevo commented on pull request #693:
URL: https://github.com/apache/geode-native/pull/693#issuecomment-745551558
Hi @moleske, @echobravopapa ,
finally I fix this somehow in a new PR, so I will close this one.
Please take a look on #713
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org