You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2019/01/15 08:15:00 UTC

[jira] [Commented] (AIRFLOW-3524) Enable automated execution of integration tests for GCP operators

    [ https://issues.apache.org/jira/browse/AIRFLOW-3524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16742851#comment-16742851 ] 

ASF GitHub Bot commented on AIRFLOW-3524:
-----------------------------------------

potiuk commented on pull request #4532: [AIRFLOW-3524] Added support for Google Cloud Build
URL: https://github.com/apache/airflow/pull/4532
 
 
   This commit adds support for Automated execution of Unit Tests and
   (what is more important) System Tests using Google Cloud Build.
   
   Its likely that this commit will be merged with some changes providing
   that the supporting docker image that is used for Cloud Build
   comes from an external repository. The ultimate goal is to
   have an image that supports both Travis CI and Google Cloud Build at
   the same time and it should be part of the Airflow repository itself.
   
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [ ] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
     - https://issues.apache.org/jira/browse/AIRFLOW-XXX
     - In case you are fixing a typo in the documentation you can prepend your commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
   
   ### Description
   
   - [ ] Here are some details about my PR, including screenshots of any UI changes:
   
   ### Tests
   
   - [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   
   ### Commits
   
   - [ ] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [ ] In case of new functionality, my PR adds documentation that describes how to use it.
     - When adding new operators/hooks/sensors, the autoclass documentation generation needs to be added.
     - All the public functions and the classes in the PR contain docstrings that explain what it does
   
   ### Code Quality
   
   - [ ] Passes `flake8`
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Enable automated execution of integration tests for GCP operators
> -----------------------------------------------------------------
>
>                 Key: AIRFLOW-3524
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-3524
>             Project: Apache Airflow
>          Issue Type: Improvement
>            Reporter: Jarek Potiuk
>            Priority: Major
>
> In order to enable automated execution of integration tests for GCP operators we need to synchronise naming of the variables and add some setup/teardown codes for some of the operators so that the tests can be run in an automated way.
> This will be quite a refactor across GCP compute, compute_igm, gcf, cloudsql and a little in dataproc, container, s3to gcf. It will be followed by another change that will allow to run it all via Google Cloud Build on a Google infrastructure.
> It's a proof of concept for GCP-enabled implementation of [https://cwiki.apache.org/confluence/display/AIRFLOW/AIP-4+Support+for+Integration+Tests] (which will be changed accordingly to make it GCP-ony support). Google Cloud Build allows for super-easy automation of those tests.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)