You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2020/01/04 10:40:01 UTC
[GitHub] [hbase] pytalkweb opened a new pull request #988: Made DemoClient
python 3.0 compatible ..
pytalkweb opened a new pull request #988: Made DemoClient python 3.0 compatible ..
URL: https://github.com/apache/hbase/pull/988
Issue is the DemoClient.py is not updated for python 3.X. Python 2.X support has ended. Updating this to 3.0. Please see
https://issues.apache.org/jira/browse/HBASE-23644
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] HorizonNet commented on issue #988: Made DemoClient python
3.0 compatible ..
Posted by GitBox <gi...@apache.org>.
HorizonNet commented on issue #988: Made DemoClient python 3.0 compatible ..
URL: https://github.com/apache/hbase/pull/988#issuecomment-578166657
@pytalkweb We're running pylint from the build. Could you please check your changes with pylint?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #988: Made DemoClient
python 3.0 compatible ..
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #988: Made DemoClient python 3.0 compatible ..
URL: https://github.com/apache/hbase/pull/988#issuecomment-570834296
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 34s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| -0 :warning: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 5m 36s | master passed |
| -1 :x: | pylint | 0m 0s | Error running pylint. Please check pylint stderr files. |
| +1 :green_heart: | javadoc | 0m 22s | master passed |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 5m 54s | the patch passed |
| -1 :x: | pylint | 0m 0s | Error running pylint. Please check pylint stderr files. |
| +1 :green_heart: | pylint | 0m 0s | There were no new pylint issues. |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | javadoc | 0m 21s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 1m 40s | hbase-examples in the patch passed. |
| +1 :green_heart: | asflicense | 0m 15s | The patch does not generate ASF License warnings. |
| | | 15m 40s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-988/2/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/988 |
| Optional Tests | dupname asflicense javac javadoc unit pylint |
| uname | Linux b2f68058fb7d 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-988/out/precommit/personality/provided.sh |
| git revision | master / ab9766599d |
| Default Java | 1.8.0_181 |
| pylint | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-988/2/artifact/out/branch-pylint-stderr.txt |
| pylint | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-988/2/artifact/out/patch-pylint-stderr.txt |
| Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-988/2/testReport/ |
| Max. process+thread count | 2179 (vs. ulimit of 10000) |
| modules | C: hbase-examples U: hbase-examples |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-988/2/console |
| versions | git=2.11.0 maven=2018-06-17T18:33:14Z) pylint=1.6.5 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] pytalkweb commented on issue #988: Made DemoClient python
3.0 compatible ..
Posted by GitBox <gi...@apache.org>.
pytalkweb commented on issue #988: Made DemoClient python 3.0 compatible ..
URL: https://github.com/apache/hbase/pull/988#issuecomment-578470642
It seems problem might be with script that runs pylint as stderr.txt
says there is no such option —score. Please see below.
Usage: pylint [options] module_or_package
Check that a module satisfies a coding standard (and more !).
pylint --help
Display this help message and exit.
pylint --help-msg <msg-id>[,<msg-id>]
Display help messages about given message identifiers and exit.
pylint: error: no such option: --score
Regards, Madhu
On Fri, Jan 24, 2020 at 9:02 AM Jan Hentschel <no...@github.com>
wrote:
> @pytalkweb <https://github.com/pytalkweb> We're running pylint from the
> build. Could you please check your changes with pylint?
>
> —
> You are receiving this because you were mentioned.
>
>
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/hbase/pull/988?email_source=notifications&email_token=ALFG3HQ4HGAZODJLFNTTIKLQ7L7JBA5CNFSM4KCVOL62YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJ3B7AI#issuecomment-578166657>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/ALFG3HTCLLCDIFAWXGCCAWLQ7L7JBANCNFSM4KCVOL6Q>
> .
>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] busbey commented on issue #988: Made DemoClient python 3.0
compatible ..
Posted by GitBox <gi...@apache.org>.
busbey commented on issue #988: Made DemoClient python 3.0 compatible ..
URL: https://github.com/apache/hbase/pull/988#issuecomment-571185082
Does this still work with python 2? Or is it python 3 only?
I'd be fine with the master branch being python 3 only if we can make branch-2 python 2 and python 3. This could be done with mutliple examples if needed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] pytalkweb commented on issue #988: Made DemoClient python
3.0 compatible ..
Posted by GitBox <gi...@apache.org>.
pytalkweb commented on issue #988: Made DemoClient python 3.0 compatible ..
URL: https://github.com/apache/hbase/pull/988#issuecomment-573251595
The file DemoClient.py that I made a new pull request in
https://github.com/apache/hbase works with python 3.X. I'm not sure what
the issue with github is, it has broken heart with -1 on top with some
error from pylint. I'm not sure what I need to do to get it fixed. If you
can let me know, I can get it committed.
On Mon, Jan 6, 2020 at 9:34 AM Sean Busbey <no...@github.com> wrote:
> Does this still work with python 2? Or is it python 3 only?
>
> I'd be fine with the master branch being python 3 only if we can make
> branch-2 python 2 and python 3. This could be done with mutliple examples
> if needed.
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/hbase/pull/988?email_source=notifications&email_token=ALFG3HQ2EC6MW4OXB3F26B3Q4NFOZA5CNFSM4KCVOL62YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEIFZPOQ#issuecomment-571185082>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/ALFG3HQV4E55L6A4AERW7J3Q4NFOZANCNFSM4KCVOL6Q>
> .
>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] Apache-HBase commented on issue #988: Made DemoClient
python 3.0 compatible ..
Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on issue #988: Made DemoClient python 3.0 compatible ..
URL: https://github.com/apache/hbase/pull/988#issuecomment-570775887
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 0m 33s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| -0 :warning: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
||| _ master Compile Tests _ |
| +1 :green_heart: | mvninstall | 5m 30s | master passed |
| -1 :x: | pylint | 0m 1s | Error running pylint. Please check pylint stderr files. |
| +1 :green_heart: | javadoc | 0m 22s | master passed |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 4m 56s | the patch passed |
| -1 :x: | pylint | 0m 2s | Error running pylint. Please check pylint stderr files. |
| +1 :green_heart: | pylint | 0m 2s | There were no new pylint issues. |
| +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 :green_heart: | javadoc | 0m 19s | the patch passed |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 1m 40s | hbase-examples in the patch passed. |
| +1 :green_heart: | asflicense | 0m 14s | The patch does not generate ASF License warnings. |
| | | 14m 50s | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.5 Server=19.03.5 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-988/1/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hbase/pull/988 |
| Optional Tests | dupname asflicense javac javadoc unit pylint |
| uname | Linux 746236977ed4 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-988/out/precommit/personality/provided.sh |
| git revision | master / ab9766599d |
| Default Java | 1.8.0_181 |
| pylint | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-988/1/artifact/out/branch-pylint-stderr.txt |
| pylint | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-988/1/artifact/out/patch-pylint-stderr.txt |
| Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-988/1/testReport/ |
| Max. process+thread count | 2171 (vs. ulimit of 10000) |
| modules | C: hbase-examples U: hbase-examples |
| Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-988/1/console |
| versions | git=2.11.0 maven=2018-06-17T18:33:14Z) pylint=1.6.5 |
| Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] HorizonNet commented on issue #988: Made DemoClient python
3.0 compatible ..
Posted by GitBox <gi...@apache.org>.
HorizonNet commented on issue #988: Made DemoClient python 3.0 compatible ..
URL: https://github.com/apache/hbase/pull/988#issuecomment-578497642
The pylint problems could be the same as in #1088.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [hbase] busbey commented on issue #988: Made DemoClient python 3.0
compatible ..
Posted by GitBox <gi...@apache.org>.
busbey commented on issue #988: Made DemoClient python 3.0 compatible ..
URL: https://github.com/apache/hbase/pull/988#issuecomment-578854649
Just to reiterate here, I would be fine with this being Python 3 only in the master branch, but to do that we need an option to maintain python 2 for branch-2 / branch-1 and hopefully opt-in to python 3 on branch-2 at least.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services