You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/03/23 03:53:51 UTC
[GitHub] [skywalking-kubernetes] innerpeacez commented on a change in pull
request #41: fix https://github.com/apache/skywalking/issues/4512
innerpeacez commented on a change in pull request #41: fix https://github.com/apache/skywalking/issues/4512
URL: https://github.com/apache/skywalking-kubernetes/pull/41#discussion_r396201638
##########
File path: chart/skywalking/templates/es-init.job.yaml
##########
@@ -55,7 +55,11 @@ spec:
{{- else }}
value: "{{ .Values.elasticsearch.config.host }}:{{ .Values.elasticsearch.config.port.http }}"
{{- end }}
+ - name: SW_ES_USER
Review comment:
Need to determine whether these two keys exist, some users do not need to fill in these two keys. And you need to note that `elasticseach.config.xx` is currently only available to users who already have elasticseach.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services