You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Klaus Ma <kl...@gmail.com> on 2016/02/21 06:10:22 UTC
Review Request 43807: Replaced with /Users/klaus in authentication.md.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43807/
-----------------------------------------------------------
Review request for mesos, Adam B and Till Toenshoff.
Repository: mesos
Description
-------
Replaced with /Users/klaus in authentication.md.
Diffs
-----
docs/authentication.md c7649bb279312e3183d8c977811d12121208f9f8
Diff: https://reviews.apache.org/r/43807/diff/
Testing
-------
Can not parss `~` to $HOME in Mac OS; update document to use $HOME. Test passed in Mac OS.
Failed when using `~`:
I0221 13:08:41.717308 4284416 credentials.hpp:35] Loading credentials for authentication from '~/credentials'
Failed to read credentials file '~/credentials': Failed to open file '~/credentials': No such file or directory (see --credentials flag)
Thanks,
Klaus Ma
Re: Review Request 43807: Replaced with /Users/klaus in
authentication.md.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43807/#review120059
-----------------------------------------------------------
Patch looks great!
Reviews applied: [43807]
Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On Feb. 21, 2016, 5:10 a.m., Klaus Ma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43807/
> -----------------------------------------------------------
>
> (Updated Feb. 21, 2016, 5:10 a.m.)
>
>
> Review request for mesos, Adam B and Till Toenshoff.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Replaced with /Users/klaus in authentication.md.
>
>
> Diffs
> -----
>
> docs/authentication.md c7649bb279312e3183d8c977811d12121208f9f8
>
> Diff: https://reviews.apache.org/r/43807/diff/
>
>
> Testing
> -------
>
> Can not parss `~` to $HOME in Mac OS; update document to use $HOME. Test passed in Mac OS.
>
> Failed when using `~`:
> I0221 13:08:41.717308 4284416 credentials.hpp:35] Loading credentials for authentication from '~/credentials'
> Failed to read credentials file '~/credentials': Failed to open file '~/credentials': No such file or directory (see --credentials flag)
>
>
> Thanks,
>
> Klaus Ma
>
>
Re: Review Request 43807: Replaced with `~` in authentication.md.
Posted by Klaus Ma <kl...@gmail.com>.
> On Feb. 22, 2016, 11:57 a.m., haosdent huang wrote:
> > docs/authentication.md, line 97
> > <https://reviews.apache.org/r/43807/diff/1/?file=1263606#file1263606line97>
> >
> > I try `echo ~/a` in both bash and zsh. Seems it works for me. And do we have a jira ticket related to this?
Yes, it works in shell for me too; but we did not replace `~` in mesos, and it seems shell did not replace it when passing it to mesos.
- Klaus
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43807/#review120099
-----------------------------------------------------------
On Feb. 21, 2016, 2:42 p.m., Klaus Ma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43807/
> -----------------------------------------------------------
>
> (Updated Feb. 21, 2016, 2:42 p.m.)
>
>
> Review request for mesos, Adam B and Till Toenshoff.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Replaced with `~` in authentication.md.
>
>
> Diffs
> -----
>
> docs/authentication.md c7649bb279312e3183d8c977811d12121208f9f8
>
> Diff: https://reviews.apache.org/r/43807/diff/
>
>
> Testing
> -------
>
> Can not parss `~` to $HOME in Mac OS; update document to use $HOME. Test passed in Mac OS.
>
> Failed when using `~`:
> I0221 13:08:41.717308 4284416 credentials.hpp:35] Loading credentials for authentication from '~/credentials'
> Failed to read credentials file '~/credentials': Failed to open file '~/credentials': No such file or directory (see --credentials flag)
>
>
> Thanks,
>
> Klaus Ma
>
>
Re: Review Request 43807: Replaced with `~` in authentication.md.
Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43807/#review120099
-----------------------------------------------------------
docs/authentication.md (line 97)
<https://reviews.apache.org/r/43807/#comment181477>
I try `echo ~/a` in both bash and zsh. Seems it works for me. And do we have a jira ticket related to this?
- haosdent huang
On Feb. 21, 2016, 6:42 a.m., Klaus Ma wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43807/
> -----------------------------------------------------------
>
> (Updated Feb. 21, 2016, 6:42 a.m.)
>
>
> Review request for mesos, Adam B and Till Toenshoff.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Replaced with `~` in authentication.md.
>
>
> Diffs
> -----
>
> docs/authentication.md c7649bb279312e3183d8c977811d12121208f9f8
>
> Diff: https://reviews.apache.org/r/43807/diff/
>
>
> Testing
> -------
>
> Can not parss `~` to $HOME in Mac OS; update document to use $HOME. Test passed in Mac OS.
>
> Failed when using `~`:
> I0221 13:08:41.717308 4284416 credentials.hpp:35] Loading credentials for authentication from '~/credentials'
> Failed to read credentials file '~/credentials': Failed to open file '~/credentials': No such file or directory (see --credentials flag)
>
>
> Thanks,
>
> Klaus Ma
>
>
Re: Review Request 43807: Replaced with `~` in authentication.md.
Posted by Klaus Ma <kl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43807/
-----------------------------------------------------------
(Updated Feb. 21, 2016, 2:42 p.m.)
Review request for mesos, Adam B and Till Toenshoff.
Changes
-------
Update summary.
Summary (updated)
-----------------
Replaced with `~` in authentication.md.
Repository: mesos
Description (updated)
-------
Replaced with `~` in authentication.md.
Diffs
-----
docs/authentication.md c7649bb279312e3183d8c977811d12121208f9f8
Diff: https://reviews.apache.org/r/43807/diff/
Testing
-------
Can not parss `~` to $HOME in Mac OS; update document to use $HOME. Test passed in Mac OS.
Failed when using `~`:
I0221 13:08:41.717308 4284416 credentials.hpp:35] Loading credentials for authentication from '~/credentials'
Failed to read credentials file '~/credentials': Failed to open file '~/credentials': No such file or directory (see --credentials flag)
Thanks,
Klaus Ma