You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by zhangminglei <gi...@git.apache.org> on 2018/02/18 03:17:01 UTC
[GitHub] flink pull request #5519: [FLINK-8684] [config] Rework MesosTaskManagerParam...
GitHub user zhangminglei opened a pull request:
https://github.com/apache/flink/pull/5519
[FLINK-8684] [config] Rework MesosTaskManagerParameters#MESOS_RM_TASK…
## What is the purpose of the change
Directly by using ```TaskManagerOptions.NUM_TASK_SLOTS``` as it's alias to rework the ```ConfigOption```. to avoid creating 2 documentation entries of ```taskmanager.numberOfTaskSlots```.
## Brief change log
Use FLINK-8683 test this change.
## Verifying this change
This change is a trivial rework.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: ( no)
- The runtime per-record code paths (performance sensitive): (/ no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (/ no )
- The S3 file system connector: ( no )
## Documentation
- Does this pull request introduce a new feature? ( no)
- If yes, how is the feature documented? ( not documented)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zhangminglei/flink flink-8684
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/5519.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5519
----
commit 2ea03310b29d69f56c637a2c367dad38c892c3ff
Author: zhangminglei <zm...@...>
Date: 2018-02-18T03:01:39Z
[FLINK-8684] [config] Rework MesosTaskManagerParameters#MESOS_RM_TASKS_SLOTS
----
---
[GitHub] flink issue #5519: [FLINK-8684] [config] Rework MesosTaskManagerParameters#M...
Posted by zhangminglei <gi...@git.apache.org>.
Github user zhangminglei commented on the issue:
https://github.com/apache/flink/pull/5519
I'm not very sure whether this PR is necessarily needed, as this already seems to be fixed at FLINK-8683
---
[GitHub] flink pull request #5519: [FLINK-8684] [config] Rework MesosTaskManagerParam...
Posted by zhangminglei <gi...@git.apache.org>.
Github user zhangminglei closed the pull request at:
https://github.com/apache/flink/pull/5519
---
[GitHub] flink issue #5519: [FLINK-8684] [config] Rework MesosTaskManagerParameters#M...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5519
Correct, I've included a fix for FLINK-8684 in the [PR](https://github.com/apache/flink/pull/5515) for FLINK-8683.
---