You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/12/09 07:08:50 UTC

[GitHub] [spark] Ngone51 opened a new pull request, #38995: [SPARK-41460][CORE] Introduce IsolatedThreadSafeRpcEndpoint to extend IsolatedRpcEndpoint

Ngone51 opened a new pull request, #38995:
URL: https://github.com/apache/spark/pull/38995

   <!--
   Thanks for sending a pull request!  Here are some tips for you:
     1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
     2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
     3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
     4. Be sure to keep the PR description updated to reflect all changes.
     5. Please write your PR title to summarize what this PR proposes.
     6. If possible, provide a concise example to reproduce the issue for a faster review.
     7. If you want to add a new configuration, please read the guideline first for naming configurations in
        'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
     8. If you want to add or modify an error type or message, please read the guideline first in
        'core/src/main/resources/error/README.md'.
   -->
   
   ### What changes were proposed in this pull request?
   <!--
   Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue. 
   If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
     1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
     2. If you fix some SQL features, you can provide some references of other DBMSes.
     3. If there is design documentation, please add the link.
     4. If there is a discussion in the mailing list, please add the link.
   -->
   
   This PR introduces a new layer `IsolatedThreadSafeRpcEndpoint` to extend `IsolatedRpcEndpoint` and changes all the endpoints which extend `IsolatedRpcEndpoint` to extend `IsolatedThreadSafeRpcEndpoint` instead.
   
   
   ### Why are the changes needed?
   <!--
   Please clarify why the changes are needed. For instance,
     1. If you propose a new API, clarify the use case for a new API.
     2. If you fix a bug, you can clarify why it is a bug.
   -->
   
   Busy endpoints like `DriverEndpoint`, `BlockManagerMasterEndpoint` were known to be thread-safe when they extended `ThreadSafeRpcEndpoint`. After we introduce `IsolatedRpcEndpoint` in [SPARK-29398](https://issues.apache.org/jira/browse/SPARK-29398),  all these busy endpoints have been changed to extend `IsolatedRpcEndpoint`. These busy endpoints are still thread-safe since `IsolatedRpcEndpoint` by default only uses 1 thread. But that's not explicit to developers now compared to `ThreadSafeRpcEndpoint` (I actually find some people became to be confused about whether the endpoint is thread-safe or not). From time to time, `IsolatedRpcEndpoint#threadCount` might be mistakenly overridden with threadCount > 1 leading to thread-safety being broken. So this PR refactor here a bit to avoid the potential issue.
   
   
   ### Does this PR introduce _any_ user-facing change?
   <!--
   Note that it means *any* user-facing change including all aspects such as the documentation fix.
   If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
   If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
   If no, write 'No'.
   -->
   
   No.
   
   
   ### How was this patch tested?
   <!--
   If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
   If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
   If tests were not added, please describe why they were not added and/or why it was difficult to add.
   If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
   -->
   
   N/A


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] Ngone51 commented on pull request #38995: [SPARK-41460][CORE] Introduce `IsolatedThreadSafeRpcEndpoint` to extend `IsolatedRpcEndpoint`

Posted by GitBox <gi...@apache.org>.
Ngone51 commented on PR #38995:
URL: https://github.com/apache/spark/pull/38995#issuecomment-1346071311

   Thanks @dongjoon-hyun @mridulm 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] dongjoon-hyun commented on a diff in pull request #38995: [SPARK-41460][CORE] Introduce IsolatedThreadSafeRpcEndpoint to extend IsolatedRpcEndpoint

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on code in PR #38995:
URL: https://github.com/apache/spark/pull/38995#discussion_r1044329880


##########
core/src/main/scala/org/apache/spark/rpc/RpcEndpoint.scala:
##########
@@ -153,12 +153,25 @@ private[spark] trait ThreadSafeRpcEndpoint extends RpcEndpoint
 private[spark] trait IsolatedRpcEndpoint extends RpcEndpoint {
 
   /**
-   * How many threads to use for delivering messages. By default, use a single thread.
+   * How many threads to use for delivering messages.
    *
    * Note that requesting more than one thread means that the endpoint should be able to handle
    * messages arriving from many threads at once, and all the things that entails (including
    * messages being delivered to the endpoint out of order).
    */
-  def threadCount(): Int = 1
+  def threadCount(): Int
+
+}
+
+/**
+ * An endpoint that uses a dedicated thread pool for delivering messages and
+ * ensured to be thread-safe.
+ */
+private[spark] trait IsolatedThreadSafeRpcEndpoint extends IsolatedRpcEndpoint {
+
+  /**
+   * Limit the threadCount to 1 so that messages are ensured to be handled in a thread-safe way.
+   */
+  final def threadCount(): Int = 1

Review Comment:
   According to the PR description, this `final def` is the main contribution, @Ngone51 ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] Ngone51 commented on a diff in pull request #38995: [SPARK-41460][CORE] Introduce IsolatedThreadSafeRpcEndpoint to extend IsolatedRpcEndpoint

Posted by GitBox <gi...@apache.org>.
Ngone51 commented on code in PR #38995:
URL: https://github.com/apache/spark/pull/38995#discussion_r1044465902


##########
core/src/main/scala/org/apache/spark/rpc/RpcEndpoint.scala:
##########
@@ -153,12 +153,25 @@ private[spark] trait ThreadSafeRpcEndpoint extends RpcEndpoint
 private[spark] trait IsolatedRpcEndpoint extends RpcEndpoint {
 
   /**
-   * How many threads to use for delivering messages. By default, use a single thread.
+   * How many threads to use for delivering messages.
    *
    * Note that requesting more than one thread means that the endpoint should be able to handle
    * messages arriving from many threads at once, and all the things that entails (including
    * messages being delivered to the endpoint out of order).
    */
-  def threadCount(): Int = 1
+  def threadCount(): Int
+
+}
+
+/**
+ * An endpoint that uses a dedicated thread pool for delivering messages and
+ * ensured to be thread-safe.
+ */
+private[spark] trait IsolatedThreadSafeRpcEndpoint extends IsolatedRpcEndpoint {
+
+  /**
+   * Limit the threadCount to 1 so that messages are ensured to be handled in a thread-safe way.
+   */
+  final def threadCount(): Int = 1

Review Comment:
   Yes, and also the naming of `IsolatedThreadSafeRpcEndpoint`. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] dongjoon-hyun commented on pull request #38995: [SPARK-41460][CORE] Introduce `IsolatedThreadSafeRpcEndpoint` to extend `IsolatedRpcEndpoint`

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on PR #38995:
URL: https://github.com/apache/spark/pull/38995#issuecomment-1345406918

   Let me merge this to Apache Spark 3.4.0 because this PR is conservative and we can remove the unused one later, @Ngone51 and @mridulm .


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] Ngone51 commented on pull request #38995: [SPARK-41460][CORE] Introduce IsolatedThreadSafeRpcEndpoint to extend IsolatedRpcEndpoint

Posted by GitBox <gi...@apache.org>.
Ngone51 commented on PR #38995:
URL: https://github.com/apache/spark/pull/38995#issuecomment-1343967442

   > What about renaming IsolatedRpcEndpoint to IsolatedThreadSafeRpcEndpoint simply?
   
   I think this would breach the original design by the author argued at https://github.com/apache/spark/pull/26059#discussion_r336083143. I don't want to break it, though I also don't have a use case of `IsolatedButNotThreadSafeRpcEndpoint` in my mind.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] dongjoon-hyun commented on pull request #38995: [SPARK-41460][CORE] Introduce `IsolatedThreadSafeRpcEndpoint` to extend `IsolatedRpcEndpoint`

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on PR #38995:
URL: https://github.com/apache/spark/pull/38995#issuecomment-1345387564

   According to @Ngone51 's [comment](https://github.com/apache/spark/pull/38995#issuecomment-1343967442), he seems to keep it as the original design concept. Otherwise, this PR should be a simple renaming like my [comment](https://github.com/apache/spark/pull/38995#pullrequestreview-1211220495).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] dongjoon-hyun closed pull request #38995: [SPARK-41460][CORE] Introduce `IsolatedThreadSafeRpcEndpoint` to extend `IsolatedRpcEndpoint`

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #38995: [SPARK-41460][CORE] Introduce `IsolatedThreadSafeRpcEndpoint` to extend `IsolatedRpcEndpoint`
URL: https://github.com/apache/spark/pull/38995


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org