You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/03/23 09:49:51 UTC

[GitHub] [pulsar] codelipenghui commented on a change in pull request #14809: [fix][txn]: fix cannot enable transaction when is allow auto update schema enabled=fasle

codelipenghui commented on a change in pull request #14809:
URL: https://github.com/apache/pulsar/pull/14809#discussion_r833057404



##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/AbstractTopic.java
##########
@@ -608,6 +609,10 @@ public String getReplicatorPrefix() {
     }
 
     private boolean allowAutoUpdateSchema() {
+        if (topic.contains(EventsTopicNames.TRANSACTION_BUFFER_SNAPSHOT)

Review comment:
       We should allow auto-upload schema for all system topics? Otherwise, for pulsar internal system topic, users need to upload the schema or we need to provide a way to generate schema, looks confused for users.
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org