You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2023/01/19 11:21:27 UTC

[GitHub] [cloudstack] weizhouapache commented on a diff in pull request #6809: Reserve memory for host

weizhouapache commented on code in PR #6809:
URL: https://github.com/apache/cloudstack/pull/6809#discussion_r1081127968


##########
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java:
##########
@@ -990,7 +992,16 @@ public boolean configure(final String name, final Map<String, Object> params) th
         _videoRam = AgentPropertiesFileHandler.getPropertyValue(AgentProperties.VM_VIDEO_RAM);
 
         // Reserve 1GB unless admin overrides
-        _dom0MinMem = ByteScaleUtils.mebibytesToBytes(AgentPropertiesFileHandler.getPropertyValue(AgentProperties.HOST_RESERVED_MEM_MB));
+        long reservedMemory = AgentPropertiesFileHandler.getPropertyValue(AgentProperties.HOST_RESERVED_MEM_MB);
+
+        value = (String)params.get(ConfigurationManagerImpl.HOST_RESERVED_MEM_MB.key());

Review Comment:
   these lines are not needed I think.
   
   @GutoVeronezi 
   can you confirm ?
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org