You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@kyuubi.apache.org by GitBox <gi...@apache.org> on 2022/05/18 01:47:23 UTC

[GitHub] [incubator-kyuubi] hddong commented on pull request #2678: [KYUUBI #2285] trino's result fetching method is changed to a streaming iterator mode to avoid hold data at server side

hddong commented on PR #2678:
URL: https://github.com/apache/incubator-kyuubi/pull/2678#issuecomment-1129482439

   > > I think we can give an option to cache the result on engine side, it will not affect Kyuubi server even if engine crash by OOM. Another idea is re-run query if the client request the fetch FIRST after consuming, it's usually for export cases.
   > 
   > Can we consider implementing FETCH_FIRST in KyuybiJDBC Client, so that keep the immediate result return feature of trino?
   
   Or we just Keep the previous `execute(): Iterable[List[Any]]` as `executeCollect(): Iterable[List[Any]]` , and run:
   ```
   iter =
       if (incrementalCollect) {
         info("Execute in incremental collect mode")
         FetchIterator.fromIterator(trinoStatement.execute())
       } else {
         info("Execute in full collect mode")
         new ArrayFetchIterator(trinoStatement.executeCollect())
       }
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org