You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@jena.apache.org by GitBox <gi...@apache.org> on 2022/08/02 11:15:26 UTC
[GitHub] [jena] afs opened a new pull request, #1469: GH-1468: Improve exclusions due to overlapping dependencies
afs opened a new pull request, #1469:
URL: https://github.com/apache/jena/pull/1469
GitHub issue resolved #1468
Pull request Description:
Exclude org.slf4j from jsonld-java and lib-thrift.
Exclude org.slf4j from libthrift.
Tested using another project where the dependency resolution via apache-jena-libs causes enforcer plugin alerts when using rule `<dependencyConvergence/>`.
----
By submitting this pull request, I acknowledge that I am making a contribution to the Apache Software Foundation under the terms and conditions of the [Contributor's Agreement](https://www.apache.org/licenses/contributor-agreements.html).
----
See the [Apache Jena "Contributing" guide](https://github.com/apache/jena/blob/main/CONTRIBUTING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
[GitHub] [jena] afs commented on a diff in pull request #1469: GH-1468: Improve exclusions due to overlapping dependencies
Posted by GitBox <gi...@apache.org>.
afs commented on code in PR #1469:
URL: https://github.com/apache/jena/pull/1469#discussion_r935648568
##########
pom.xml:
##########
@@ -407,6 +412,15 @@
<groupId>commons-logging</groupId>
<artifactId>commons-logging</artifactId>
</exclusion>
+ <exclusion>
+ <groupId>commons-io</groupId>
+ <artifactId>commons-io</artifactId>
+ </exclusion>
+ <exclusion>
+ <groupId>org.slf4j</groupId>
+ <artifactId>*</artifactId>
Review Comment:
Until about 3 hours ago, neither did I!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
[GitHub] [jena] kinow commented on a diff in pull request #1469: GH-1468: Improve exclusions due to overlapping dependencies
Posted by GitBox <gi...@apache.org>.
kinow commented on code in PR #1469:
URL: https://github.com/apache/jena/pull/1469#discussion_r935480542
##########
pom.xml:
##########
@@ -407,6 +412,15 @@
<groupId>commons-logging</groupId>
<artifactId>commons-logging</artifactId>
</exclusion>
+ <exclusion>
+ <groupId>commons-io</groupId>
+ <artifactId>commons-io</artifactId>
+ </exclusion>
+ <exclusion>
+ <groupId>org.slf4j</groupId>
+ <artifactId>*</artifactId>
Review Comment:
Had no idea you could exclude a whole groupId like this :facepalm: have always added entries separately. Good to know!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
[GitHub] [jena] afs merged pull request #1469: GH-1468: Improve exclusions due to overlapping dependencies
Posted by GitBox <gi...@apache.org>.
afs merged PR #1469:
URL: https://github.com/apache/jena/pull/1469
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org