You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Charles Reiss <wo...@gmail.com> on 2011/11/03 00:45:46 UTC
Review Request: Make macros in tests/utils.hpp more robust
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2685/
-----------------------------------------------------------
Review request for mesos.
Summary
-------
See description of bugs in MESOS-59.
This addresses bug MESOS-59.
https://issues.apache.org/jira/browse/MESOS-59
Diffs
-----
src/tests/utils.hpp 02772f7
Diff: https://reviews.apache.org/r/2685/diff
Testing
-------
Thanks,
Charles
Re: Review Request: Make macros in tests/utils.hpp more robust
Posted by Benjamin Hindman <be...@berkeley.edu>.
> On 2011-11-14 19:29:50, Benjamin Hindman wrote:
> > src/tests/utils.hpp, line 185
> > <https://reviews.apache.org/r/2685/diff/1/?file=55928#file55928line185>
> >
> > Let's do s/_filter/object just so we don't introduce this underscore convention in the code base. If you have a better name than 'object' (e.g., receiver?), please suggest it. Also, if you can think of a way to make triggering on messages even more abstracted (i.e., no need for MockFilter object and process::filter) that would be splendid!
>
> Charles Reiss wrote:
> I choose the name 'mock_filter'.
>
> (Er, and apologies for the empty comment spam here...)
No worries, but let's make it mockFilter. ;)
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2685/#review3212
-----------------------------------------------------------
On 2011-11-14 20:31:10, Charles Reiss wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/2685/
> -----------------------------------------------------------
>
> (Updated 2011-11-14 20:31:10)
>
>
> Review request for mesos.
>
>
> Summary
> -------
>
> See description of bugs in MESOS-59.
>
>
> This addresses bug MESOS-59.
> https://issues.apache.org/jira/browse/MESOS-59
>
>
> Diffs
> -----
>
> src/tests/utils.hpp 02772f7
>
> Diff: https://reviews.apache.org/r/2685/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Charles
>
>
Re: Review Request: Make macros in tests/utils.hpp more robust
Posted by Charles Reiss <wo...@gmail.com>.
> On 2011-11-14 19:29:50, Benjamin Hindman wrote:
> > src/tests/utils.hpp, line 185
> > <https://reviews.apache.org/r/2685/diff/1/?file=55928#file55928line185>
> >
> > Let's do s/_filter/object just so we don't introduce this underscore convention in the code base. If you have a better name than 'object' (e.g., receiver?), please suggest it. Also, if you can think of a way to make triggering on messages even more abstracted (i.e., no need for MockFilter object and process::filter) that would be splendid!
I choose the name 'mock_filter'.
(Er, and apologies for the empty comment spam here...)
- Charles
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2685/#review3212
-----------------------------------------------------------
On 2011-11-14 20:31:10, Charles Reiss wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/2685/
> -----------------------------------------------------------
>
> (Updated 2011-11-14 20:31:10)
>
>
> Review request for mesos.
>
>
> Summary
> -------
>
> See description of bugs in MESOS-59.
>
>
> This addresses bug MESOS-59.
> https://issues.apache.org/jira/browse/MESOS-59
>
>
> Diffs
> -----
>
> src/tests/utils.hpp 02772f7
>
> Diff: https://reviews.apache.org/r/2685/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Charles
>
>
Re: Review Request: Make macros in tests/utils.hpp more robust
Posted by Charles Reiss <wo...@gmail.com>.
> On 2011-11-14 19:29:50, Benjamin Hindman wrote:
> > src/tests/utils.hpp, line 185
> > <https://reviews.apache.org/r/2685/diff/1/?file=55928#file55928line185>
> >
> > Let's do s/_filter/object just so we don't introduce this underscore convention in the code base. If you have a better name than 'object' (e.g., receiver?), please suggest it. Also, if you can think of a way to make triggering on messages even more abstracted (i.e., no need for MockFilter object and process::filter) that would be splendid!
>
> Charles Reiss wrote:
> I choose the name 'mock_filter'.
>
> (Er, and apologies for the empty comment spam here...)
>
> Benjamin Hindman wrote:
> No worries, but let's make it mockFilter. ;)
Done. (6 days ago, but I guess just posting an updated diff doesn't make it clear.)
- Charles
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2685/#review3212
-----------------------------------------------------------
On 2011-11-14 23:13:38, Charles Reiss wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/2685/
> -----------------------------------------------------------
>
> (Updated 2011-11-14 23:13:38)
>
>
> Review request for mesos.
>
>
> Summary
> -------
>
> See description of bugs in MESOS-59.
>
>
> This addresses bug MESOS-59.
> https://issues.apache.org/jira/browse/MESOS-59
>
>
> Diffs
> -----
>
> src/tests/utils.hpp 02772f7
>
> Diff: https://reviews.apache.org/r/2685/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Charles
>
>
Re: Review Request: Make macros in tests/utils.hpp more robust
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2685/#review3212
-----------------------------------------------------------
Ship it!
src/tests/utils.hpp
<https://reviews.apache.org/r/2685/#comment7133>
Let's do s/_filter/object just so we don't introduce this underscore convention in the code base. If you have a better name than 'object' (e.g., receiver?), please suggest it. Also, if you can think of a way to make triggering on messages even more abstracted (i.e., no need for MockFilter object and process::filter) that would be splendid!
- Benjamin
On 2011-11-02 23:45:46, Charles Reiss wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/2685/
> -----------------------------------------------------------
>
> (Updated 2011-11-02 23:45:46)
>
>
> Review request for mesos.
>
>
> Summary
> -------
>
> See description of bugs in MESOS-59.
>
>
> This addresses bug MESOS-59.
> https://issues.apache.org/jira/browse/MESOS-59
>
>
> Diffs
> -----
>
> src/tests/utils.hpp 02772f7
>
> Diff: https://reviews.apache.org/r/2685/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Charles
>
>
Re: Review Request: Make macros in tests/utils.hpp more robust
Posted by Charles Reiss <wo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2685/#review3224
-----------------------------------------------------------
- Charles
On 2011-11-02 23:45:46, Charles Reiss wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/2685/
> -----------------------------------------------------------
>
> (Updated 2011-11-02 23:45:46)
>
>
> Review request for mesos.
>
>
> Summary
> -------
>
> See description of bugs in MESOS-59.
>
>
> This addresses bug MESOS-59.
> https://issues.apache.org/jira/browse/MESOS-59
>
>
> Diffs
> -----
>
> src/tests/utils.hpp 02772f7
>
> Diff: https://reviews.apache.org/r/2685/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Charles
>
>
Re: Review Request: Make macros in tests/utils.hpp more robust
Posted by Charles Reiss <wo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2685/#review3223
-----------------------------------------------------------
- Charles
On 2011-11-02 23:45:46, Charles Reiss wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/2685/
> -----------------------------------------------------------
>
> (Updated 2011-11-02 23:45:46)
>
>
> Review request for mesos.
>
>
> Summary
> -------
>
> See description of bugs in MESOS-59.
>
>
> This addresses bug MESOS-59.
> https://issues.apache.org/jira/browse/MESOS-59
>
>
> Diffs
> -----
>
> src/tests/utils.hpp 02772f7
>
> Diff: https://reviews.apache.org/r/2685/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Charles
>
>
Re: Review Request: Make macros in tests/utils.hpp more robust
Posted by Charles Reiss <wo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2685/
-----------------------------------------------------------
(Updated 2011-11-14 23:13:38.136855)
Review request for mesos.
Summary
-------
See description of bugs in MESOS-59.
This addresses bug MESOS-59.
https://issues.apache.org/jira/browse/MESOS-59
Diffs (updated)
-----
src/tests/utils.hpp 02772f7
Diff: https://reviews.apache.org/r/2685/diff
Testing
-------
Thanks,
Charles
Re: Review Request: Make macros in tests/utils.hpp more robust
Posted by Charles Reiss <wo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2685/
-----------------------------------------------------------
(Updated 2011-11-14 20:31:10.001668)
Review request for mesos.
Summary
-------
See description of bugs in MESOS-59.
This addresses bug MESOS-59.
https://issues.apache.org/jira/browse/MESOS-59
Diffs (updated)
-----
src/tests/utils.hpp 02772f7
Diff: https://reviews.apache.org/r/2685/diff
Testing
-------
Thanks,
Charles
Re: Review Request: Make macros in tests/utils.hpp more robust
Posted by Charles Reiss <wo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2685/#review3225
-----------------------------------------------------------
- Charles
On 2011-11-02 23:45:46, Charles Reiss wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/2685/
> -----------------------------------------------------------
>
> (Updated 2011-11-02 23:45:46)
>
>
> Review request for mesos.
>
>
> Summary
> -------
>
> See description of bugs in MESOS-59.
>
>
> This addresses bug MESOS-59.
> https://issues.apache.org/jira/browse/MESOS-59
>
>
> Diffs
> -----
>
> src/tests/utils.hpp 02772f7
>
> Diff: https://reviews.apache.org/r/2685/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Charles
>
>