You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by achristianson <gi...@git.apache.org> on 2018/04/24 18:56:25 UTC
[GitHub] nifi-minifi-cpp pull request #311: MINIFICPP-432 Added docs for ApplyTemplat...
GitHub user achristianson opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/311
MINIFICPP-432 Added docs for ApplyTemplate
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with MINIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [x] If applicable, have you updated the LICENSE file?
- [x] If applicable, have you updated the NOTICE file?
### For documentation related changes:
- [x] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/achristianson/nifi-minifi-cpp MINIFICPP-432
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi-minifi-cpp/pull/311.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #311
----
commit e1cfba0075f8a90100fb73228fdfea6b9a7d72df
Author: Andrew I. Christianson <an...@...>
Date: 2018-04-24T18:55:55Z
MINIFICPP-432 Added docs for ApplyTemplate
----
---
[GitHub] nifi-minifi-cpp issue #311: MINIFICPP-432 Added docs for ApplyTemplate
Posted by phrocker <gi...@git.apache.org>.
Github user phrocker commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/311
I don't agree. I think if you place them in the ReadMe, then the ReadMe should include a comment since that is where bootstrapping information.
---
[GitHub] nifi-minifi-cpp issue #311: MINIFICPP-432 Added docs for ApplyTemplate
Posted by achristianson <gi...@git.apache.org>.
Github user achristianson commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/311
I think build instructions are out of scope for the processors usage docs. These docs are about the usage/functionality of processors, which could have any implementation really.
It would be useful to clear up build constraints for users; we already do to an extent in README.md. Perhaps the wiki where the extensions build flags are documented?
---
[GitHub] nifi-minifi-cpp pull request #311: MINIFICPP-432 Added docs for ApplyTemplat...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/nifi-minifi-cpp/pull/311
---
[GitHub] nifi-minifi-cpp issue #311: MINIFICPP-432 Added docs for ApplyTemplate
Posted by achristianson <gi...@git.apache.org>.
Github user achristianson commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/311
Agreed that should be documented. I created MINIFICPP-483 to do the build-time instructions. This ticket is for ApplyTemplate usage docs, which at the processor level is distinct from the template library implementation and it's build-time instructions.
---