You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2020/12/10 13:52:40 UTC
[GitHub] [ignite] tkalkirill opened a new pull request #8563: IGNITE-13831
tkalkirill opened a new pull request #8563:
URL: https://github.com/apache/ignite/pull/8563
Thank you for submitting the pull request to the Apache Ignite.
In order to streamline the review of the contribution
we ask you to ensure the following steps have been taken:
### The Contribution Checklist
- [ ] There is a single JIRA ticket related to the pull request.
- [ ] The web-link to the pull request is attached to the JIRA ticket.
- [ ] The JIRA ticket has the _Patch Available_ state.
- [ ] The pull request body describes changes that have been made.
The description explains _WHAT_ and _WHY_ was made instead of _HOW_.
- [ ] The pull request title is treated as the final commit message.
The following pattern must be used: `IGNITE-XXXX Change summary` where `XXXX` - number of JIRA issue.
- [ ] A reviewer has been mentioned through the JIRA comments
(see [the Maintainers list](https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute#HowtoContribute-ReviewProcessandMaintainers))
- [ ] The pull request has been checked by the Teamcity Bot and
the `green visa` attached to the JIRA ticket (see [TC.Bot: Check PR](https://mtcga.gridgain.com/prs.html))
### Notes
- [How to Contribute](https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute)
- [Coding abbreviation rules](https://cwiki.apache.org/confluence/display/IGNITE/Abbreviation+Rules)
- [Coding Guidelines](https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines)
- [Apache Ignite Teamcity Bot](https://cwiki.apache.org/confluence/display/IGNITE/Apache+Ignite+Teamcity+Bot)
If you need any help, please email dev@ignite.apache.org or ask anу advice on http://asf.slack.com _#ignite_ channel.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] asfgit closed pull request #8563: IGNITE-13831
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #8563:
URL: https://github.com/apache/ignite/pull/8563
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] akalash commented on a change in pull request #8563: IGNITE-13831
Posted by GitBox <gi...@apache.org>.
akalash commented on a change in pull request #8563:
URL: https://github.com/apache/ignite/pull/8563#discussion_r547922347
##########
File path: modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/wal/FileWriteAheadLogManager.java
##########
@@ -1059,6 +1079,7 @@ private boolean hasIndex(long absIdx) {
deleted++;
segmentSize.remove(desc.idx());
+ segmentAware.addCurrentWalArchiveSize(-len);
Review comment:
I think we should change the logical size firstly and only then physical size so segmentAware.addCurrentWalArchiveSize and segmentSize.remove should be swapped
##########
File path: modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/wal/FileWriteAheadLogManager.java
##########
@@ -1261,24 +1284,38 @@ private FileWriteHandle rollOver(FileWriteHandle cur, @Nullable WALRecord rec) t
switchSegmentRecordOffset.set(idx, hnd.getSwitchSegmentRecordOffset());
}
+ if (archiver == null)
+ segmentAware.addReservedWalArchiveSize(maxWalSegmentSize);
+
FileWriteHandle next;
try {
- next = initNextWriteHandle(cur);
- }
- catch (IgniteCheckedException e) {
- //Allow to avoid forever waiting in other threads.
- cur.signalNextAvailable();
+ try {
+ next = initNextWriteHandle(cur);
+ }
+ catch (IgniteCheckedException e) {
+ //Allow to avoid forever waiting in other threads.
+ cur.signalNextAvailable();
- throw e;
- }
+ throw e;
+ }
- if (rec != null) {
- WALPointer ptr = next.addRecord(rec);
+ if (rec != null) {
+ WALPointer ptr = next.addRecord(rec);
- assert ptr != null;
+ assert ptr != null;
+ }
+
+ segmentSize.put(next.getSegmentId(), maxWalSegmentSize);
+
+ if (archiver == null)
Review comment:
Can we avoid archiver check somehow? Maybe we can hold this info inside of segmentAware?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org