You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/01/31 04:41:46 UTC

[GitHub] [incubator-nuttx] yamt commented on a change in pull request #5332: arch/Toolchain.defs: Simplify addition builtin library to EXTRA_LIBS

yamt commented on a change in pull request #5332:
URL: https://github.com/apache/incubator-nuttx/pull/5332#discussion_r795339169



##########
File path: arch/arm/src/arm/Toolchain.defs
##########
@@ -103,21 +103,12 @@ OBJDUMP = $(CROSSDEV)objdump
 
 # Add the builtin library
 
-EXTRA_LIBS += -lgcc
-EXTRA_LIBPATHS += -L "${shell dirname "`$(CC) $(ARCHCPUFLAGS) --print-libgcc-file-name`"}"
+EXTRA_LIBS := ${shell $(CC) $(ARCHCPUFLAGS) --print-file-name=libgcc.a}

Review comment:
       what's the motivation to change --print-libgcc-file-name to --print-file-name=libgcc.a?
   
   iirc, the former has a better chance to work for clang configured to use non-libgcc runtime. (eg. compiler_rt)
   i don't know if it matters here though.
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org