You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@jena.apache.org by "william-vw (via GitHub)" <gi...@apache.org> on 2023/08/15 21:36:14 UTC

[GitHub] [jena] william-vw opened a new issue, #1987: rdfdiff

william-vw opened a new issue, #1987:
URL: https://github.com/apache/jena/issues/1987

   ### Version
   
   Latest
   
   ### What happened?
   
   rdfdiff is not functioning as expected. will issue a PR with suggested fixes & tests.
   
   ### Relevant output and stacktrace
   
   _No response_
   
   ### Are you interested in making a pull request?
   
   Yes


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@jena.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@jena.apache.org
For additional commands, e-mail: issues-help@jena.apache.org


[GitHub] [jena] afs commented on issue #1987: rdfdiff

Posted by "afs (via GitHub)" <gi...@apache.org>.
afs commented on issue #1987:
URL: https://github.com/apache/jena/issues/1987#issuecomment-1680380376

   Latest changed to 4.9.0 ... so it is always valid in the future :-)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@jena.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@jena.apache.org
For additional commands, e-mail: issues-help@jena.apache.org


[GitHub] [jena] afs commented on issue #1987: rdfdiff

Posted by "afs (via GitHub)" <gi...@apache.org>.
afs commented on issue #1987:
URL: https://github.com/apache/jena/issues/1987#issuecomment-1682144967

   Blank nodes are concrete. "concrete" covers the RDF terms that can go in an RDF graph and be printed.
   
   The test "triple.concrete" isn't appropriate (from reading the code).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@jena.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@jena.apache.org
For additional commands, e-mail: issues-help@jena.apache.org


[GitHub] [jena] rvesse commented on issue #1987: rdfdiff

Posted by "rvesse (via GitHub)" <gi...@apache.org>.
rvesse commented on issue #1987:
URL: https://github.com/apache/jena/issues/1987#issuecomment-1680203454

   Bug reports should contain actual steps to reproduce the issue - "not functioning as expected" - is not a useful bug report.  Please provide steps, including sample data, that show scenario(s) where two input graphs don't yield the expected diff


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@jena.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@jena.apache.org
For additional commands, e-mail: issues-help@jena.apache.org


[GitHub] [jena] william-vw commented on issue #1987: rdfdiff

Posted by "william-vw (via GitHub)" <gi...@apache.org>.
william-vw commented on issue #1987:
URL: https://github.com/apache/jena/issues/1987#issuecomment-1679611564

   see PR #1988


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@jena.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@jena.apache.org
For additional commands, e-mail: issues-help@jena.apache.org


[GitHub] [jena] william-vw commented on issue #1987: rdfdiff

Posted by "william-vw (via GitHub)" <gi...@apache.org>.
william-vw commented on issue #1987:
URL: https://github.com/apache/jena/issues/1987#issuecomment-1680531250

   > Bug reports should contain actual steps to reproduce the issue - "not functioning as expected" - is not a useful bug report. Please provide steps, including sample data, that show scenario(s) where two input graphs don't yield the expected diff
   
   You are right - apologies. I should've waited with this issue until I had enough time to elaborate.
   
   The issues I found:
   (lines refer to [original code](https://github.com/apache/jena/blob/main/jena-cmds/src/main/java/arq/rdfdiff.java))
   
   - Any statements with blank nodes are seen as concrete (lines 120, 135). (Node_Blank is a subclass of Node_Concrete, and thus returns true for #isConcrete, which I think is the issue here.)
   
   
   - A subgraph from the second set should be added to the candidates list, not the subgraph from first set that is being compared with (line 180).
   
   
   - For a statement's first non-encountered bnode, it creates a new subgraph and adds the statement and its _forward_ closure to it (lines 228-235).
   
   However, this does not support cases where multiple nodes end at the same bnode. If you run on testing/cmd/rdfdiff_1.ttl and testing/cmd/rdfdiff_2.ttl (after fixing the above), you see that the "England" triple is ignored as it was not part of the closure of the bnode shared with the "America" triple.
   
   There's a few solutions for this - my original PR implemented one potential solution, but now I'm unsure whether it's the way to go - perhaps adding a different kind of closure would be better.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@jena.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@jena.apache.org
For additional commands, e-mail: issues-help@jena.apache.org