You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@eagle.apache.org by haoch <gi...@git.apache.org> on 2017/02/21 16:00:27 UTC
[GitHub] eagle pull request #831: [EAGLE-918] Improve eagle auth to support @PermitAl...
GitHub user haoch opened a pull request:
https://github.com/apache/eagle/pull/831
[EAGLE-918] Improve eagle auth to support @PermitAll/DenyAll/RolesAllowed/Auth and API
* Improve eagle auth framework to support annotations under Jersey 1.9 and Dropwizard 0.7.1
~~~
@PermitAll
@DenyAll
@RolesAllowed
@Auth
~~~
* Add Authentication API
~~~
GET /auth/principal
GET /auth/validate
GET /auth/login
~~~
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/haoch/eagle EnableAuthAPI
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/eagle/pull/831.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #831
----
commit 5dc42d1ce5d9be74cfa0683bbef57ddcc3e8f1bb
Author: Hao Chen <ha...@apache.org>
Date: 2017-02-20T11:27:38Z
Add User.Role
commit 753d4bf87f52056ffc1717498bf829bb52517671
Author: Hao Chen <ha...@apache.org>
Date: 2017-02-21T09:49:01Z
Support @RolesAllowed @DenyAll @PermitAll security annoations
commit 3e16a20199d9c6af670d30b00dd065835e76a542
Author: Hao Chen <ha...@apache.org>
Date: 2017-02-21T11:41:54Z
Remove VISITOR role
commit 30c06cbc8381366e3c1847091f7ad52944b7a705
Author: Hao Chen <ha...@apache.org>
Date: 2017-02-21T11:42:23Z
Clean useless code
commit 844a05180deaff666472d74e50ba4cdd2269ebf0
Author: Hao Chen <ha...@apache.org>
Date: 2017-02-21T15:50:15Z
Improve Unit test coverage
commit 78d39c58e0956cbebb7e7f20d4469a7c2bd9eb78
Author: Hao Chen <ha...@apache.org>
Date: 2017-02-21T15:53:13Z
Rename package authentication to security
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] eagle issue #831: [EAGLE-918] Support auth annotations PermitAll/DenyAll/Rol...
Posted by haoch <gi...@git.apache.org>.
Github user haoch commented on the issue:
https://github.com/apache/eagle/pull/831
Merged as Approved by @r7raul1984
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] eagle issue #831: [EAGLE-918] Improve eagle auth to support @PermitAll/DenyA...
Posted by haoch <gi...@git.apache.org>.
Github user haoch commented on the issue:
https://github.com/apache/eagle/pull/831
@r7raul1984 I have finished this PR, please help continue to review. If no more problem, I will merge it after approved.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] eagle pull request #831: [EAGLE-918] Improve eagle auth to support @PermitAl...
Posted by haoch <gi...@git.apache.org>.
Github user haoch commented on a diff in the pull request:
https://github.com/apache/eagle/pull/831#discussion_r102397848
--- Diff: eagle-server/src/main/java/org/apache/eagle/server/authentication/config/UserAccount.java ---
@@ -0,0 +1,61 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ * <p>
+ * http://www.apache.org/licenses/LICENSE-2.0
+ * <p>
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.eagle.server.authentication.config;
+
+import org.apache.eagle.common.authentication.UserPrincipal;
+
+import java.util.List;
+
+public class UserAccount {
+ private String username;
+ private String password;
+ private List<UserPrincipal.Role> roles;
+
+ public UserAccount(String username, String password) {
+ this.username = username;
+ this.password = password;
+ }
+
+ public String getUsername() {
+ return username;
+ }
+
+ public void setUsername(String username) {
+ this.username = username;
+ }
+
+ public String getPassword() {
+ return password;
+ }
+
+ public void setPassword(String password) {
+ this.password = password;
--- End diff --
Resolved with password encryption.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] eagle issue #831: [EAGLE-918] Improve eagle auth to support @PermitAll/DenyA...
Posted by haoch <gi...@git.apache.org>.
Github user haoch commented on the issue:
https://github.com/apache/eagle/pull/831
@zombieJ please move on to refactor eagle login page after this PR merged.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] eagle pull request #831: [EAGLE-918] Support auth annotations PermitAll/Deny...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/eagle/pull/831
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] eagle pull request #831: [EAGLE-918] Improve eagle auth to support @PermitAl...
Posted by r7raul1984 <gi...@git.apache.org>.
Github user r7raul1984 commented on a diff in the pull request:
https://github.com/apache/eagle/pull/831#discussion_r102352634
--- Diff: eagle-server/src/main/java/org/apache/eagle/server/authentication/config/UserAccount.java ---
@@ -0,0 +1,61 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ * <p>
+ * http://www.apache.org/licenses/LICENSE-2.0
+ * <p>
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.eagle.server.authentication.config;
+
+import org.apache.eagle.common.authentication.UserPrincipal;
+
+import java.util.List;
+
+public class UserAccount {
+ private String username;
+ private String password;
+ private List<UserPrincipal.Role> roles;
+
+ public UserAccount(String username, String password) {
+ this.username = username;
+ this.password = password;
+ }
+
+ public String getUsername() {
+ return username;
+ }
+
+ public void setUsername(String username) {
+ this.username = username;
+ }
+
+ public String getPassword() {
+ return password;
+ }
+
+ public void setPassword(String password) {
+ this.password = password;
--- End diff --
In order to make it more safe\uff0cI think that we should encrypt the password .
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] eagle pull request #831: [EAGLE-918] Improve eagle auth to support @PermitAl...
Posted by haoch <gi...@git.apache.org>.
Github user haoch commented on a diff in the pull request:
https://github.com/apache/eagle/pull/831#discussion_r102385723
--- Diff: eagle-server/src/main/java/org/apache/eagle/server/authentication/config/UserAccount.java ---
@@ -0,0 +1,61 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ * <p>
+ * http://www.apache.org/licenses/LICENSE-2.0
+ * <p>
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.eagle.server.authentication.config;
+
+import org.apache.eagle.common.authentication.UserPrincipal;
+
+import java.util.List;
+
+public class UserAccount {
+ private String username;
+ private String password;
+ private List<UserPrincipal.Role> roles;
+
+ public UserAccount(String username, String password) {
+ this.username = username;
+ this.password = password;
+ }
+
+ public String getUsername() {
+ return username;
+ }
+
+ public void setUsername(String username) {
+ this.username = username;
+ }
+
+ public String getPassword() {
+ return password;
+ }
+
+ public void setPassword(String password) {
+ this.password = password;
--- End diff --
Good point.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] eagle issue #831: [EAGLE-918] Support auth annotations PermitAll/DenyAll/Rol...
Posted by haoch <gi...@git.apache.org>.
Github user haoch commented on the issue:
https://github.com/apache/eagle/pull/831
Building failure is caused by checkstyle problem, fixed in 43827444eb0e8fcd46ce6983bf456b920eb5b8b1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---