You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/10/09 09:39:48 UTC
[GitHub] [rocketmq-client-go] 0daypwn opened a new pull request, #928: [ISSUE #927] fix processQueue remove offset
0daypwn opened a new pull request, #928:
URL: https://github.com/apache/rocketmq-client-go/pull/928
## What is the purpose of the change
close #927
## Brief changelog
change putMessage order
1. put message to map
2. put message to channel
## Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`.
- [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when a cross-module dependency exists.
- [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-client-go] ShannonDing merged pull request #928: [ISSUE #927] fix processQueue remove offset
Posted by GitBox <gi...@apache.org>.
ShannonDing merged PR #928:
URL: https://github.com/apache/rocketmq-client-go/pull/928
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-client-go] codecov-commenter commented on pull request #928: [ISSUE #927] fix processQueue remove offset
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #928:
URL: https://github.com/apache/rocketmq-client-go/pull/928#issuecomment-1272502715
# [Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/928?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#928](https://codecov.io/gh/apache/rocketmq-client-go/pull/928?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1c4749e) into [master](https://codecov.io/gh/apache/rocketmq-client-go/commit/92515f7ee3fb9373481191c6cf4e9023cb221234?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (92515f7) will **not change** coverage.
> The diff coverage is `0.00%`.
```diff
@@ Coverage Diff @@
## master #928 +/- ##
=======================================
Coverage 23.61% 23.61%
=======================================
Files 52 52
Lines 7170 7170
=======================================
Hits 1693 1693
Misses 5247 5247
Partials 230 230
```
| [Impacted Files](https://codecov.io/gh/apache/rocketmq-client-go/pull/928?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [consumer/process\_queue.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/928/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uc3VtZXIvcHJvY2Vzc19xdWV1ZS5nbw==) | `0.00% <0.00%> (ø)` | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org