You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2020/07/23 03:55:39 UTC

[GitHub] [iceberg] JingsongLi opened a new issue #1231: Flink: Using RowData to avro reader and writer

JingsongLi opened a new issue #1231:
URL: https://github.com/apache/iceberg/issues/1231


   There was problems with the previous row conversion. For example, array type should be `T[]` instead `List`.
   According to discussion from https://github.com/apache/iceberg/issues/1215 , We can try to only work with `RowData`, and have conversions between `RowData` and `Row`.
   
   The works can be:
   - Abstract `AvroWithPartnerSchemaVisitor` to extract specific avro logical from `AvroSchemaWithTypeVisitor` and `AvroWithSparkSchemaVisitor`.
   - Extract `DecoderResolver` to provide cached `ResolvingDecoder` for resolving avro decoder.
   - Implements `FlinkValueReaders` and `FlinkValueWriters`.
   - Refactor `FlinkAvroReader` and `FlinkAvroWriter`.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


[GitHub] [iceberg] JingsongLi commented on issue #1231: Flink: Using RowData to avro reader and writer

Posted by GitBox <gi...@apache.org>.
JingsongLi commented on issue #1231:
URL: https://github.com/apache/iceberg/issues/1231#issuecomment-662811104


   CC: @rdblue @openinx @chenjunjiedada 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


[GitHub] [iceberg] rdblue commented on issue #1231: Flink: Using RowData to avro reader and writer

Posted by GitBox <gi...@apache.org>.
rdblue commented on issue #1231:
URL: https://github.com/apache/iceberg/issues/1231#issuecomment-663321543


   Thank you for the pull requests! I'll try to get them reviewed this weekend.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


[GitHub] [iceberg] rdblue edited a comment on issue #1231: Flink: Using RowData to avro reader and writer

Posted by GitBox <gi...@apache.org>.
rdblue edited a comment on issue #1231:
URL: https://github.com/apache/iceberg/issues/1231#issuecomment-663321543


   Thank you for the pull requests! I'll try to get them reviewed this weekend. Sorry that I'm running a bit behind with reviews right now.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


[GitHub] [iceberg] rdblue closed issue #1231: Flink: Using RowData to avro reader and writer

Posted by GitBox <gi...@apache.org>.
rdblue closed issue #1231:
URL: https://github.com/apache/iceberg/issues/1231


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org