You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tapestry.apache.org by "Robert Zeigler (JIRA)" <de...@tapestry.apache.org> on 2008/01/16 23:54:34 UTC
[jira] Created: (TAPESTRY-2054) page activation context with
spaces are incorrectly decoded when using forms
page activation context with spaces are incorrectly decoded when using forms
-----------------------------------------------------------------------------
Key: TAPESTRY-2054
URL: https://issues.apache.org/jira/browse/TAPESTRY-2054
Project: Tapestry
Issue Type: Bug
Affects Versions: 5.0.8
Environment: os x; java 1.5; Firefox 2.0
Reporter: Robert Zeigler
Page activation contexts are stored in form requests as hidden parameter values. However, when the value is retrieved on the server side, spaces aren't unescaped.
Hence, context values such as "foo bar" will wind up being passed into onActivate as "foo%20bar".
I will attach a sample project + test case which illustrates this issue.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org
[jira] Updated: (TAPESTRY-2054) page activation context with
spaces are incorrectly decoded when using forms
Posted by "Yoshikazu Kuramochi (JIRA)" <de...@tapestry.apache.org>.
[ https://issues.apache.org/jira/browse/TAPESTRY-2054?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Yoshikazu Kuramochi updated TAPESTRY-2054:
------------------------------------------
Attachment: page_context_in_form_test.patch
page_context_in_form_fix.patch
This is caused by my incomplete fix of TAPESTRY-1988.
When using form, page activation context needs only escaping percents and slashes in LinkFactoryImpl#addActivationContextToLink, not needs encoding.
[page_context_in_form_fix.patch]
* Add a argument 'forForm' to LinkFactoryImpl#addActivationContextToLink.
* In the method, use TapestryInternalUtils#escapePercentAndSlash when forForm is true,
otherwise use TapestryInternalUtils#encodeContext.
[page_context_in_form_test.patch]
* Test page: PageContextInForm.tml, PageContextInForm.java
* Test method: IntegrationTests#page_context_in_form
> page activation context with spaces are incorrectly decoded when using forms
> -----------------------------------------------------------------------------
>
> Key: TAPESTRY-2054
> URL: https://issues.apache.org/jira/browse/TAPESTRY-2054
> Project: Tapestry
> Issue Type: Bug
> Affects Versions: 5.0.8
> Environment: os x; java 1.5; Firefox 2.0
> Reporter: Robert Zeigler
> Attachments: contexttest.tgz, page_context_in_form_fix.patch, page_context_in_form_test.patch
>
>
> Page activation contexts are stored in form requests as hidden parameter values. However, when the value is retrieved on the server side, spaces aren't unescaped.
> Hence, context values such as "foo bar" will wind up being passed into onActivate as "foo%20bar".
> I will attach a sample project + test case which illustrates this issue.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org
[jira] Updated: (TAPESTRY-2054) page activation context with
spaces are incorrectly decoded when using forms
Posted by "Robert Zeigler (JIRA)" <de...@tapestry.apache.org>.
[ https://issues.apache.org/jira/browse/TAPESTRY-2054?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Zeigler updated TAPESTRY-2054:
-------------------------------------
Attachment: contexttest.tgz
maven project with a single (integration) test case that exposes the error.
> page activation context with spaces are incorrectly decoded when using forms
> -----------------------------------------------------------------------------
>
> Key: TAPESTRY-2054
> URL: https://issues.apache.org/jira/browse/TAPESTRY-2054
> Project: Tapestry
> Issue Type: Bug
> Affects Versions: 5.0.8
> Environment: os x; java 1.5; Firefox 2.0
> Reporter: Robert Zeigler
> Attachments: contexttest.tgz
>
>
> Page activation contexts are stored in form requests as hidden parameter values. However, when the value is retrieved on the server side, spaces aren't unescaped.
> Hence, context values such as "foo bar" will wind up being passed into onActivate as "foo%20bar".
> I will attach a sample project + test case which illustrates this issue.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org
[jira] Assigned: (TAPESTRY-2054) page activation context with
spaces are incorrectly decoded when using forms
Posted by "Howard M. Lewis Ship (JIRA)" <de...@tapestry.apache.org>.
[ https://issues.apache.org/jira/browse/TAPESTRY-2054?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Howard M. Lewis Ship reassigned TAPESTRY-2054:
----------------------------------------------
Assignee: Howard M. Lewis Ship
> page activation context with spaces are incorrectly decoded when using forms
> -----------------------------------------------------------------------------
>
> Key: TAPESTRY-2054
> URL: https://issues.apache.org/jira/browse/TAPESTRY-2054
> Project: Tapestry
> Issue Type: Bug
> Affects Versions: 5.0.8
> Environment: os x; java 1.5; Firefox 2.0
> Reporter: Robert Zeigler
> Assignee: Howard M. Lewis Ship
> Attachments: contexttest.tgz, page_context_in_form_fix.patch, page_context_in_form_test.patch
>
>
> Page activation contexts are stored in form requests as hidden parameter values. However, when the value is retrieved on the server side, spaces aren't unescaped.
> Hence, context values such as "foo bar" will wind up being passed into onActivate as "foo%20bar".
> I will attach a sample project + test case which illustrates this issue.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org
[jira] Closed: (TAPESTRY-2054) page activation context with spaces
are incorrectly decoded when using forms
Posted by "Howard M. Lewis Ship (JIRA)" <de...@tapestry.apache.org>.
[ https://issues.apache.org/jira/browse/TAPESTRY-2054?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Howard M. Lewis Ship closed TAPESTRY-2054.
------------------------------------------
Resolution: Fixed
Fix Version/s: 5.0.10
Thanks, nice patch!
> page activation context with spaces are incorrectly decoded when using forms
> -----------------------------------------------------------------------------
>
> Key: TAPESTRY-2054
> URL: https://issues.apache.org/jira/browse/TAPESTRY-2054
> Project: Tapestry
> Issue Type: Bug
> Affects Versions: 5.0.8
> Environment: os x; java 1.5; Firefox 2.0
> Reporter: Robert Zeigler
> Assignee: Howard M. Lewis Ship
> Fix For: 5.0.10
>
> Attachments: contexttest.tgz, page_context_in_form_fix.patch, page_context_in_form_test.patch
>
>
> Page activation contexts are stored in form requests as hidden parameter values. However, when the value is retrieved on the server side, spaces aren't unescaped.
> Hence, context values such as "foo bar" will wind up being passed into onActivate as "foo%20bar".
> I will attach a sample project + test case which illustrates this issue.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org