You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by QiangCai <gi...@git.apache.org> on 2017/12/05 07:39:26 UTC
[GitHub] carbondata pull request #1611: [CARBONDATA-1848] Carbondata streaming sink a...
GitHub user QiangCai opened a pull request:
https://github.com/apache/carbondata/pull/1611
[CARBONDATA-1848] Carbondata streaming sink adapt spark 2.2
Carbondata streaming sink adapt spark 2.2
- [x] Any interfaces changed?
no
- [x] Any backward compatibility impacted?
no
- [x] Document update required?
no
- [x] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests are required?
already have
- How it is tested? Please attach test report.
ci of spark 2.2
- Is it a performance related change? Please attach the performance test report.
no
- Any additional information to help reviewers in testing this change.
no
- [x] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
N/A
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/QiangCai/carbondata adapt_spark22
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/carbondata/pull/1611.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1611
----
commit 8209599bc8c5b95ab5e40b4b2e67297ef48104e1
Author: QiangCai <qi...@qq.com>
Date: 2017-12-05T07:31:05Z
streaming adapt spark 2.2
----
---
[GitHub] carbondata issue #1611: [CARBONDATA-1848] Carbondata streaming sink adapt sp...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1611
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2094/
---
[GitHub] carbondata pull request #1611: [CARBONDATA-1848] Carbondata streaming sink a...
Posted by QiangCai <gi...@git.apache.org>.
Github user QiangCai commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1611#discussion_r155136917
--- Diff: examples/spark2/src/main/scala/org/apache/carbondata/examples/StreamExample.scala ---
@@ -169,7 +168,7 @@ object StreamExample {
.format("carbondata")
.trigger(ProcessingTime("5 seconds"))
.option("checkpointLocation", tablePath.getStreamingCheckpointDir)
- .option("tablePath", tablePath.getPath)
+ .option("dbName", "default")
--- End diff --
if using default database, it can work. If not, it can't work
---
[GitHub] carbondata pull request #1611: [CARBONDATA-1848] Carbondata streaming sink a...
Posted by jackylk <gi...@git.apache.org>.
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1611#discussion_r154961448
--- Diff: streaming/src/main/scala/org/apache/spark/sql/execution/streaming/CarbonStreamingQueryListener.scala ---
@@ -33,7 +33,16 @@ class CarbonStreamingQueryListener(spark: SparkSession) extends StreamingQueryLi
private val cache = new util.HashMap[UUID, ICarbonLock]()
override def onQueryStarted(event: StreamingQueryListener.QueryStartedEvent): Unit = {
- val qry = spark.streams.get(event.id).asInstanceOf[StreamExecution]
+ val streamQuery = spark.streams.get(event.id)
+ val qry = if (streamQuery.isInstanceOf[StreamExecution]) {
--- End diff --
Isn't there an utility to check spark version?
---
[GitHub] carbondata issue #1611: [CARBONDATA-1848] Carbondata streaming sink adapt sp...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1611
Build Success with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/444/
---
[GitHub] carbondata issue #1611: [CARBONDATA-1848] Carbondata streaming sink adapt sp...
Posted by jackylk <gi...@git.apache.org>.
Github user jackylk commented on the issue:
https://github.com/apache/carbondata/pull/1611
LGTM
---
[GitHub] carbondata issue #1611: [CARBONDATA-1848] Carbondata streaming sink adapt sp...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1611
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1747/
---
[GitHub] carbondata issue #1611: [CARBONDATA-1848] Carbondata streaming sink adapt sp...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1611
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2131/
---
[GitHub] carbondata pull request #1611: [CARBONDATA-1848] Carbondata streaming sink a...
Posted by QiangCai <gi...@git.apache.org>.
Github user QiangCai commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1611#discussion_r155136943
--- Diff: streaming/src/main/scala/org/apache/spark/sql/execution/streaming/CarbonStreamingQueryListener.scala ---
@@ -33,7 +33,16 @@ class CarbonStreamingQueryListener(spark: SparkSession) extends StreamingQueryLi
private val cache = new util.HashMap[UUID, ICarbonLock]()
override def onQueryStarted(event: StreamingQueryListener.QueryStartedEvent): Unit = {
- val qry = spark.streams.get(event.id).asInstanceOf[StreamExecution]
+ val streamQuery = spark.streams.get(event.id)
+ val qry = if (streamQuery.isInstanceOf[StreamExecution]) {
--- End diff --
fixed
---
[GitHub] carbondata pull request #1611: [CARBONDATA-1848] Carbondata streaming sink a...
Posted by jackylk <gi...@git.apache.org>.
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1611#discussion_r154961220
--- Diff: examples/spark2/src/main/scala/org/apache/carbondata/examples/StreamExample.scala ---
@@ -169,7 +168,7 @@ object StreamExample {
.format("carbondata")
.trigger(ProcessingTime("5 seconds"))
.option("checkpointLocation", tablePath.getStreamingCheckpointDir)
- .option("tablePath", tablePath.getPath)
+ .option("dbName", "default")
--- End diff --
It can't work if `dbName` is not specified?
---
[GitHub] carbondata issue #1611: [CARBONDATA-1848] Carbondata streaming sink adapt sp...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1611
Build Success with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/483/
---
[GitHub] carbondata pull request #1611: [CARBONDATA-1848] Carbondata streaming sink a...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/carbondata/pull/1611
---
[GitHub] carbondata issue #1611: [CARBONDATA-1848] Carbondata streaming sink adapt sp...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1611
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1713/
---