You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by James Peach <jp...@apache.org> on 2016/01/12 23:50:37 UTC
Re: Review Request 40553: Enable mesos tests installation
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40553/
-----------------------------------------------------------
(Updated Jan. 12, 2016, 10:50 p.m.)
Review request for mesos, Benjamin Bannier and Till Toenshoff.
Changes
-------
Rebase onto master, fixing new test module additions.
Bugs: MESOS-3608
https://issues.apache.org/jira/browse/MESOS-3608
Repository: mesos
Description
-------
This patch enables the installation mesos-tests and its dependencies
and helper tool. The goal is to allow operators to build a separate
test package that can be run at deployment time to verify that Mesos
works in the deployment environment.
Since the build directory is searched first, to run it on a host
that has a build tree, you need to specify a non-existent tree:
~ $ $PREFIX/libexec/mesos/tests/mesos-tests --build_dir=/none
- Add --enable-tests-install
- Fix mesos-tests gmock dependencies
- Optionally install tests, helpers and test modules
- Add utility helpers to find various test resources
Current test status:
[==========] 784 tests from 106 test cases ran. (135304 ms total)
[ PASSED ] 780 tests.
[ FAILED ] 4 tests, listed below:
[ FAILED ] ExamplesTest.TestFramework
[ FAILED ] ExamplesTest.NoExecutorFramework
[ FAILED ] ExamplesTest.EventCallFramework
[ FAILED ] ExamplesTest.PersistentVolumeFramework
Diffs (updated)
-----
configure.ac 40d60a63cdba41d06305f09141f4d14d6e229d95
src/Makefile.am 8cbfb1ba5fa49f2d3cc26ea325838a1c68a79660
src/tests/containerizer/launch_tests.cpp c7ebe2606e4ff99ced90342dd16e0b4bf02bc504
src/tests/containerizer/memory_test_helper.cpp 4a3de2e3c887aa6afc604588850e1386f92d8c11
src/tests/containerizer/mesos_containerizer_tests.cpp 95b493c6f479eef52ee0c9a44ac40254ed76ebae
src/tests/containerizer/ns_tests.cpp 603e54b7303c5aa15e2c5715dc7a2f7e7d39541b
src/tests/containerizer/port_mapping_tests.cpp e3aea53468fa00374320a8b89bdbb64f38e44b01
src/tests/environment.cpp 20218a086baefcefb310eb45ed9024e5425ce787
src/tests/fetcher_tests.cpp 1831d896ca8a52bec4adf87a67b6af845079796c
src/tests/health_check_tests.cpp 26d05e7f7db9306c8b9164e2e7f843793c909e67
src/tests/mesos.cpp 365ebe8335c37bfdb983a5424d4c995fa9b76a22
src/tests/module.cpp f0e64f7c462cf833839558665fdb60d9f2cbc475
src/tests/module_tests.cpp a3271a3267647e0964dd3decb3ca8384417dd559
src/tests/oversubscription_tests.cpp 7a75fb38e0177e33cf0e7cb82b4b9ebf8f05fe0a
src/tests/script.cpp ee44fef29fb40e414d7507168091ee5cd0d15736
src/tests/slave_tests.cpp e4fb490a1d877547fe883c22dbc47bb4969ecef6
src/tests/utils.hpp a6cca472f4dfab12cd6eccab6972206d842177aa
src/tests/utils.cpp 877139e97249761658dce3b1058cdc2e2a52367b
Diff: https://reviews.apache.org/r/40553/diff/
Testing
-------
Thanks,
James Peach
Re: Review Request 40553: Enable mesos tests installation
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40553/#review114144
-----------------------------------------------------------
Bad patch!
Reviews applied: [39780, 39781, 39782, 40553]
Failed command: ./support/apply-review.sh -n -r 40553
Error:
2016-01-13 04:01:31 URL:https://reviews.apache.org/r/40553/diff/raw/ [39100/39100] -> "40553.patch" [1]
Total errors found: 0
Checking 16 files
Error: Commit message summary (the first line) must end in a period.
- Mesos ReviewBot
On Jan. 12, 2016, 10:50 p.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40553/
> -----------------------------------------------------------
>
> (Updated Jan. 12, 2016, 10:50 p.m.)
>
>
> Review request for mesos, Benjamin Bannier and Till Toenshoff.
>
>
> Bugs: MESOS-3608
> https://issues.apache.org/jira/browse/MESOS-3608
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch enables the installation mesos-tests and its dependencies
> and helper tool. The goal is to allow operators to build a separate
> test package that can be run at deployment time to verify that Mesos
> works in the deployment environment.
>
> Since the build directory is searched first, to run it on a host
> that has a build tree, you need to specify a non-existent tree:
>
> ~ $ $PREFIX/libexec/mesos/tests/mesos-tests --build_dir=/none
>
> - Add --enable-tests-install
> - Fix mesos-tests gmock dependencies
> - Optionally install tests, helpers and test modules
> - Add utility helpers to find various test resources
>
> Current test status:
>
> [==========] 784 tests from 106 test cases ran. (135304 ms total)
> [ PASSED ] 780 tests.
> [ FAILED ] 4 tests, listed below:
> [ FAILED ] ExamplesTest.TestFramework
> [ FAILED ] ExamplesTest.NoExecutorFramework
> [ FAILED ] ExamplesTest.EventCallFramework
> [ FAILED ] ExamplesTest.PersistentVolumeFramework
>
>
> Diffs
> -----
>
> configure.ac 40d60a63cdba41d06305f09141f4d14d6e229d95
> src/Makefile.am 8cbfb1ba5fa49f2d3cc26ea325838a1c68a79660
> src/tests/containerizer/launch_tests.cpp c7ebe2606e4ff99ced90342dd16e0b4bf02bc504
> src/tests/containerizer/memory_test_helper.cpp 4a3de2e3c887aa6afc604588850e1386f92d8c11
> src/tests/containerizer/mesos_containerizer_tests.cpp 95b493c6f479eef52ee0c9a44ac40254ed76ebae
> src/tests/containerizer/ns_tests.cpp 603e54b7303c5aa15e2c5715dc7a2f7e7d39541b
> src/tests/containerizer/port_mapping_tests.cpp e3aea53468fa00374320a8b89bdbb64f38e44b01
> src/tests/environment.cpp 20218a086baefcefb310eb45ed9024e5425ce787
> src/tests/fetcher_tests.cpp 1831d896ca8a52bec4adf87a67b6af845079796c
> src/tests/health_check_tests.cpp 26d05e7f7db9306c8b9164e2e7f843793c909e67
> src/tests/mesos.cpp 365ebe8335c37bfdb983a5424d4c995fa9b76a22
> src/tests/module.cpp f0e64f7c462cf833839558665fdb60d9f2cbc475
> src/tests/module_tests.cpp a3271a3267647e0964dd3decb3ca8384417dd559
> src/tests/oversubscription_tests.cpp 7a75fb38e0177e33cf0e7cb82b4b9ebf8f05fe0a
> src/tests/script.cpp ee44fef29fb40e414d7507168091ee5cd0d15736
> src/tests/slave_tests.cpp e4fb490a1d877547fe883c22dbc47bb4969ecef6
> src/tests/utils.hpp a6cca472f4dfab12cd6eccab6972206d842177aa
> src/tests/utils.cpp 877139e97249761658dce3b1058cdc2e2a52367b
>
> Diff: https://reviews.apache.org/r/40553/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> James Peach
>
>
Re: Review Request 40553: Enable mesos tests installation
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40553/#review114851
-----------------------------------------------------------
Bad patch!
Reviews applied: [39780, 39781, 39782, 40553]
Failed command: ./support/apply-review.sh -n -r 40553
Error:
2016-01-16 08:40:21 URL:https://reviews.apache.org/r/40553/diff/raw/ [46635/46635] -> "40553.patch" [1]
Total errors found: 0
Checking 16 files
Error: Commit message summary (the first line) must end in a period.
- Mesos ReviewBot
On Jan. 16, 2016, 5:53 a.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40553/
> -----------------------------------------------------------
>
> (Updated Jan. 16, 2016, 5:53 a.m.)
>
>
> Review request for mesos, Benjamin Bannier and Till Toenshoff.
>
>
> Bugs: MESOS-3608
> https://issues.apache.org/jira/browse/MESOS-3608
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch enables the installation mesos-tests and its dependencies
> and helper tool. The goal is to allow operators to build a separate
> test package that can be run at deployment time to verify that Mesos
> works in the deployment environment.
>
> Since the build directory is searched first, to run it on a host
> that has a build tree, you need to specify a non-existent tree:
>
> ~ $ $PREFIX/libexec/mesos/tests/mesos-tests --build_dir=/none
>
> - Add --enable-tests-install
> - Fix mesos-tests gmock dependencies
> - Optionally install tests, helpers and test modules
> - Add utility helpers to find various test resources
>
>
> Diffs
> -----
>
> Makefile.am fbd4e5a6356e90c867ba47c48c86fc9161ddd98e
> configure.ac 40d60a63cdba41d06305f09141f4d14d6e229d95
> src/Makefile.am d23e35001078a86775bd9b76baa207ecb9dab7e1
> src/tests/balloon_framework_test.sh 25a19cfde87a3fd2d7d3e780700d342d08bd0a91
> src/tests/containerizer/launch_tests.cpp c7ebe2606e4ff99ced90342dd16e0b4bf02bc504
> src/tests/containerizer/memory_test_helper.cpp 4a3de2e3c887aa6afc604588850e1386f92d8c11
> src/tests/containerizer/mesos_containerizer_tests.cpp 677fcc1c654f83ad3e60e0f6172a1a1e4a1045b1
> src/tests/containerizer/ns_tests.cpp 603e54b7303c5aa15e2c5715dc7a2f7e7d39541b
> src/tests/containerizer/port_mapping_tests.cpp fab16f697f90abc11d681222f10f518d70da908b
> src/tests/environment.cpp 20218a086baefcefb310eb45ed9024e5425ce787
> src/tests/event_call_framework_test.sh 9d1211552734afbf15b376f8c4629bae8a2065af
> src/tests/fetcher_tests.cpp 1831d896ca8a52bec4adf87a67b6af845079796c
> src/tests/health_check_tests.cpp 3606ce46bfa283ad0d5239fc25e02c5a9f8d1a53
> src/tests/mesos.cpp 365ebe8335c37bfdb983a5424d4c995fa9b76a22
> src/tests/module.cpp f0e64f7c462cf833839558665fdb60d9f2cbc475
> src/tests/module_tests.cpp a3271a3267647e0964dd3decb3ca8384417dd559
> src/tests/no_executor_framework_test.sh aebdc8c380abb2d041d6fc74dfac5a111c15267e
> src/tests/oversubscription_tests.cpp 7a75fb38e0177e33cf0e7cb82b4b9ebf8f05fe0a
> src/tests/persistent_volume_framework_test.sh 84f02847a8d89400512d8a5714d33fb29cf5b03a
> src/tests/script.cpp ee44fef29fb40e414d7507168091ee5cd0d15736
> src/tests/slave_tests.cpp 076660daf025d6fd5065cd0c1930f17ecc5ca5aa
> src/tests/test_framework_test.sh 409e80994f63448115ea8ac34b4fd5c6cf88aa22
> src/tests/utils.hpp a6cca472f4dfab12cd6eccab6972206d842177aa
> src/tests/utils.cpp 22bf3a85da5261fcfcc8b6aa9626aacdc8391ad4
>
> Diff: https://reviews.apache.org/r/40553/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> James Peach
>
>
Re: Review Request 40553: Enable mesos tests installation.
Posted by Benjamin Bannier <be...@mesosphere.io>.
> On Jan. 27, 2016, 8:44 p.m., Benjamin Bannier wrote:
> > Looks mostly good to me. A few things were unclear to me:
> >
> > * Would it make sense to add an `installcheck` target? My expectation for that would be for it to invoke the installed tests and adding the (in)correct `builddir` magic to make sure only stuff from `$PREFIX` is used.
> > * Why don't we install stout or libprocess tests? I would have thought that especially the libprocess tests could be useful to diagnose low-level incompatibilites.
>
> James Peach wrote:
> I added an ``installcheck`` target.
>
> I didn't try to deal with stout or libprocess at the same time as this. Maybe it makes sense to also install them, but the Mesos suite is going to give the most benefit. If we want to go down that path, I'd like to do that as separate Jira tickets.
Nice. I've filed MESOS-4538 to activate `--enable-tests-install` for CI distcheck so these tests don't rot away. I've also filed MESOS-4537 for installing stout and libprocess tests.
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40553/#review116610
-----------------------------------------------------------
On Jan. 27, 2016, 10:03 p.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40553/
> -----------------------------------------------------------
>
> (Updated Jan. 27, 2016, 10:03 p.m.)
>
>
> Review request for mesos, Benjamin Bannier and Till Toenshoff.
>
>
> Bugs: MESOS-3608
> https://issues.apache.org/jira/browse/MESOS-3608
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch enables the installation mesos-tests and its dependencies
> and helper tool. The goal is to allow operators to build a separate
> test package that can be run at deployment time to verify that Mesos
> works in the deployment environment.
>
> Since the build directory is searched first, to run it on a host
> that has a build tree, you need to specify a non-existent tree:
>
> ~ $ $PREFIX/libexec/mesos/tests/mesos-tests --build_dir=/none
>
> - Add --enable-tests-install
> - Fix mesos-tests gmock dependencies
> - Optionally install tests, helpers and test modules
> - Add utility helpers to find various test resources
>
>
> Diffs
> -----
>
> Makefile.am fbd4e5a6356e90c867ba47c48c86fc9161ddd98e
> configure.ac 70d16871d5888ac1d9d5fb0ba0b453799b00f320
> src/Makefile.am 8657a869f931aa7482fbb09f2c6df95b6a8c50c6
> src/examples/test_framework.cpp ff7b00543eea1a7cbf52c7abfba81600868bfbab
> src/tests/balloon_framework_test.sh 25a19cfde87a3fd2d7d3e780700d342d08bd0a91
> src/tests/containerizer/launch_tests.cpp c7ebe2606e4ff99ced90342dd16e0b4bf02bc504
> src/tests/containerizer/memory_test_helper.cpp 4a3de2e3c887aa6afc604588850e1386f92d8c11
> src/tests/containerizer/mesos_containerizer_tests.cpp a45ed1b2175b7dc16d621a44fbccfb8f957ae2b5
> src/tests/containerizer/ns_tests.cpp 603e54b7303c5aa15e2c5715dc7a2f7e7d39541b
> src/tests/containerizer/port_mapping_tests.cpp 182fe9217a5da9af603d6f9c203a1689eff4ca1b
> src/tests/environment.cpp e112270b68d402bb9b01445af552500fb3929e52
> src/tests/event_call_framework_test.sh 9d1211552734afbf15b376f8c4629bae8a2065af
> src/tests/fetcher_tests.cpp 1831d896ca8a52bec4adf87a67b6af845079796c
> src/tests/health_check_tests.cpp 65e8fe25ed7feb1080ad833ba98e6b462bd3152c
> src/tests/mesos.cpp 18d0d8f8037ebc27c87bcb0f1ce9f143e7505ec8
> src/tests/module.cpp 246f3a402d4fe3b273c459f6e02c009f3de65f3e
> src/tests/module_tests.cpp a3271a3267647e0964dd3decb3ca8384417dd559
> src/tests/no_executor_framework_test.sh aebdc8c380abb2d041d6fc74dfac5a111c15267e
> src/tests/oversubscription_tests.cpp 6f43103e81303015fb614653e3bfece55009d1bf
> src/tests/persistent_volume_framework_test.sh 84f02847a8d89400512d8a5714d33fb29cf5b03a
> src/tests/script.cpp ee44fef29fb40e414d7507168091ee5cd0d15736
> src/tests/slave_tests.cpp e943ab99baf3d74679a5da888889a89f6a4b7ead
> src/tests/test_framework_test.sh 409e80994f63448115ea8ac34b4fd5c6cf88aa22
> src/tests/utils.hpp a6cca472f4dfab12cd6eccab6972206d842177aa
> src/tests/utils.cpp 22bf3a85da5261fcfcc8b6aa9626aacdc8391ad4
>
> Diff: https://reviews.apache.org/r/40553/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> James Peach
>
>
Re: Review Request 40553: Enable mesos tests installation.
Posted by James Peach <jp...@apache.org>.
> On Jan. 27, 2016, 7:44 p.m., Benjamin Bannier wrote:
> > Looks mostly good to me. A few things were unclear to me:
> >
> > * Would it make sense to add an `installcheck` target? My expectation for that would be for it to invoke the installed tests and adding the (in)correct `builddir` magic to make sure only stuff from `$PREFIX` is used.
> > * Why don't we install stout or libprocess tests? I would have thought that especially the libprocess tests could be useful to diagnose low-level incompatibilites.
I added an ``installcheck`` target.
I didn't try to deal with stout or libprocess at the same time as this. Maybe it makes sense to also install them, but the Mesos suite is going to give the most benefit. If we want to go down that path, I'd like to do that as separate Jira tickets.
- James
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40553/#review116610
-----------------------------------------------------------
On Jan. 27, 2016, 5:54 p.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40553/
> -----------------------------------------------------------
>
> (Updated Jan. 27, 2016, 5:54 p.m.)
>
>
> Review request for mesos, Benjamin Bannier and Till Toenshoff.
>
>
> Bugs: MESOS-3608
> https://issues.apache.org/jira/browse/MESOS-3608
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch enables the installation mesos-tests and its dependencies
> and helper tool. The goal is to allow operators to build a separate
> test package that can be run at deployment time to verify that Mesos
> works in the deployment environment.
>
> Since the build directory is searched first, to run it on a host
> that has a build tree, you need to specify a non-existent tree:
>
> ~ $ $PREFIX/libexec/mesos/tests/mesos-tests --build_dir=/none
>
> - Add --enable-tests-install
> - Fix mesos-tests gmock dependencies
> - Optionally install tests, helpers and test modules
> - Add utility helpers to find various test resources
>
>
> Diffs
> -----
>
> Makefile.am fbd4e5a6356e90c867ba47c48c86fc9161ddd98e
> configure.ac 70d16871d5888ac1d9d5fb0ba0b453799b00f320
> src/Makefile.am 8657a869f931aa7482fbb09f2c6df95b6a8c50c6
> src/examples/test_framework.cpp ff7b00543eea1a7cbf52c7abfba81600868bfbab
> src/tests/balloon_framework_test.sh 25a19cfde87a3fd2d7d3e780700d342d08bd0a91
> src/tests/containerizer/launch_tests.cpp c7ebe2606e4ff99ced90342dd16e0b4bf02bc504
> src/tests/containerizer/memory_test_helper.cpp 4a3de2e3c887aa6afc604588850e1386f92d8c11
> src/tests/containerizer/mesos_containerizer_tests.cpp a45ed1b2175b7dc16d621a44fbccfb8f957ae2b5
> src/tests/containerizer/ns_tests.cpp 603e54b7303c5aa15e2c5715dc7a2f7e7d39541b
> src/tests/containerizer/port_mapping_tests.cpp 182fe9217a5da9af603d6f9c203a1689eff4ca1b
> src/tests/environment.cpp e112270b68d402bb9b01445af552500fb3929e52
> src/tests/event_call_framework_test.sh 9d1211552734afbf15b376f8c4629bae8a2065af
> src/tests/fetcher_tests.cpp 1831d896ca8a52bec4adf87a67b6af845079796c
> src/tests/health_check_tests.cpp 65e8fe25ed7feb1080ad833ba98e6b462bd3152c
> src/tests/mesos.cpp 18d0d8f8037ebc27c87bcb0f1ce9f143e7505ec8
> src/tests/module.cpp 246f3a402d4fe3b273c459f6e02c009f3de65f3e
> src/tests/module_tests.cpp a3271a3267647e0964dd3decb3ca8384417dd559
> src/tests/no_executor_framework_test.sh aebdc8c380abb2d041d6fc74dfac5a111c15267e
> src/tests/oversubscription_tests.cpp 6f43103e81303015fb614653e3bfece55009d1bf
> src/tests/persistent_volume_framework_test.sh 84f02847a8d89400512d8a5714d33fb29cf5b03a
> src/tests/script.cpp ee44fef29fb40e414d7507168091ee5cd0d15736
> src/tests/slave_tests.cpp e943ab99baf3d74679a5da888889a89f6a4b7ead
> src/tests/test_framework_test.sh 409e80994f63448115ea8ac34b4fd5c6cf88aa22
> src/tests/utils.hpp a6cca472f4dfab12cd6eccab6972206d842177aa
> src/tests/utils.cpp 22bf3a85da5261fcfcc8b6aa9626aacdc8391ad4
>
> Diff: https://reviews.apache.org/r/40553/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> James Peach
>
>
Re: Review Request 40553: Enable mesos tests installation.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40553/#review116610
-----------------------------------------------------------
Looks mostly good to me. A few things were unclear to me:
* Would it make sense to add an `installcheck` target? My expectation for that would be for it to invoke the installed tests and adding the (in)correct `builddir` magic to make sure only stuff from `$PREFIX` is used.
* Why don't we install stout or libprocess tests? I would have thought that especially the libprocess tests could be useful to diagnose low-level incompatibilites.
src/Makefile.am (lines 1684 - 1688)
<https://reviews.apache.org/r/40553/#comment177688>
Does the reasoning here need an update?
src/Makefile.am (lines 1693 - 1694)
<https://reviews.apache.org/r/40553/#comment177685>
nit-pick: remove spaces before tabs here.
src/Makefile.am (line 1719)
<https://reviews.apache.org/r/40553/#comment177687>
This seems to be fixed now, right? If yes, probably a good idea to revisit (and close?) MESOS-1940.
src/Makefile.am (line 1962)
<https://reviews.apache.org/r/40553/#comment177686>
nit-pick: remove space before tabs here.
- Benjamin Bannier
On Jan. 27, 2016, 6:54 p.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40553/
> -----------------------------------------------------------
>
> (Updated Jan. 27, 2016, 6:54 p.m.)
>
>
> Review request for mesos, Benjamin Bannier and Till Toenshoff.
>
>
> Bugs: MESOS-3608
> https://issues.apache.org/jira/browse/MESOS-3608
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch enables the installation mesos-tests and its dependencies
> and helper tool. The goal is to allow operators to build a separate
> test package that can be run at deployment time to verify that Mesos
> works in the deployment environment.
>
> Since the build directory is searched first, to run it on a host
> that has a build tree, you need to specify a non-existent tree:
>
> ~ $ $PREFIX/libexec/mesos/tests/mesos-tests --build_dir=/none
>
> - Add --enable-tests-install
> - Fix mesos-tests gmock dependencies
> - Optionally install tests, helpers and test modules
> - Add utility helpers to find various test resources
>
>
> Diffs
> -----
>
> Makefile.am fbd4e5a6356e90c867ba47c48c86fc9161ddd98e
> configure.ac 70d16871d5888ac1d9d5fb0ba0b453799b00f320
> src/Makefile.am 8657a869f931aa7482fbb09f2c6df95b6a8c50c6
> src/examples/test_framework.cpp ff7b00543eea1a7cbf52c7abfba81600868bfbab
> src/tests/balloon_framework_test.sh 25a19cfde87a3fd2d7d3e780700d342d08bd0a91
> src/tests/containerizer/launch_tests.cpp c7ebe2606e4ff99ced90342dd16e0b4bf02bc504
> src/tests/containerizer/memory_test_helper.cpp 4a3de2e3c887aa6afc604588850e1386f92d8c11
> src/tests/containerizer/mesos_containerizer_tests.cpp a45ed1b2175b7dc16d621a44fbccfb8f957ae2b5
> src/tests/containerizer/ns_tests.cpp 603e54b7303c5aa15e2c5715dc7a2f7e7d39541b
> src/tests/containerizer/port_mapping_tests.cpp 182fe9217a5da9af603d6f9c203a1689eff4ca1b
> src/tests/environment.cpp e112270b68d402bb9b01445af552500fb3929e52
> src/tests/event_call_framework_test.sh 9d1211552734afbf15b376f8c4629bae8a2065af
> src/tests/fetcher_tests.cpp 1831d896ca8a52bec4adf87a67b6af845079796c
> src/tests/health_check_tests.cpp 65e8fe25ed7feb1080ad833ba98e6b462bd3152c
> src/tests/mesos.cpp 18d0d8f8037ebc27c87bcb0f1ce9f143e7505ec8
> src/tests/module.cpp 246f3a402d4fe3b273c459f6e02c009f3de65f3e
> src/tests/module_tests.cpp a3271a3267647e0964dd3decb3ca8384417dd559
> src/tests/no_executor_framework_test.sh aebdc8c380abb2d041d6fc74dfac5a111c15267e
> src/tests/oversubscription_tests.cpp 6f43103e81303015fb614653e3bfece55009d1bf
> src/tests/persistent_volume_framework_test.sh 84f02847a8d89400512d8a5714d33fb29cf5b03a
> src/tests/script.cpp ee44fef29fb40e414d7507168091ee5cd0d15736
> src/tests/slave_tests.cpp e943ab99baf3d74679a5da888889a89f6a4b7ead
> src/tests/test_framework_test.sh 409e80994f63448115ea8ac34b4fd5c6cf88aa22
> src/tests/utils.hpp a6cca472f4dfab12cd6eccab6972206d842177aa
> src/tests/utils.cpp 22bf3a85da5261fcfcc8b6aa9626aacdc8391ad4
>
> Diff: https://reviews.apache.org/r/40553/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> James Peach
>
>
Re: Review Request 40553: Enable mesos tests installation.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40553/#review116652
-----------------------------------------------------------
Fix it, then Ship it!
src/Makefile.am (line 1999)
<https://reviews.apache.org/r/40553/#comment177751>
Sorry for being unclear, of course `s/installcheck/installcheck-local`.
- Benjamin Bannier
On Jan. 27, 2016, 10:03 p.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40553/
> -----------------------------------------------------------
>
> (Updated Jan. 27, 2016, 10:03 p.m.)
>
>
> Review request for mesos, Benjamin Bannier and Till Toenshoff.
>
>
> Bugs: MESOS-3608
> https://issues.apache.org/jira/browse/MESOS-3608
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch enables the installation mesos-tests and its dependencies
> and helper tool. The goal is to allow operators to build a separate
> test package that can be run at deployment time to verify that Mesos
> works in the deployment environment.
>
> Since the build directory is searched first, to run it on a host
> that has a build tree, you need to specify a non-existent tree:
>
> ~ $ $PREFIX/libexec/mesos/tests/mesos-tests --build_dir=/none
>
> - Add --enable-tests-install
> - Fix mesos-tests gmock dependencies
> - Optionally install tests, helpers and test modules
> - Add utility helpers to find various test resources
>
>
> Diffs
> -----
>
> Makefile.am fbd4e5a6356e90c867ba47c48c86fc9161ddd98e
> configure.ac 70d16871d5888ac1d9d5fb0ba0b453799b00f320
> src/Makefile.am 8657a869f931aa7482fbb09f2c6df95b6a8c50c6
> src/examples/test_framework.cpp ff7b00543eea1a7cbf52c7abfba81600868bfbab
> src/tests/balloon_framework_test.sh 25a19cfde87a3fd2d7d3e780700d342d08bd0a91
> src/tests/containerizer/launch_tests.cpp c7ebe2606e4ff99ced90342dd16e0b4bf02bc504
> src/tests/containerizer/memory_test_helper.cpp 4a3de2e3c887aa6afc604588850e1386f92d8c11
> src/tests/containerizer/mesos_containerizer_tests.cpp a45ed1b2175b7dc16d621a44fbccfb8f957ae2b5
> src/tests/containerizer/ns_tests.cpp 603e54b7303c5aa15e2c5715dc7a2f7e7d39541b
> src/tests/containerizer/port_mapping_tests.cpp 182fe9217a5da9af603d6f9c203a1689eff4ca1b
> src/tests/environment.cpp e112270b68d402bb9b01445af552500fb3929e52
> src/tests/event_call_framework_test.sh 9d1211552734afbf15b376f8c4629bae8a2065af
> src/tests/fetcher_tests.cpp 1831d896ca8a52bec4adf87a67b6af845079796c
> src/tests/health_check_tests.cpp 65e8fe25ed7feb1080ad833ba98e6b462bd3152c
> src/tests/mesos.cpp 18d0d8f8037ebc27c87bcb0f1ce9f143e7505ec8
> src/tests/module.cpp 246f3a402d4fe3b273c459f6e02c009f3de65f3e
> src/tests/module_tests.cpp a3271a3267647e0964dd3decb3ca8384417dd559
> src/tests/no_executor_framework_test.sh aebdc8c380abb2d041d6fc74dfac5a111c15267e
> src/tests/oversubscription_tests.cpp 6f43103e81303015fb614653e3bfece55009d1bf
> src/tests/persistent_volume_framework_test.sh 84f02847a8d89400512d8a5714d33fb29cf5b03a
> src/tests/script.cpp ee44fef29fb40e414d7507168091ee5cd0d15736
> src/tests/slave_tests.cpp e943ab99baf3d74679a5da888889a89f6a4b7ead
> src/tests/test_framework_test.sh 409e80994f63448115ea8ac34b4fd5c6cf88aa22
> src/tests/utils.hpp a6cca472f4dfab12cd6eccab6972206d842177aa
> src/tests/utils.cpp 22bf3a85da5261fcfcc8b6aa9626aacdc8391ad4
>
> Diff: https://reviews.apache.org/r/40553/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> James Peach
>
>
Re: Review Request 40553: Enable mesos tests installation.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40553/#review116714
-----------------------------------------------------------
Patch looks great!
Reviews applied: [39780, 39781, 39782, 40553]
Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh
- Mesos ReviewBot
On Jan. 28, 2016, 12:49 a.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40553/
> -----------------------------------------------------------
>
> (Updated Jan. 28, 2016, 12:49 a.m.)
>
>
> Review request for mesos, Benjamin Bannier and Till Toenshoff.
>
>
> Bugs: MESOS-3608
> https://issues.apache.org/jira/browse/MESOS-3608
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch enables the installation mesos-tests and its dependencies
> and helper tool. The goal is to allow operators to build a separate
> test package that can be run at deployment time to verify that Mesos
> works in the deployment environment.
>
> Since the build directory is searched first, to run it on a host
> that has a build tree, you need to specify a non-existent tree:
>
> ~ $ $PREFIX/libexec/mesos/tests/mesos-tests --build_dir=/none
>
> - Add --enable-tests-install
> - Fix mesos-tests gmock dependencies
> - Optionally install tests, helpers and test modules
> - Add utility helpers to find various test resources
>
>
> Diffs
> -----
>
> Makefile.am fbd4e5a6356e90c867ba47c48c86fc9161ddd98e
> configure.ac 70d16871d5888ac1d9d5fb0ba0b453799b00f320
> src/Makefile.am 8657a869f931aa7482fbb09f2c6df95b6a8c50c6
> src/examples/test_framework.cpp ff7b00543eea1a7cbf52c7abfba81600868bfbab
> src/tests/balloon_framework_test.sh 25a19cfde87a3fd2d7d3e780700d342d08bd0a91
> src/tests/containerizer/launch_tests.cpp c7ebe2606e4ff99ced90342dd16e0b4bf02bc504
> src/tests/containerizer/memory_test_helper.cpp 4a3de2e3c887aa6afc604588850e1386f92d8c11
> src/tests/containerizer/mesos_containerizer_tests.cpp a45ed1b2175b7dc16d621a44fbccfb8f957ae2b5
> src/tests/containerizer/ns_tests.cpp 603e54b7303c5aa15e2c5715dc7a2f7e7d39541b
> src/tests/containerizer/port_mapping_tests.cpp 182fe9217a5da9af603d6f9c203a1689eff4ca1b
> src/tests/environment.cpp e112270b68d402bb9b01445af552500fb3929e52
> src/tests/event_call_framework_test.sh 9d1211552734afbf15b376f8c4629bae8a2065af
> src/tests/fetcher_tests.cpp 1831d896ca8a52bec4adf87a67b6af845079796c
> src/tests/health_check_tests.cpp 65e8fe25ed7feb1080ad833ba98e6b462bd3152c
> src/tests/mesos.cpp 18d0d8f8037ebc27c87bcb0f1ce9f143e7505ec8
> src/tests/module.cpp 246f3a402d4fe3b273c459f6e02c009f3de65f3e
> src/tests/module_tests.cpp a3271a3267647e0964dd3decb3ca8384417dd559
> src/tests/no_executor_framework_test.sh aebdc8c380abb2d041d6fc74dfac5a111c15267e
> src/tests/oversubscription_tests.cpp 6f43103e81303015fb614653e3bfece55009d1bf
> src/tests/persistent_volume_framework_test.sh 84f02847a8d89400512d8a5714d33fb29cf5b03a
> src/tests/script.cpp ee44fef29fb40e414d7507168091ee5cd0d15736
> src/tests/slave_tests.cpp e943ab99baf3d74679a5da888889a89f6a4b7ead
> src/tests/test_framework_test.sh 409e80994f63448115ea8ac34b4fd5c6cf88aa22
> src/tests/utils.hpp a6cca472f4dfab12cd6eccab6972206d842177aa
> src/tests/utils.cpp 22bf3a85da5261fcfcc8b6aa9626aacdc8391ad4
>
> Diff: https://reviews.apache.org/r/40553/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> James Peach
>
>
Re: Review Request 40553: Enable mesos tests installation.
Posted by Till Toenshoff <to...@me.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40553/#review118249
-----------------------------------------------------------
src/tests/script.cpp (line 112)
<https://reviews.apache.org/r/40553/#comment179475>
Whoops, this one was not supposed to get removed.
- Till Toenshoff
On Feb. 4, 2016, 6:14 p.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40553/
> -----------------------------------------------------------
>
> (Updated Feb. 4, 2016, 6:14 p.m.)
>
>
> Review request for mesos, Benjamin Bannier and Till Toenshoff.
>
>
> Bugs: MESOS-3608
> https://issues.apache.org/jira/browse/MESOS-3608
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch enables the installation mesos-tests and its dependencies
> and helper tool. The goal is to allow operators to build a separate
> test package that can be run at deployment time to verify that Mesos
> works in the deployment environment.
>
> Since the build directory is searched first, to run it on a host
> that has a build tree, you need to specify a non-existent tree:
>
> ~ $ $PREFIX/libexec/mesos/tests/mesos-tests --build_dir=/none
>
> - Add --enable-tests-install
> - Fix mesos-tests gmock dependencies
> - Optionally install tests, helpers and test modules
> - Add utility helpers to find various test resources
>
>
> Diffs
> -----
>
> Makefile.am fbd4e5a6356e90c867ba47c48c86fc9161ddd98e
> configure.ac cb39c7f7681eb7f5e3c379dc9a096eca1ffcca93
> src/Makefile.am a851862a476f8fec03e90d37ec5741f080c047e7
> src/examples/test_framework.cpp ff7b00543eea1a7cbf52c7abfba81600868bfbab
> src/tests/balloon_framework_test.sh 25a19cfde87a3fd2d7d3e780700d342d08bd0a91
> src/tests/containerizer/launch_tests.cpp c7ebe2606e4ff99ced90342dd16e0b4bf02bc504
> src/tests/containerizer/memory_test_helper.cpp 4a3de2e3c887aa6afc604588850e1386f92d8c11
> src/tests/containerizer/mesos_containerizer_tests.cpp a45ed1b2175b7dc16d621a44fbccfb8f957ae2b5
> src/tests/containerizer/ns_tests.cpp 603e54b7303c5aa15e2c5715dc7a2f7e7d39541b
> src/tests/containerizer/port_mapping_tests.cpp fd6f063bc5dc3761368742851e6853547c602e3b
> src/tests/environment.cpp e112270b68d402bb9b01445af552500fb3929e52
> src/tests/event_call_framework_test.sh 9d1211552734afbf15b376f8c4629bae8a2065af
> src/tests/fetcher_tests.cpp 1831d896ca8a52bec4adf87a67b6af845079796c
> src/tests/health_check_tests.cpp 65e8fe25ed7feb1080ad833ba98e6b462bd3152c
> src/tests/mesos.cpp 8f1f8d69b299620891364c82a89a08e16706589e
> src/tests/module.cpp 246f3a402d4fe3b273c459f6e02c009f3de65f3e
> src/tests/module_tests.cpp 7b3e98bfcc3d119edd642a010bea92f47f9fe7c5
> src/tests/no_executor_framework_test.sh aebdc8c380abb2d041d6fc74dfac5a111c15267e
> src/tests/oversubscription_tests.cpp c857c2bd5135d0e30edfe6f5e856fe6641b8dcfb
> src/tests/persistent_volume_framework_test.sh 84f02847a8d89400512d8a5714d33fb29cf5b03a
> src/tests/script.cpp ee44fef29fb40e414d7507168091ee5cd0d15736
> src/tests/slave_tests.cpp b2b1fd4be933512c3dffa8c1c579b59782a37d77
> src/tests/test_framework_test.sh 409e80994f63448115ea8ac34b4fd5c6cf88aa22
> src/tests/utils.hpp a6cca472f4dfab12cd6eccab6972206d842177aa
> src/tests/utils.cpp 22bf3a85da5261fcfcc8b6aa9626aacdc8391ad4
>
> Diff: https://reviews.apache.org/r/40553/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> James Peach
>
>
Re: Review Request 40553: Enable mesos tests installation.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40553/#review117871
-----------------------------------------------------------
Patch looks great!
Reviews applied: [39780, 39781, 39782, 40553]
Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On Feb. 4, 2016, 6:14 p.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40553/
> -----------------------------------------------------------
>
> (Updated Feb. 4, 2016, 6:14 p.m.)
>
>
> Review request for mesos, Benjamin Bannier and Till Toenshoff.
>
>
> Bugs: MESOS-3608
> https://issues.apache.org/jira/browse/MESOS-3608
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch enables the installation mesos-tests and its dependencies
> and helper tool. The goal is to allow operators to build a separate
> test package that can be run at deployment time to verify that Mesos
> works in the deployment environment.
>
> Since the build directory is searched first, to run it on a host
> that has a build tree, you need to specify a non-existent tree:
>
> ~ $ $PREFIX/libexec/mesos/tests/mesos-tests --build_dir=/none
>
> - Add --enable-tests-install
> - Fix mesos-tests gmock dependencies
> - Optionally install tests, helpers and test modules
> - Add utility helpers to find various test resources
>
>
> Diffs
> -----
>
> Makefile.am fbd4e5a6356e90c867ba47c48c86fc9161ddd98e
> configure.ac cb39c7f7681eb7f5e3c379dc9a096eca1ffcca93
> src/Makefile.am a851862a476f8fec03e90d37ec5741f080c047e7
> src/examples/test_framework.cpp ff7b00543eea1a7cbf52c7abfba81600868bfbab
> src/tests/balloon_framework_test.sh 25a19cfde87a3fd2d7d3e780700d342d08bd0a91
> src/tests/containerizer/launch_tests.cpp c7ebe2606e4ff99ced90342dd16e0b4bf02bc504
> src/tests/containerizer/memory_test_helper.cpp 4a3de2e3c887aa6afc604588850e1386f92d8c11
> src/tests/containerizer/mesos_containerizer_tests.cpp a45ed1b2175b7dc16d621a44fbccfb8f957ae2b5
> src/tests/containerizer/ns_tests.cpp 603e54b7303c5aa15e2c5715dc7a2f7e7d39541b
> src/tests/containerizer/port_mapping_tests.cpp fd6f063bc5dc3761368742851e6853547c602e3b
> src/tests/environment.cpp e112270b68d402bb9b01445af552500fb3929e52
> src/tests/event_call_framework_test.sh 9d1211552734afbf15b376f8c4629bae8a2065af
> src/tests/fetcher_tests.cpp 1831d896ca8a52bec4adf87a67b6af845079796c
> src/tests/health_check_tests.cpp 65e8fe25ed7feb1080ad833ba98e6b462bd3152c
> src/tests/mesos.cpp 8f1f8d69b299620891364c82a89a08e16706589e
> src/tests/module.cpp 246f3a402d4fe3b273c459f6e02c009f3de65f3e
> src/tests/module_tests.cpp 7b3e98bfcc3d119edd642a010bea92f47f9fe7c5
> src/tests/no_executor_framework_test.sh aebdc8c380abb2d041d6fc74dfac5a111c15267e
> src/tests/oversubscription_tests.cpp c857c2bd5135d0e30edfe6f5e856fe6641b8dcfb
> src/tests/persistent_volume_framework_test.sh 84f02847a8d89400512d8a5714d33fb29cf5b03a
> src/tests/script.cpp ee44fef29fb40e414d7507168091ee5cd0d15736
> src/tests/slave_tests.cpp b2b1fd4be933512c3dffa8c1c579b59782a37d77
> src/tests/test_framework_test.sh 409e80994f63448115ea8ac34b4fd5c6cf88aa22
> src/tests/utils.hpp a6cca472f4dfab12cd6eccab6972206d842177aa
> src/tests/utils.cpp 22bf3a85da5261fcfcc8b6aa9626aacdc8391ad4
>
> Diff: https://reviews.apache.org/r/40553/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> James Peach
>
>
Re: Review Request 40553: Enable mesos tests installation.
Posted by Till Toenshoff <to...@me.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40553/#review118233
-----------------------------------------------------------
Fix it, then Ship it!
Thanks a bunch James, this looks great considering the complexity ;). Just some (debatable) nits I will fix while landing this.
Makefile.am (lines 98 - 100)
<https://reviews.apache.org/r/40553/#comment179456>
Backslash alignment.
src/Makefile.am (lines 1883 - 1884)
<https://reviews.apache.org/r/40553/#comment179448>
Let's make the backslashes align.
src/Makefile.am (lines 1986 - 1994)
<https://reviews.apache.org/r/40553/#comment179449>
Backslash alignment.
src/tests/containerizer/memory_test_helper.cpp
<https://reviews.apache.org/r/40553/#comment179457>
This should remain.
src/tests/utils.hpp (line 65)
<https://reviews.apache.org/r/40553/#comment179452>
For consistency, let's add a short comment here as well.
- Till Toenshoff
On Feb. 4, 2016, 6:14 p.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40553/
> -----------------------------------------------------------
>
> (Updated Feb. 4, 2016, 6:14 p.m.)
>
>
> Review request for mesos, Benjamin Bannier and Till Toenshoff.
>
>
> Bugs: MESOS-3608
> https://issues.apache.org/jira/browse/MESOS-3608
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch enables the installation mesos-tests and its dependencies
> and helper tool. The goal is to allow operators to build a separate
> test package that can be run at deployment time to verify that Mesos
> works in the deployment environment.
>
> Since the build directory is searched first, to run it on a host
> that has a build tree, you need to specify a non-existent tree:
>
> ~ $ $PREFIX/libexec/mesos/tests/mesos-tests --build_dir=/none
>
> - Add --enable-tests-install
> - Fix mesos-tests gmock dependencies
> - Optionally install tests, helpers and test modules
> - Add utility helpers to find various test resources
>
>
> Diffs
> -----
>
> Makefile.am fbd4e5a6356e90c867ba47c48c86fc9161ddd98e
> configure.ac cb39c7f7681eb7f5e3c379dc9a096eca1ffcca93
> src/Makefile.am a851862a476f8fec03e90d37ec5741f080c047e7
> src/examples/test_framework.cpp ff7b00543eea1a7cbf52c7abfba81600868bfbab
> src/tests/balloon_framework_test.sh 25a19cfde87a3fd2d7d3e780700d342d08bd0a91
> src/tests/containerizer/launch_tests.cpp c7ebe2606e4ff99ced90342dd16e0b4bf02bc504
> src/tests/containerizer/memory_test_helper.cpp 4a3de2e3c887aa6afc604588850e1386f92d8c11
> src/tests/containerizer/mesos_containerizer_tests.cpp a45ed1b2175b7dc16d621a44fbccfb8f957ae2b5
> src/tests/containerizer/ns_tests.cpp 603e54b7303c5aa15e2c5715dc7a2f7e7d39541b
> src/tests/containerizer/port_mapping_tests.cpp fd6f063bc5dc3761368742851e6853547c602e3b
> src/tests/environment.cpp e112270b68d402bb9b01445af552500fb3929e52
> src/tests/event_call_framework_test.sh 9d1211552734afbf15b376f8c4629bae8a2065af
> src/tests/fetcher_tests.cpp 1831d896ca8a52bec4adf87a67b6af845079796c
> src/tests/health_check_tests.cpp 65e8fe25ed7feb1080ad833ba98e6b462bd3152c
> src/tests/mesos.cpp 8f1f8d69b299620891364c82a89a08e16706589e
> src/tests/module.cpp 246f3a402d4fe3b273c459f6e02c009f3de65f3e
> src/tests/module_tests.cpp 7b3e98bfcc3d119edd642a010bea92f47f9fe7c5
> src/tests/no_executor_framework_test.sh aebdc8c380abb2d041d6fc74dfac5a111c15267e
> src/tests/oversubscription_tests.cpp c857c2bd5135d0e30edfe6f5e856fe6641b8dcfb
> src/tests/persistent_volume_framework_test.sh 84f02847a8d89400512d8a5714d33fb29cf5b03a
> src/tests/script.cpp ee44fef29fb40e414d7507168091ee5cd0d15736
> src/tests/slave_tests.cpp b2b1fd4be933512c3dffa8c1c579b59782a37d77
> src/tests/test_framework_test.sh 409e80994f63448115ea8ac34b4fd5c6cf88aa22
> src/tests/utils.hpp a6cca472f4dfab12cd6eccab6972206d842177aa
> src/tests/utils.cpp 22bf3a85da5261fcfcc8b6aa9626aacdc8391ad4
>
> Diff: https://reviews.apache.org/r/40553/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> James Peach
>
>
Re: Review Request 40553: Enable mesos tests installation.
Posted by James Peach <jp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40553/
-----------------------------------------------------------
(Updated Feb. 4, 2016, 6:14 p.m.)
Review request for mesos, Benjamin Bannier and Till Toenshoff.
Changes
-------
Rebase onto master.
Bugs: MESOS-3608
https://issues.apache.org/jira/browse/MESOS-3608
Repository: mesos
Description
-------
This patch enables the installation mesos-tests and its dependencies
and helper tool. The goal is to allow operators to build a separate
test package that can be run at deployment time to verify that Mesos
works in the deployment environment.
Since the build directory is searched first, to run it on a host
that has a build tree, you need to specify a non-existent tree:
~ $ $PREFIX/libexec/mesos/tests/mesos-tests --build_dir=/none
- Add --enable-tests-install
- Fix mesos-tests gmock dependencies
- Optionally install tests, helpers and test modules
- Add utility helpers to find various test resources
Diffs (updated)
-----
Makefile.am fbd4e5a6356e90c867ba47c48c86fc9161ddd98e
configure.ac cb39c7f7681eb7f5e3c379dc9a096eca1ffcca93
src/Makefile.am a851862a476f8fec03e90d37ec5741f080c047e7
src/examples/test_framework.cpp ff7b00543eea1a7cbf52c7abfba81600868bfbab
src/tests/balloon_framework_test.sh 25a19cfde87a3fd2d7d3e780700d342d08bd0a91
src/tests/containerizer/launch_tests.cpp c7ebe2606e4ff99ced90342dd16e0b4bf02bc504
src/tests/containerizer/memory_test_helper.cpp 4a3de2e3c887aa6afc604588850e1386f92d8c11
src/tests/containerizer/mesos_containerizer_tests.cpp a45ed1b2175b7dc16d621a44fbccfb8f957ae2b5
src/tests/containerizer/ns_tests.cpp 603e54b7303c5aa15e2c5715dc7a2f7e7d39541b
src/tests/containerizer/port_mapping_tests.cpp fd6f063bc5dc3761368742851e6853547c602e3b
src/tests/environment.cpp e112270b68d402bb9b01445af552500fb3929e52
src/tests/event_call_framework_test.sh 9d1211552734afbf15b376f8c4629bae8a2065af
src/tests/fetcher_tests.cpp 1831d896ca8a52bec4adf87a67b6af845079796c
src/tests/health_check_tests.cpp 65e8fe25ed7feb1080ad833ba98e6b462bd3152c
src/tests/mesos.cpp 8f1f8d69b299620891364c82a89a08e16706589e
src/tests/module.cpp 246f3a402d4fe3b273c459f6e02c009f3de65f3e
src/tests/module_tests.cpp 7b3e98bfcc3d119edd642a010bea92f47f9fe7c5
src/tests/no_executor_framework_test.sh aebdc8c380abb2d041d6fc74dfac5a111c15267e
src/tests/oversubscription_tests.cpp c857c2bd5135d0e30edfe6f5e856fe6641b8dcfb
src/tests/persistent_volume_framework_test.sh 84f02847a8d89400512d8a5714d33fb29cf5b03a
src/tests/script.cpp ee44fef29fb40e414d7507168091ee5cd0d15736
src/tests/slave_tests.cpp b2b1fd4be933512c3dffa8c1c579b59782a37d77
src/tests/test_framework_test.sh 409e80994f63448115ea8ac34b4fd5c6cf88aa22
src/tests/utils.hpp a6cca472f4dfab12cd6eccab6972206d842177aa
src/tests/utils.cpp 22bf3a85da5261fcfcc8b6aa9626aacdc8391ad4
Diff: https://reviews.apache.org/r/40553/diff/
Testing
-------
Thanks,
James Peach
Re: Review Request 40553: Enable mesos tests installation.
Posted by James Peach <jp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40553/
-----------------------------------------------------------
(Updated Jan. 28, 2016, 12:49 a.m.)
Review request for mesos, Benjamin Bannier and Till Toenshoff.
Changes
-------
Switch to installcheck-local.
Bugs: MESOS-3608
https://issues.apache.org/jira/browse/MESOS-3608
Repository: mesos
Description
-------
This patch enables the installation mesos-tests and its dependencies
and helper tool. The goal is to allow operators to build a separate
test package that can be run at deployment time to verify that Mesos
works in the deployment environment.
Since the build directory is searched first, to run it on a host
that has a build tree, you need to specify a non-existent tree:
~ $ $PREFIX/libexec/mesos/tests/mesos-tests --build_dir=/none
- Add --enable-tests-install
- Fix mesos-tests gmock dependencies
- Optionally install tests, helpers and test modules
- Add utility helpers to find various test resources
Diffs (updated)
-----
Makefile.am fbd4e5a6356e90c867ba47c48c86fc9161ddd98e
configure.ac 70d16871d5888ac1d9d5fb0ba0b453799b00f320
src/Makefile.am 8657a869f931aa7482fbb09f2c6df95b6a8c50c6
src/examples/test_framework.cpp ff7b00543eea1a7cbf52c7abfba81600868bfbab
src/tests/balloon_framework_test.sh 25a19cfde87a3fd2d7d3e780700d342d08bd0a91
src/tests/containerizer/launch_tests.cpp c7ebe2606e4ff99ced90342dd16e0b4bf02bc504
src/tests/containerizer/memory_test_helper.cpp 4a3de2e3c887aa6afc604588850e1386f92d8c11
src/tests/containerizer/mesos_containerizer_tests.cpp a45ed1b2175b7dc16d621a44fbccfb8f957ae2b5
src/tests/containerizer/ns_tests.cpp 603e54b7303c5aa15e2c5715dc7a2f7e7d39541b
src/tests/containerizer/port_mapping_tests.cpp 182fe9217a5da9af603d6f9c203a1689eff4ca1b
src/tests/environment.cpp e112270b68d402bb9b01445af552500fb3929e52
src/tests/event_call_framework_test.sh 9d1211552734afbf15b376f8c4629bae8a2065af
src/tests/fetcher_tests.cpp 1831d896ca8a52bec4adf87a67b6af845079796c
src/tests/health_check_tests.cpp 65e8fe25ed7feb1080ad833ba98e6b462bd3152c
src/tests/mesos.cpp 18d0d8f8037ebc27c87bcb0f1ce9f143e7505ec8
src/tests/module.cpp 246f3a402d4fe3b273c459f6e02c009f3de65f3e
src/tests/module_tests.cpp a3271a3267647e0964dd3decb3ca8384417dd559
src/tests/no_executor_framework_test.sh aebdc8c380abb2d041d6fc74dfac5a111c15267e
src/tests/oversubscription_tests.cpp 6f43103e81303015fb614653e3bfece55009d1bf
src/tests/persistent_volume_framework_test.sh 84f02847a8d89400512d8a5714d33fb29cf5b03a
src/tests/script.cpp ee44fef29fb40e414d7507168091ee5cd0d15736
src/tests/slave_tests.cpp e943ab99baf3d74679a5da888889a89f6a4b7ead
src/tests/test_framework_test.sh 409e80994f63448115ea8ac34b4fd5c6cf88aa22
src/tests/utils.hpp a6cca472f4dfab12cd6eccab6972206d842177aa
src/tests/utils.cpp 22bf3a85da5261fcfcc8b6aa9626aacdc8391ad4
Diff: https://reviews.apache.org/r/40553/diff/
Testing
-------
Thanks,
James Peach
Re: Review Request 40553: Enable mesos tests installation.
Posted by James Peach <jp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40553/
-----------------------------------------------------------
(Updated Jan. 27, 2016, 9:03 p.m.)
Review request for mesos, Benjamin Bannier and Till Toenshoff.
Changes
-------
Updated to address review comments.
Bugs: MESOS-3608
https://issues.apache.org/jira/browse/MESOS-3608
Repository: mesos
Description
-------
This patch enables the installation mesos-tests and its dependencies
and helper tool. The goal is to allow operators to build a separate
test package that can be run at deployment time to verify that Mesos
works in the deployment environment.
Since the build directory is searched first, to run it on a host
that has a build tree, you need to specify a non-existent tree:
~ $ $PREFIX/libexec/mesos/tests/mesos-tests --build_dir=/none
- Add --enable-tests-install
- Fix mesos-tests gmock dependencies
- Optionally install tests, helpers and test modules
- Add utility helpers to find various test resources
Diffs (updated)
-----
Makefile.am fbd4e5a6356e90c867ba47c48c86fc9161ddd98e
configure.ac 70d16871d5888ac1d9d5fb0ba0b453799b00f320
src/Makefile.am 8657a869f931aa7482fbb09f2c6df95b6a8c50c6
src/examples/test_framework.cpp ff7b00543eea1a7cbf52c7abfba81600868bfbab
src/tests/balloon_framework_test.sh 25a19cfde87a3fd2d7d3e780700d342d08bd0a91
src/tests/containerizer/launch_tests.cpp c7ebe2606e4ff99ced90342dd16e0b4bf02bc504
src/tests/containerizer/memory_test_helper.cpp 4a3de2e3c887aa6afc604588850e1386f92d8c11
src/tests/containerizer/mesos_containerizer_tests.cpp a45ed1b2175b7dc16d621a44fbccfb8f957ae2b5
src/tests/containerizer/ns_tests.cpp 603e54b7303c5aa15e2c5715dc7a2f7e7d39541b
src/tests/containerizer/port_mapping_tests.cpp 182fe9217a5da9af603d6f9c203a1689eff4ca1b
src/tests/environment.cpp e112270b68d402bb9b01445af552500fb3929e52
src/tests/event_call_framework_test.sh 9d1211552734afbf15b376f8c4629bae8a2065af
src/tests/fetcher_tests.cpp 1831d896ca8a52bec4adf87a67b6af845079796c
src/tests/health_check_tests.cpp 65e8fe25ed7feb1080ad833ba98e6b462bd3152c
src/tests/mesos.cpp 18d0d8f8037ebc27c87bcb0f1ce9f143e7505ec8
src/tests/module.cpp 246f3a402d4fe3b273c459f6e02c009f3de65f3e
src/tests/module_tests.cpp a3271a3267647e0964dd3decb3ca8384417dd559
src/tests/no_executor_framework_test.sh aebdc8c380abb2d041d6fc74dfac5a111c15267e
src/tests/oversubscription_tests.cpp 6f43103e81303015fb614653e3bfece55009d1bf
src/tests/persistent_volume_framework_test.sh 84f02847a8d89400512d8a5714d33fb29cf5b03a
src/tests/script.cpp ee44fef29fb40e414d7507168091ee5cd0d15736
src/tests/slave_tests.cpp e943ab99baf3d74679a5da888889a89f6a4b7ead
src/tests/test_framework_test.sh 409e80994f63448115ea8ac34b4fd5c6cf88aa22
src/tests/utils.hpp a6cca472f4dfab12cd6eccab6972206d842177aa
src/tests/utils.cpp 22bf3a85da5261fcfcc8b6aa9626aacdc8391ad4
Diff: https://reviews.apache.org/r/40553/diff/
Testing
-------
Thanks,
James Peach
Re: Review Request 40553: Enable mesos tests installation.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40553/#review116608
-----------------------------------------------------------
Patch looks great!
Reviews applied: [39780, 39781, 39782, 40553]
Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh
- Mesos ReviewBot
On Jan. 27, 2016, 5:54 p.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40553/
> -----------------------------------------------------------
>
> (Updated Jan. 27, 2016, 5:54 p.m.)
>
>
> Review request for mesos, Benjamin Bannier and Till Toenshoff.
>
>
> Bugs: MESOS-3608
> https://issues.apache.org/jira/browse/MESOS-3608
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch enables the installation mesos-tests and its dependencies
> and helper tool. The goal is to allow operators to build a separate
> test package that can be run at deployment time to verify that Mesos
> works in the deployment environment.
>
> Since the build directory is searched first, to run it on a host
> that has a build tree, you need to specify a non-existent tree:
>
> ~ $ $PREFIX/libexec/mesos/tests/mesos-tests --build_dir=/none
>
> - Add --enable-tests-install
> - Fix mesos-tests gmock dependencies
> - Optionally install tests, helpers and test modules
> - Add utility helpers to find various test resources
>
>
> Diffs
> -----
>
> Makefile.am fbd4e5a6356e90c867ba47c48c86fc9161ddd98e
> configure.ac 70d16871d5888ac1d9d5fb0ba0b453799b00f320
> src/Makefile.am 8657a869f931aa7482fbb09f2c6df95b6a8c50c6
> src/examples/test_framework.cpp ff7b00543eea1a7cbf52c7abfba81600868bfbab
> src/tests/balloon_framework_test.sh 25a19cfde87a3fd2d7d3e780700d342d08bd0a91
> src/tests/containerizer/launch_tests.cpp c7ebe2606e4ff99ced90342dd16e0b4bf02bc504
> src/tests/containerizer/memory_test_helper.cpp 4a3de2e3c887aa6afc604588850e1386f92d8c11
> src/tests/containerizer/mesos_containerizer_tests.cpp a45ed1b2175b7dc16d621a44fbccfb8f957ae2b5
> src/tests/containerizer/ns_tests.cpp 603e54b7303c5aa15e2c5715dc7a2f7e7d39541b
> src/tests/containerizer/port_mapping_tests.cpp 182fe9217a5da9af603d6f9c203a1689eff4ca1b
> src/tests/environment.cpp e112270b68d402bb9b01445af552500fb3929e52
> src/tests/event_call_framework_test.sh 9d1211552734afbf15b376f8c4629bae8a2065af
> src/tests/fetcher_tests.cpp 1831d896ca8a52bec4adf87a67b6af845079796c
> src/tests/health_check_tests.cpp 65e8fe25ed7feb1080ad833ba98e6b462bd3152c
> src/tests/mesos.cpp 18d0d8f8037ebc27c87bcb0f1ce9f143e7505ec8
> src/tests/module.cpp 246f3a402d4fe3b273c459f6e02c009f3de65f3e
> src/tests/module_tests.cpp a3271a3267647e0964dd3decb3ca8384417dd559
> src/tests/no_executor_framework_test.sh aebdc8c380abb2d041d6fc74dfac5a111c15267e
> src/tests/oversubscription_tests.cpp 6f43103e81303015fb614653e3bfece55009d1bf
> src/tests/persistent_volume_framework_test.sh 84f02847a8d89400512d8a5714d33fb29cf5b03a
> src/tests/script.cpp ee44fef29fb40e414d7507168091ee5cd0d15736
> src/tests/slave_tests.cpp e943ab99baf3d74679a5da888889a89f6a4b7ead
> src/tests/test_framework_test.sh 409e80994f63448115ea8ac34b4fd5c6cf88aa22
> src/tests/utils.hpp a6cca472f4dfab12cd6eccab6972206d842177aa
> src/tests/utils.cpp 22bf3a85da5261fcfcc8b6aa9626aacdc8391ad4
>
> Diff: https://reviews.apache.org/r/40553/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> James Peach
>
>
Re: Review Request 40553: Enable mesos tests installation.
Posted by James Peach <jp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40553/
-----------------------------------------------------------
(Updated Jan. 27, 2016, 5:54 p.m.)
Review request for mesos, Benjamin Bannier and Till Toenshoff.
Changes
-------
Rebased onto master and added support for new tests.
All tests are passing except the python and Java example frameworks and ZooKeeper tests, since those tests intrinsically depend on artifacts that are only found in the source tree.
Bugs: MESOS-3608
https://issues.apache.org/jira/browse/MESOS-3608
Repository: mesos
Description (updated)
-------
This patch enables the installation mesos-tests and its dependencies
and helper tool. The goal is to allow operators to build a separate
test package that can be run at deployment time to verify that Mesos
works in the deployment environment.
Since the build directory is searched first, to run it on a host
that has a build tree, you need to specify a non-existent tree:
~ $ $PREFIX/libexec/mesos/tests/mesos-tests --build_dir=/none
- Add --enable-tests-install
- Fix mesos-tests gmock dependencies
- Optionally install tests, helpers and test modules
- Add utility helpers to find various test resources
Diffs (updated)
-----
Makefile.am fbd4e5a6356e90c867ba47c48c86fc9161ddd98e
configure.ac 70d16871d5888ac1d9d5fb0ba0b453799b00f320
src/Makefile.am 8657a869f931aa7482fbb09f2c6df95b6a8c50c6
src/examples/test_framework.cpp ff7b00543eea1a7cbf52c7abfba81600868bfbab
src/tests/balloon_framework_test.sh 25a19cfde87a3fd2d7d3e780700d342d08bd0a91
src/tests/containerizer/launch_tests.cpp c7ebe2606e4ff99ced90342dd16e0b4bf02bc504
src/tests/containerizer/memory_test_helper.cpp 4a3de2e3c887aa6afc604588850e1386f92d8c11
src/tests/containerizer/mesos_containerizer_tests.cpp a45ed1b2175b7dc16d621a44fbccfb8f957ae2b5
src/tests/containerizer/ns_tests.cpp 603e54b7303c5aa15e2c5715dc7a2f7e7d39541b
src/tests/containerizer/port_mapping_tests.cpp 182fe9217a5da9af603d6f9c203a1689eff4ca1b
src/tests/environment.cpp e112270b68d402bb9b01445af552500fb3929e52
src/tests/event_call_framework_test.sh 9d1211552734afbf15b376f8c4629bae8a2065af
src/tests/fetcher_tests.cpp 1831d896ca8a52bec4adf87a67b6af845079796c
src/tests/health_check_tests.cpp 65e8fe25ed7feb1080ad833ba98e6b462bd3152c
src/tests/mesos.cpp 18d0d8f8037ebc27c87bcb0f1ce9f143e7505ec8
src/tests/module.cpp 246f3a402d4fe3b273c459f6e02c009f3de65f3e
src/tests/module_tests.cpp a3271a3267647e0964dd3decb3ca8384417dd559
src/tests/no_executor_framework_test.sh aebdc8c380abb2d041d6fc74dfac5a111c15267e
src/tests/oversubscription_tests.cpp 6f43103e81303015fb614653e3bfece55009d1bf
src/tests/persistent_volume_framework_test.sh 84f02847a8d89400512d8a5714d33fb29cf5b03a
src/tests/script.cpp ee44fef29fb40e414d7507168091ee5cd0d15736
src/tests/slave_tests.cpp e943ab99baf3d74679a5da888889a89f6a4b7ead
src/tests/test_framework_test.sh 409e80994f63448115ea8ac34b4fd5c6cf88aa22
src/tests/utils.hpp a6cca472f4dfab12cd6eccab6972206d842177aa
src/tests/utils.cpp 22bf3a85da5261fcfcc8b6aa9626aacdc8391ad4
Diff: https://reviews.apache.org/r/40553/diff/
Testing
-------
Thanks,
James Peach
Re: Review Request 40553: Enable mesos tests installation.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40553/#review116385
-----------------------------------------------------------
Could you please rebase? This doesn't apply for me with `9e0528e`.
- Benjamin Bannier
On Jan. 22, 2016, 11:12 p.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40553/
> -----------------------------------------------------------
>
> (Updated Jan. 22, 2016, 11:12 p.m.)
>
>
> Review request for mesos, Benjamin Bannier and Till Toenshoff.
>
>
> Bugs: MESOS-3608
> https://issues.apache.org/jira/browse/MESOS-3608
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch enables the installation mesos-tests and its dependencies
> and helper tool. The goal is to allow operators to build a separate
> test package that can be run at deployment time to verify that Mesos
> works in the deployment environment.
>
> Since the build directory is searched first, to run it on a host
> that has a build tree, you need to specify a non-existent tree:
>
> ~ $ $PREFIX/libexec/mesos/tests/mesos-tests \
> --build_dir=/none \
> --source_dir=/none
>
> - Add --enable-tests-install
> - Fix mesos-tests gmock dependencies
> - Optionally install tests, helpers and test modules
> - Add utility helpers to find various test resources
>
>
> Diffs
> -----
>
> Makefile.am fbd4e5a6356e90c867ba47c48c86fc9161ddd98e
> configure.ac 70d16871d5888ac1d9d5fb0ba0b453799b00f320
> src/Makefile.am 19bf3a7c2e43ca04ed6e6d506e052de5537f7c2f
> src/examples/test_framework.cpp ff7b00543eea1a7cbf52c7abfba81600868bfbab
> src/tests/balloon_framework_test.sh 25a19cfde87a3fd2d7d3e780700d342d08bd0a91
> src/tests/containerizer/launch_tests.cpp c7ebe2606e4ff99ced90342dd16e0b4bf02bc504
> src/tests/containerizer/memory_test_helper.cpp 4a3de2e3c887aa6afc604588850e1386f92d8c11
> src/tests/containerizer/mesos_containerizer_tests.cpp 677fcc1c654f83ad3e60e0f6172a1a1e4a1045b1
> src/tests/containerizer/ns_tests.cpp 603e54b7303c5aa15e2c5715dc7a2f7e7d39541b
> src/tests/containerizer/port_mapping_tests.cpp fab16f697f90abc11d681222f10f518d70da908b
> src/tests/environment.cpp 4de46bc48b245a4c5e89b0343578b0d31883a0ac
> src/tests/event_call_framework_test.sh 9d1211552734afbf15b376f8c4629bae8a2065af
> src/tests/fetcher_tests.cpp 1831d896ca8a52bec4adf87a67b6af845079796c
> src/tests/health_check_tests.cpp 3606ce46bfa283ad0d5239fc25e02c5a9f8d1a53
> src/tests/mesos.cpp 365ebe8335c37bfdb983a5424d4c995fa9b76a22
> src/tests/module.cpp f0e64f7c462cf833839558665fdb60d9f2cbc475
> src/tests/module_tests.cpp a3271a3267647e0964dd3decb3ca8384417dd559
> src/tests/no_executor_framework_test.sh aebdc8c380abb2d041d6fc74dfac5a111c15267e
> src/tests/oversubscription_tests.cpp 6f43103e81303015fb614653e3bfece55009d1bf
> src/tests/persistent_volume_framework_test.sh 84f02847a8d89400512d8a5714d33fb29cf5b03a
> src/tests/script.cpp ee44fef29fb40e414d7507168091ee5cd0d15736
> src/tests/slave_tests.cpp e943ab99baf3d74679a5da888889a89f6a4b7ead
> src/tests/test_framework_test.sh 409e80994f63448115ea8ac34b4fd5c6cf88aa22
> src/tests/utils.hpp a6cca472f4dfab12cd6eccab6972206d842177aa
> src/tests/utils.cpp 22bf3a85da5261fcfcc8b6aa9626aacdc8391ad4
>
> Diff: https://reviews.apache.org/r/40553/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> James Peach
>
>
Re: Review Request 40553: Enable mesos tests installation.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40553/#review115974
-----------------------------------------------------------
Patch looks great!
Reviews applied: [39780, 39781, 39782, 40553]
Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh
- Mesos ReviewBot
On Jan. 22, 2016, 10:12 p.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40553/
> -----------------------------------------------------------
>
> (Updated Jan. 22, 2016, 10:12 p.m.)
>
>
> Review request for mesos, Benjamin Bannier and Till Toenshoff.
>
>
> Bugs: MESOS-3608
> https://issues.apache.org/jira/browse/MESOS-3608
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch enables the installation mesos-tests and its dependencies
> and helper tool. The goal is to allow operators to build a separate
> test package that can be run at deployment time to verify that Mesos
> works in the deployment environment.
>
> Since the build directory is searched first, to run it on a host
> that has a build tree, you need to specify a non-existent tree:
>
> ~ $ $PREFIX/libexec/mesos/tests/mesos-tests \
> --build_dir=/none \
> --source_dir=/none
>
> - Add --enable-tests-install
> - Fix mesos-tests gmock dependencies
> - Optionally install tests, helpers and test modules
> - Add utility helpers to find various test resources
>
>
> Diffs
> -----
>
> Makefile.am fbd4e5a6356e90c867ba47c48c86fc9161ddd98e
> configure.ac 70d16871d5888ac1d9d5fb0ba0b453799b00f320
> src/Makefile.am 19bf3a7c2e43ca04ed6e6d506e052de5537f7c2f
> src/examples/test_framework.cpp ff7b00543eea1a7cbf52c7abfba81600868bfbab
> src/tests/balloon_framework_test.sh 25a19cfde87a3fd2d7d3e780700d342d08bd0a91
> src/tests/containerizer/launch_tests.cpp c7ebe2606e4ff99ced90342dd16e0b4bf02bc504
> src/tests/containerizer/memory_test_helper.cpp 4a3de2e3c887aa6afc604588850e1386f92d8c11
> src/tests/containerizer/mesos_containerizer_tests.cpp 677fcc1c654f83ad3e60e0f6172a1a1e4a1045b1
> src/tests/containerizer/ns_tests.cpp 603e54b7303c5aa15e2c5715dc7a2f7e7d39541b
> src/tests/containerizer/port_mapping_tests.cpp fab16f697f90abc11d681222f10f518d70da908b
> src/tests/environment.cpp 4de46bc48b245a4c5e89b0343578b0d31883a0ac
> src/tests/event_call_framework_test.sh 9d1211552734afbf15b376f8c4629bae8a2065af
> src/tests/fetcher_tests.cpp 1831d896ca8a52bec4adf87a67b6af845079796c
> src/tests/health_check_tests.cpp 3606ce46bfa283ad0d5239fc25e02c5a9f8d1a53
> src/tests/mesos.cpp 365ebe8335c37bfdb983a5424d4c995fa9b76a22
> src/tests/module.cpp f0e64f7c462cf833839558665fdb60d9f2cbc475
> src/tests/module_tests.cpp a3271a3267647e0964dd3decb3ca8384417dd559
> src/tests/no_executor_framework_test.sh aebdc8c380abb2d041d6fc74dfac5a111c15267e
> src/tests/oversubscription_tests.cpp 6f43103e81303015fb614653e3bfece55009d1bf
> src/tests/persistent_volume_framework_test.sh 84f02847a8d89400512d8a5714d33fb29cf5b03a
> src/tests/script.cpp ee44fef29fb40e414d7507168091ee5cd0d15736
> src/tests/slave_tests.cpp e943ab99baf3d74679a5da888889a89f6a4b7ead
> src/tests/test_framework_test.sh 409e80994f63448115ea8ac34b4fd5c6cf88aa22
> src/tests/utils.hpp a6cca472f4dfab12cd6eccab6972206d842177aa
> src/tests/utils.cpp 22bf3a85da5261fcfcc8b6aa9626aacdc8391ad4
>
> Diff: https://reviews.apache.org/r/40553/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> James Peach
>
>
Re: Review Request 40553: Enable mesos tests installation.
Posted by James Peach <jp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40553/
-----------------------------------------------------------
(Updated Jan. 22, 2016, 10:12 p.m.)
Review request for mesos, Benjamin Bannier and Till Toenshoff.
Summary (updated)
-----------------
Enable mesos tests installation.
Bugs: MESOS-3608
https://issues.apache.org/jira/browse/MESOS-3608
Repository: mesos
Description
-------
This patch enables the installation mesos-tests and its dependencies
and helper tool. The goal is to allow operators to build a separate
test package that can be run at deployment time to verify that Mesos
works in the deployment environment.
Since the build directory is searched first, to run it on a host
that has a build tree, you need to specify a non-existent tree:
~ $ $PREFIX/libexec/mesos/tests/mesos-tests \
--build_dir=/none \
--source_dir=/none
- Add --enable-tests-install
- Fix mesos-tests gmock dependencies
- Optionally install tests, helpers and test modules
- Add utility helpers to find various test resources
Diffs
-----
Makefile.am fbd4e5a6356e90c867ba47c48c86fc9161ddd98e
configure.ac 70d16871d5888ac1d9d5fb0ba0b453799b00f320
src/Makefile.am 19bf3a7c2e43ca04ed6e6d506e052de5537f7c2f
src/examples/test_framework.cpp ff7b00543eea1a7cbf52c7abfba81600868bfbab
src/tests/balloon_framework_test.sh 25a19cfde87a3fd2d7d3e780700d342d08bd0a91
src/tests/containerizer/launch_tests.cpp c7ebe2606e4ff99ced90342dd16e0b4bf02bc504
src/tests/containerizer/memory_test_helper.cpp 4a3de2e3c887aa6afc604588850e1386f92d8c11
src/tests/containerizer/mesos_containerizer_tests.cpp 677fcc1c654f83ad3e60e0f6172a1a1e4a1045b1
src/tests/containerizer/ns_tests.cpp 603e54b7303c5aa15e2c5715dc7a2f7e7d39541b
src/tests/containerizer/port_mapping_tests.cpp fab16f697f90abc11d681222f10f518d70da908b
src/tests/environment.cpp 4de46bc48b245a4c5e89b0343578b0d31883a0ac
src/tests/event_call_framework_test.sh 9d1211552734afbf15b376f8c4629bae8a2065af
src/tests/fetcher_tests.cpp 1831d896ca8a52bec4adf87a67b6af845079796c
src/tests/health_check_tests.cpp 3606ce46bfa283ad0d5239fc25e02c5a9f8d1a53
src/tests/mesos.cpp 365ebe8335c37bfdb983a5424d4c995fa9b76a22
src/tests/module.cpp f0e64f7c462cf833839558665fdb60d9f2cbc475
src/tests/module_tests.cpp a3271a3267647e0964dd3decb3ca8384417dd559
src/tests/no_executor_framework_test.sh aebdc8c380abb2d041d6fc74dfac5a111c15267e
src/tests/oversubscription_tests.cpp 6f43103e81303015fb614653e3bfece55009d1bf
src/tests/persistent_volume_framework_test.sh 84f02847a8d89400512d8a5714d33fb29cf5b03a
src/tests/script.cpp ee44fef29fb40e414d7507168091ee5cd0d15736
src/tests/slave_tests.cpp e943ab99baf3d74679a5da888889a89f6a4b7ead
src/tests/test_framework_test.sh 409e80994f63448115ea8ac34b4fd5c6cf88aa22
src/tests/utils.hpp a6cca472f4dfab12cd6eccab6972206d842177aa
src/tests/utils.cpp 22bf3a85da5261fcfcc8b6aa9626aacdc8391ad4
Diff: https://reviews.apache.org/r/40553/diff/
Testing
-------
Thanks,
James Peach
Re: Review Request 40553: Enable mesos tests installation
Posted by James Peach <jp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40553/
-----------------------------------------------------------
(Updated Jan. 22, 2016, 10:03 p.m.)
Review request for mesos, Benjamin Bannier and Till Toenshoff.
Changes
-------
Updated to get ExampleFramework tests working. Verified on Fedora 23. All non-root tests pass both when you install and when you run from the build directory. When running as root, I got 2 failures because I have swap enabled, and 1 because the network isolator doesn't expect the net_prio cgroup.
```
[jpeach@jpeach build-install-tests]$ /opt/mesos/libexec/mesos/tests/mesos-tests --build_dir=/none --source_dir=/none
...
[==========] 896 tests from 119 test cases ran. (181364 ms total)
[ PASSED ] 896 tests.
```
Summary (updated)
-----------------
Enable mesos tests installation
Bugs: MESOS-3608
https://issues.apache.org/jira/browse/MESOS-3608
Repository: mesos
Description (updated)
-------
This patch enables the installation mesos-tests and its dependencies
and helper tool. The goal is to allow operators to build a separate
test package that can be run at deployment time to verify that Mesos
works in the deployment environment.
Since the build directory is searched first, to run it on a host
that has a build tree, you need to specify a non-existent tree:
~ $ $PREFIX/libexec/mesos/tests/mesos-tests \
--build_dir=/none \
--source_dir=/none
- Add --enable-tests-install
- Fix mesos-tests gmock dependencies
- Optionally install tests, helpers and test modules
- Add utility helpers to find various test resources
Diffs (updated)
-----
Makefile.am fbd4e5a6356e90c867ba47c48c86fc9161ddd98e
configure.ac 70d16871d5888ac1d9d5fb0ba0b453799b00f320
src/Makefile.am 19bf3a7c2e43ca04ed6e6d506e052de5537f7c2f
src/examples/test_framework.cpp ff7b00543eea1a7cbf52c7abfba81600868bfbab
src/tests/balloon_framework_test.sh 25a19cfde87a3fd2d7d3e780700d342d08bd0a91
src/tests/containerizer/launch_tests.cpp c7ebe2606e4ff99ced90342dd16e0b4bf02bc504
src/tests/containerizer/memory_test_helper.cpp 4a3de2e3c887aa6afc604588850e1386f92d8c11
src/tests/containerizer/mesos_containerizer_tests.cpp 677fcc1c654f83ad3e60e0f6172a1a1e4a1045b1
src/tests/containerizer/ns_tests.cpp 603e54b7303c5aa15e2c5715dc7a2f7e7d39541b
src/tests/containerizer/port_mapping_tests.cpp fab16f697f90abc11d681222f10f518d70da908b
src/tests/environment.cpp 4de46bc48b245a4c5e89b0343578b0d31883a0ac
src/tests/event_call_framework_test.sh 9d1211552734afbf15b376f8c4629bae8a2065af
src/tests/fetcher_tests.cpp 1831d896ca8a52bec4adf87a67b6af845079796c
src/tests/health_check_tests.cpp 3606ce46bfa283ad0d5239fc25e02c5a9f8d1a53
src/tests/mesos.cpp 365ebe8335c37bfdb983a5424d4c995fa9b76a22
src/tests/module.cpp f0e64f7c462cf833839558665fdb60d9f2cbc475
src/tests/module_tests.cpp a3271a3267647e0964dd3decb3ca8384417dd559
src/tests/no_executor_framework_test.sh aebdc8c380abb2d041d6fc74dfac5a111c15267e
src/tests/oversubscription_tests.cpp 6f43103e81303015fb614653e3bfece55009d1bf
src/tests/persistent_volume_framework_test.sh 84f02847a8d89400512d8a5714d33fb29cf5b03a
src/tests/script.cpp ee44fef29fb40e414d7507168091ee5cd0d15736
src/tests/slave_tests.cpp e943ab99baf3d74679a5da888889a89f6a4b7ead
src/tests/test_framework_test.sh 409e80994f63448115ea8ac34b4fd5c6cf88aa22
src/tests/utils.hpp a6cca472f4dfab12cd6eccab6972206d842177aa
src/tests/utils.cpp 22bf3a85da5261fcfcc8b6aa9626aacdc8391ad4
Diff: https://reviews.apache.org/r/40553/diff/
Testing
-------
Thanks,
James Peach
Re: Review Request 40553: Enable mesos tests installation.
Posted by James Peach <jp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40553/
-----------------------------------------------------------
(Updated Jan. 16, 2016, 5:41 p.m.)
Review request for mesos, Benjamin Bannier and Till Toenshoff.
Changes
-------
Update summary with a period.
Summary (updated)
-----------------
Enable mesos tests installation.
Bugs: MESOS-3608
https://issues.apache.org/jira/browse/MESOS-3608
Repository: mesos
Description
-------
This patch enables the installation mesos-tests and its dependencies
and helper tool. The goal is to allow operators to build a separate
test package that can be run at deployment time to verify that Mesos
works in the deployment environment.
Since the build directory is searched first, to run it on a host
that has a build tree, you need to specify a non-existent tree:
~ $ $PREFIX/libexec/mesos/tests/mesos-tests --build_dir=/none
- Add --enable-tests-install
- Fix mesos-tests gmock dependencies
- Optionally install tests, helpers and test modules
- Add utility helpers to find various test resources
Diffs
-----
Makefile.am fbd4e5a6356e90c867ba47c48c86fc9161ddd98e
configure.ac 40d60a63cdba41d06305f09141f4d14d6e229d95
src/Makefile.am d23e35001078a86775bd9b76baa207ecb9dab7e1
src/tests/balloon_framework_test.sh 25a19cfde87a3fd2d7d3e780700d342d08bd0a91
src/tests/containerizer/launch_tests.cpp c7ebe2606e4ff99ced90342dd16e0b4bf02bc504
src/tests/containerizer/memory_test_helper.cpp 4a3de2e3c887aa6afc604588850e1386f92d8c11
src/tests/containerizer/mesos_containerizer_tests.cpp 677fcc1c654f83ad3e60e0f6172a1a1e4a1045b1
src/tests/containerizer/ns_tests.cpp 603e54b7303c5aa15e2c5715dc7a2f7e7d39541b
src/tests/containerizer/port_mapping_tests.cpp fab16f697f90abc11d681222f10f518d70da908b
src/tests/environment.cpp 20218a086baefcefb310eb45ed9024e5425ce787
src/tests/event_call_framework_test.sh 9d1211552734afbf15b376f8c4629bae8a2065af
src/tests/fetcher_tests.cpp 1831d896ca8a52bec4adf87a67b6af845079796c
src/tests/health_check_tests.cpp 3606ce46bfa283ad0d5239fc25e02c5a9f8d1a53
src/tests/mesos.cpp 365ebe8335c37bfdb983a5424d4c995fa9b76a22
src/tests/module.cpp f0e64f7c462cf833839558665fdb60d9f2cbc475
src/tests/module_tests.cpp a3271a3267647e0964dd3decb3ca8384417dd559
src/tests/no_executor_framework_test.sh aebdc8c380abb2d041d6fc74dfac5a111c15267e
src/tests/oversubscription_tests.cpp 7a75fb38e0177e33cf0e7cb82b4b9ebf8f05fe0a
src/tests/persistent_volume_framework_test.sh 84f02847a8d89400512d8a5714d33fb29cf5b03a
src/tests/script.cpp ee44fef29fb40e414d7507168091ee5cd0d15736
src/tests/slave_tests.cpp 076660daf025d6fd5065cd0c1930f17ecc5ca5aa
src/tests/test_framework_test.sh 409e80994f63448115ea8ac34b4fd5c6cf88aa22
src/tests/utils.hpp a6cca472f4dfab12cd6eccab6972206d842177aa
src/tests/utils.cpp 22bf3a85da5261fcfcc8b6aa9626aacdc8391ad4
Diff: https://reviews.apache.org/r/40553/diff/
Testing
-------
Thanks,
James Peach
Re: Review Request 40553: Enable mesos tests installation
Posted by James Peach <jp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40553/
-----------------------------------------------------------
(Updated Jan. 16, 2016, 5:53 a.m.)
Review request for mesos, Benjamin Bannier and Till Toenshoff.
Changes
-------
Rebase and build fix.
Summary (updated)
-----------------
Enable mesos tests installation
Bugs: MESOS-3608
https://issues.apache.org/jira/browse/MESOS-3608
Repository: mesos
Description (updated)
-------
This patch enables the installation mesos-tests and its dependencies
and helper tool. The goal is to allow operators to build a separate
test package that can be run at deployment time to verify that Mesos
works in the deployment environment.
Since the build directory is searched first, to run it on a host
that has a build tree, you need to specify a non-existent tree:
~ $ $PREFIX/libexec/mesos/tests/mesos-tests --build_dir=/none
- Add --enable-tests-install
- Fix mesos-tests gmock dependencies
- Optionally install tests, helpers and test modules
- Add utility helpers to find various test resources
Diffs (updated)
-----
Makefile.am fbd4e5a6356e90c867ba47c48c86fc9161ddd98e
configure.ac 40d60a63cdba41d06305f09141f4d14d6e229d95
src/Makefile.am d23e35001078a86775bd9b76baa207ecb9dab7e1
src/tests/balloon_framework_test.sh 25a19cfde87a3fd2d7d3e780700d342d08bd0a91
src/tests/containerizer/launch_tests.cpp c7ebe2606e4ff99ced90342dd16e0b4bf02bc504
src/tests/containerizer/memory_test_helper.cpp 4a3de2e3c887aa6afc604588850e1386f92d8c11
src/tests/containerizer/mesos_containerizer_tests.cpp 677fcc1c654f83ad3e60e0f6172a1a1e4a1045b1
src/tests/containerizer/ns_tests.cpp 603e54b7303c5aa15e2c5715dc7a2f7e7d39541b
src/tests/containerizer/port_mapping_tests.cpp fab16f697f90abc11d681222f10f518d70da908b
src/tests/environment.cpp 20218a086baefcefb310eb45ed9024e5425ce787
src/tests/event_call_framework_test.sh 9d1211552734afbf15b376f8c4629bae8a2065af
src/tests/fetcher_tests.cpp 1831d896ca8a52bec4adf87a67b6af845079796c
src/tests/health_check_tests.cpp 3606ce46bfa283ad0d5239fc25e02c5a9f8d1a53
src/tests/mesos.cpp 365ebe8335c37bfdb983a5424d4c995fa9b76a22
src/tests/module.cpp f0e64f7c462cf833839558665fdb60d9f2cbc475
src/tests/module_tests.cpp a3271a3267647e0964dd3decb3ca8384417dd559
src/tests/no_executor_framework_test.sh aebdc8c380abb2d041d6fc74dfac5a111c15267e
src/tests/oversubscription_tests.cpp 7a75fb38e0177e33cf0e7cb82b4b9ebf8f05fe0a
src/tests/persistent_volume_framework_test.sh 84f02847a8d89400512d8a5714d33fb29cf5b03a
src/tests/script.cpp ee44fef29fb40e414d7507168091ee5cd0d15736
src/tests/slave_tests.cpp 076660daf025d6fd5065cd0c1930f17ecc5ca5aa
src/tests/test_framework_test.sh 409e80994f63448115ea8ac34b4fd5c6cf88aa22
src/tests/utils.hpp a6cca472f4dfab12cd6eccab6972206d842177aa
src/tests/utils.cpp 22bf3a85da5261fcfcc8b6aa9626aacdc8391ad4
Diff: https://reviews.apache.org/r/40553/diff/
Testing
-------
Thanks,
James Peach
Re: Review Request 40553: Enable mesos tests installation.
Posted by James Peach <jp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40553/
-----------------------------------------------------------
(Updated Jan. 15, 2016, 8:17 p.m.)
Review request for mesos, Benjamin Bannier and Till Toenshoff.
Changes
-------
Updated.
Bugs: MESOS-3608
https://issues.apache.org/jira/browse/MESOS-3608
Repository: mesos
Description
-------
This patch enables the installation mesos-tests and its dependencies
and helper tool. The goal is to allow operators to build a separate
test package that can be run at deployment time to verify that Mesos
works in the deployment environment.
Since the build directory is searched first, to run it on a host
that has a build tree, you need to specify a non-existent tree:
~ $ $PREFIX/libexec/mesos/tests/mesos-tests --build_dir=/none
- Add --enable-tests-install
- Fix mesos-tests gmock dependencies
- Optionally install tests, helpers and test modules
- Add utility helpers to find various test resources
Current test status:
[==========] 784 tests from 106 test cases ran. (135304 ms total)
[ PASSED ] 780 tests.
[ FAILED ] 4 tests, listed below:
[ FAILED ] ExamplesTest.TestFramework
[ FAILED ] ExamplesTest.NoExecutorFramework
[ FAILED ] ExamplesTest.EventCallFramework
[ FAILED ] ExamplesTest.PersistentVolumeFramework
Diffs (updated)
-----
Makefile.am fbd4e5a6356e90c867ba47c48c86fc9161ddd98e
configure.ac 40d60a63cdba41d06305f09141f4d14d6e229d95
src/Makefile.am 8cbfb1ba5fa49f2d3cc26ea325838a1c68a79660
src/tests/balloon_framework_test.sh 25a19cfde87a3fd2d7d3e780700d342d08bd0a91
src/tests/containerizer/launch_tests.cpp c7ebe2606e4ff99ced90342dd16e0b4bf02bc504
src/tests/containerizer/memory_test_helper.cpp 4a3de2e3c887aa6afc604588850e1386f92d8c11
src/tests/containerizer/mesos_containerizer_tests.cpp 95b493c6f479eef52ee0c9a44ac40254ed76ebae
src/tests/containerizer/ns_tests.cpp 603e54b7303c5aa15e2c5715dc7a2f7e7d39541b
src/tests/containerizer/port_mapping_tests.cpp e3aea53468fa00374320a8b89bdbb64f38e44b01
src/tests/environment.cpp 20218a086baefcefb310eb45ed9024e5425ce787
src/tests/event_call_framework_test.sh 9d1211552734afbf15b376f8c4629bae8a2065af
src/tests/fetcher_tests.cpp 1831d896ca8a52bec4adf87a67b6af845079796c
src/tests/health_check_tests.cpp 26d05e7f7db9306c8b9164e2e7f843793c909e67
src/tests/mesos.cpp 365ebe8335c37bfdb983a5424d4c995fa9b76a22
src/tests/module.cpp f0e64f7c462cf833839558665fdb60d9f2cbc475
src/tests/module_tests.cpp a3271a3267647e0964dd3decb3ca8384417dd559
src/tests/no_executor_framework_test.sh aebdc8c380abb2d041d6fc74dfac5a111c15267e
src/tests/oversubscription_tests.cpp 7a75fb38e0177e33cf0e7cb82b4b9ebf8f05fe0a
src/tests/persistent_volume_framework_test.sh 84f02847a8d89400512d8a5714d33fb29cf5b03a
src/tests/script.cpp ee44fef29fb40e414d7507168091ee5cd0d15736
src/tests/slave_tests.cpp e4fb490a1d877547fe883c22dbc47bb4969ecef6
src/tests/test_framework_test.sh 409e80994f63448115ea8ac34b4fd5c6cf88aa22
src/tests/utils.hpp a6cca472f4dfab12cd6eccab6972206d842177aa
src/tests/utils.cpp 877139e97249761658dce3b1058cdc2e2a52367b
Diff: https://reviews.apache.org/r/40553/diff/
Testing
-------
Thanks,
James Peach
Re: Review Request 40553: Enable mesos tests installation.
Posted by James Peach <jp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40553/
-----------------------------------------------------------
(Updated Jan. 15, 2016, 6:44 p.m.)
Review request for mesos, Benjamin Bannier and Till Toenshoff.
Changes
-------
Updated with changes to make various test scripts work. Current status:
$ sudo /opt/mesos/libexec/mesos/tests/mesos-tests --build_dir=/none
...
[----------] Global test environment tear-down
/opt/home/src/mesos.git/src/tests/environment.cpp:565: Failure
Failed
Tests completed with child processes remaining:
-+- 5916 /opt/mesos/libexec/mesos/tests/mesos-tests --build_dir=/none
\--- 8246 /opt/mesos/libexec/mesos/tests/mesos-tests --build_dir=/none
[==========] 961 tests from 142 test cases ran. (317343 ms total)
[ PASSED ] 950 tests.
[ FAILED ] 11 tests, listed below:
[ FAILED ] ExamplesTest.TestFramework
[ FAILED ] ExamplesTest.EventCallFramework
[ FAILED ] MesosContainerizerSlaveRecoveryTest.CGROUPS_ROOT_PerfRollForward
[ FAILED ] PerfEventIsolatorTest.ROOT_CGROUPS_Sample
[ FAILED ] UserCgroupIsolatorTest/2.ROOT_CGROUPS_UserCgroup, where TypeParam = mesos::internal::slave::CgroupsPerfEventIsolatorProcess
[ FAILED ] CgroupsAnyHierarchyWithCpuMemoryTest.ROOT_CGROUPS_Listen
[ FAILED ] CgroupsAnyHierarchyWithPerfEventTest.ROOT_CGROUPS_Perf
[ FAILED ] CgroupsAnyHierarchyMemoryPressureTest.ROOT_IncreaseRSS
[ FAILED ] CgroupsAnyHierarchyMemoryPressureTest.ROOT_IncreasePageCache
[ FAILED ] MemoryPressureMesosTest.CGROUPS_ROOT_Statistics
[ FAILED ] MemoryPressureMesosTest.CGROUPS_ROOT_SlaveRecovery
11 FAILED TESTS
YOU HAVE 9 DISABLED TESTS
Bugs: MESOS-3608
https://issues.apache.org/jira/browse/MESOS-3608
Repository: mesos
Description
-------
This patch enables the installation mesos-tests and its dependencies
and helper tool. The goal is to allow operators to build a separate
test package that can be run at deployment time to verify that Mesos
works in the deployment environment.
Since the build directory is searched first, to run it on a host
that has a build tree, you need to specify a non-existent tree:
~ $ $PREFIX/libexec/mesos/tests/mesos-tests --build_dir=/none
- Add --enable-tests-install
- Fix mesos-tests gmock dependencies
- Optionally install tests, helpers and test modules
- Add utility helpers to find various test resources
Current test status:
[==========] 784 tests from 106 test cases ran. (135304 ms total)
[ PASSED ] 780 tests.
[ FAILED ] 4 tests, listed below:
[ FAILED ] ExamplesTest.TestFramework
[ FAILED ] ExamplesTest.NoExecutorFramework
[ FAILED ] ExamplesTest.EventCallFramework
[ FAILED ] ExamplesTest.PersistentVolumeFramework
Diffs (updated)
-----
Makefile.am fbd4e5a6356e90c867ba47c48c86fc9161ddd98e
configure.ac 40d60a63cdba41d06305f09141f4d14d6e229d95
src/Makefile.am 8cbfb1ba5fa49f2d3cc26ea325838a1c68a79660
src/tests/balloon_framework_test.sh 25a19cfde87a3fd2d7d3e780700d342d08bd0a91
src/tests/containerizer/launch_tests.cpp c7ebe2606e4ff99ced90342dd16e0b4bf02bc504
src/tests/containerizer/memory_test_helper.cpp 4a3de2e3c887aa6afc604588850e1386f92d8c11
src/tests/containerizer/mesos_containerizer_tests.cpp 95b493c6f479eef52ee0c9a44ac40254ed76ebae
src/tests/containerizer/ns_tests.cpp 603e54b7303c5aa15e2c5715dc7a2f7e7d39541b
src/tests/containerizer/port_mapping_tests.cpp e3aea53468fa00374320a8b89bdbb64f38e44b01
src/tests/environment.cpp 20218a086baefcefb310eb45ed9024e5425ce787
src/tests/event_call_framework_test.sh 9d1211552734afbf15b376f8c4629bae8a2065af
src/tests/fetcher_tests.cpp 1831d896ca8a52bec4adf87a67b6af845079796c
src/tests/health_check_tests.cpp 26d05e7f7db9306c8b9164e2e7f843793c909e67
src/tests/mesos.cpp 365ebe8335c37bfdb983a5424d4c995fa9b76a22
src/tests/module.cpp f0e64f7c462cf833839558665fdb60d9f2cbc475
src/tests/module_tests.cpp a3271a3267647e0964dd3decb3ca8384417dd559
src/tests/no_executor_framework_test.sh aebdc8c380abb2d041d6fc74dfac5a111c15267e
src/tests/oversubscription_tests.cpp 7a75fb38e0177e33cf0e7cb82b4b9ebf8f05fe0a
src/tests/persistent_volume_framework_test.sh 84f02847a8d89400512d8a5714d33fb29cf5b03a
src/tests/script.cpp ee44fef29fb40e414d7507168091ee5cd0d15736
src/tests/slave_tests.cpp e4fb490a1d877547fe883c22dbc47bb4969ecef6
src/tests/test_framework_test.sh 409e80994f63448115ea8ac34b4fd5c6cf88aa22
src/tests/utils.hpp a6cca472f4dfab12cd6eccab6972206d842177aa
src/tests/utils.cpp 877139e97249761658dce3b1058cdc2e2a52367b
Diff: https://reviews.apache.org/r/40553/diff/
Testing
-------
Thanks,
James Peach
Re: Review Request 40553: Enable mesos tests installation.
Posted by James Peach <jp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40553/
-----------------------------------------------------------
(Updated Jan. 13, 2016, 4:06 a.m.)
Review request for mesos, Benjamin Bannier and Till Toenshoff.
Summary (updated)
-----------------
Enable mesos tests installation.
Bugs: MESOS-3608
https://issues.apache.org/jira/browse/MESOS-3608
Repository: mesos
Description
-------
This patch enables the installation mesos-tests and its dependencies
and helper tool. The goal is to allow operators to build a separate
test package that can be run at deployment time to verify that Mesos
works in the deployment environment.
Since the build directory is searched first, to run it on a host
that has a build tree, you need to specify a non-existent tree:
~ $ $PREFIX/libexec/mesos/tests/mesos-tests --build_dir=/none
- Add --enable-tests-install
- Fix mesos-tests gmock dependencies
- Optionally install tests, helpers and test modules
- Add utility helpers to find various test resources
Current test status:
[==========] 784 tests from 106 test cases ran. (135304 ms total)
[ PASSED ] 780 tests.
[ FAILED ] 4 tests, listed below:
[ FAILED ] ExamplesTest.TestFramework
[ FAILED ] ExamplesTest.NoExecutorFramework
[ FAILED ] ExamplesTest.EventCallFramework
[ FAILED ] ExamplesTest.PersistentVolumeFramework
Diffs
-----
configure.ac 40d60a63cdba41d06305f09141f4d14d6e229d95
src/Makefile.am 8cbfb1ba5fa49f2d3cc26ea325838a1c68a79660
src/tests/containerizer/launch_tests.cpp c7ebe2606e4ff99ced90342dd16e0b4bf02bc504
src/tests/containerizer/memory_test_helper.cpp 4a3de2e3c887aa6afc604588850e1386f92d8c11
src/tests/containerizer/mesos_containerizer_tests.cpp 95b493c6f479eef52ee0c9a44ac40254ed76ebae
src/tests/containerizer/ns_tests.cpp 603e54b7303c5aa15e2c5715dc7a2f7e7d39541b
src/tests/containerizer/port_mapping_tests.cpp e3aea53468fa00374320a8b89bdbb64f38e44b01
src/tests/environment.cpp 20218a086baefcefb310eb45ed9024e5425ce787
src/tests/fetcher_tests.cpp 1831d896ca8a52bec4adf87a67b6af845079796c
src/tests/health_check_tests.cpp 26d05e7f7db9306c8b9164e2e7f843793c909e67
src/tests/mesos.cpp 365ebe8335c37bfdb983a5424d4c995fa9b76a22
src/tests/module.cpp f0e64f7c462cf833839558665fdb60d9f2cbc475
src/tests/module_tests.cpp a3271a3267647e0964dd3decb3ca8384417dd559
src/tests/oversubscription_tests.cpp 7a75fb38e0177e33cf0e7cb82b4b9ebf8f05fe0a
src/tests/script.cpp ee44fef29fb40e414d7507168091ee5cd0d15736
src/tests/slave_tests.cpp e4fb490a1d877547fe883c22dbc47bb4969ecef6
src/tests/utils.hpp a6cca472f4dfab12cd6eccab6972206d842177aa
src/tests/utils.cpp 877139e97249761658dce3b1058cdc2e2a52367b
Diff: https://reviews.apache.org/r/40553/diff/
Testing
-------
Thanks,
James Peach