[GitHub] [beam] kennknowles commented on a change in pull request #13006: [WIP][BEAM-10670] Make Read use SDF by default. Override in runners.

[GitBox <gi...@apache.org>]

kennknowles commented on a change in pull request #13006:
URL: https://github.com/apache/beam/pull/13006#discussion_r499088094



##########
File path: runners/samza/src/main/java/org/apache/beam/runners/samza/SamzaRunner.java
##########
@@ -107,7 +107,7 @@ public PortablePipelineResult runPortablePipeline(RunnerApi.Pipeline pipeline) {
 
   @Override
   public SamzaPipelineResult run(Pipeline pipeline) {
-    SplittableParDo.validateNoPrimitiveReads(pipeline);
+    SplittableParDo.convertReadBasedSplittableDoFnsToPrimitiveReadsIfNecessary(pipeline);

Review comment:
       To clarify: this change makes it so instead of rejecting primitive reads the function is a noop?

##########
File path: runners/samza/src/main/java/org/apache/beam/runners/samza/translation/ReadTranslator.java
##########
@@ -54,9 +54,9 @@ public void translate(
     final PCollection<T> output = ctx.getOutput(transform);
     final Coder<WindowedValue<T>> coder = SamzaCoders.of(output);
     final Source<?> source =
-        transform instanceof Read.Unbounded
-            ? ((Read.Unbounded) transform).getSource()
-            : ((Read.Bounded) transform).getSource();
+        transform instanceof SplittableParDo.PrimitiveBoundedRead

Review comment:
       I was trying to figure out where the failure came from and I would assume here but I don't understand why.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org