You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2021/05/14 08:14:24 UTC

[GitHub] [activemq-artemis] andytaylor opened a new pull request #3581: ARTEMIS-3295 - do not cluster advisories

andytaylor opened a new pull request #3581:
URL: https://github.com/apache/activemq-artemis/pull/3581


   https://issues.apache.org/jira/browse/ARTEMIS-3295


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [activemq-artemis] clebertsuconic commented on pull request #3581: ARTEMIS-3295 - do not cluster advisories

Posted by GitBox <gi...@apache.org>.
clebertsuconic commented on pull request #3581:
URL: https://github.com/apache/activemq-artemis/pull/3581#issuecomment-841234165


   superseded by #3582 
   
   I did a small tweak to the code instead of asking you to do it.. 
   @andytaylor you're still the author of the commit.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [activemq-artemis] clebertsuconic closed pull request #3581: ARTEMIS-3295 - do not cluster advisories

Posted by GitBox <gi...@apache.org>.
clebertsuconic closed pull request #3581:
URL: https://github.com/apache/activemq-artemis/pull/3581


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [activemq-artemis] clebertsuconic commented on pull request #3581: ARTEMIS-3295 - do not cluster advisories

Posted by GitBox <gi...@apache.org>.
clebertsuconic commented on pull request #3581:
URL: https://github.com/apache/activemq-artemis/pull/3581#issuecomment-841219815


   I am sending a small tweak into this.
   
   Instead of passing the List as a reference everywhere, it would be simpler to just read from ClusterManager.
   
   The list is passed as a reference and if you change the source you also change on the passed reference. I think it could eventually be confusing. Instead I am just adding a getter on ClusterManager and reading from the source every time is needed.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org