You are viewing a plain text version of this content. The canonical link for it is here.
Posted to java-dev@axis.apache.org by ax...@ws.apache.org on 2004/07/23 21:32:17 UTC

[jira] Created: (AXIS-1473) Type mappings for attribute groups are added to deploy.wsdd while they should be skipped

Message:

  A new issue has been created in JIRA.

---------------------------------------------------------------------
View the issue:
  http://issues.apache.org/jira/browse/AXIS-1473

Here is an overview of the issue:
---------------------------------------------------------------------
        Key: AXIS-1473
    Summary: Type mappings for attribute groups are added to deploy.wsdd while they should be skipped
       Type: Bug

     Status: Unassigned
   Priority: Major

    Project: Axis
 Components: 
             Deployment / Registries
   Versions:
             1.2 Beta

   Assignee: 
   Reporter: Max Kuperman

    Created: Fri, 23 Jul 2004 12:31 PM
    Updated: Fri, 23 Jul 2004 12:31 PM
Environment: Windows XP professional, SP1, Tomcat 5.0.19, Axis Beta 1.2

Description:
Attribute groups are added to deploy.wsdd during Java code generation in WSDL2Java. This behavior causes deployment errors since Java types are not generated for attribute groups.
The problem is in JavaDeployWriter.java, method writeDeployTypes:
code which is supposed to skip attribute groups population was not copied from JavaStubWriter.java.

>>> Original code

// 1) Don't register types that are base (primitive) types.
// If the baseType != null && getRefType() != null this
// is a simpleType that must be registered.
// 2) Don't register the special types for collections
// (indexed properties) or element types
// 3) Don't register types that are not referenced
// or only referenced in a literal context.
if (((type.getBaseType() != null) && (type.getRefType() == null))
    || (type instanceof CollectionTE)
    || (type instanceof Element) || !type.isReferenced()
    || type.isOnlyLiteralReferenced()) {
  process = false;
}

>>> Fixed code

// 1) Don't register types that are base (primitive) types or attributeGroups.
// If the baseType != null && getRefType() != null this
// is a simpleType that must be registered.
// 2) Don't register the special types for collections
// (indexed properties) or elements
// 3) Don't register types that are not referenced
// or only referenced in a literal context.
if (((type.getBaseType() != null) && (type.getRefType() == null))
    || (type instanceof CollectionTE)
    || (type instanceof Element) || !type.isReferenced()
    || type.isOnlyLiteralReferenced()
    || ((type.getNode() != null)
    && type.getNode().getLocalName().equals(
      "attributeGroup"))) {
  process = false;
}



---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.

If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa

If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira

[jira] Commented: (AXIS-1473) Type mappings for attribute groups are added to deploy.wsdd while they should be skipped

Posted by ax...@ws.apache.org.
The following comment has been added to this issue:

     Author: Tom Jordahl
    Created: Thu, 29 Jul 2004 3:57 PM
       Body:
I can't find this code because is has already (correctly) been refactored in to toJava.Utils:shouldEmit().

Please try again with the latest CVS - Thanks!

---------------------------------------------------------------------
View this comment:
  http://issues.apache.org/jira/browse/AXIS-1473?page=comments#action_36947

---------------------------------------------------------------------
View the issue:
  http://issues.apache.org/jira/browse/AXIS-1473

Here is an overview of the issue:
---------------------------------------------------------------------
        Key: AXIS-1473
    Summary: Type mappings for attribute groups are added to deploy.wsdd while they should be skipped
       Type: Bug

     Status: Unassigned
   Priority: Major

    Project: Axis
 Components: 
             Deployment / Registries
   Versions:
             1.2 Beta

   Assignee: 
   Reporter: Max Kuperman

    Created: Fri, 23 Jul 2004 12:31 PM
    Updated: Thu, 29 Jul 2004 3:57 PM
Environment: Windows XP professional, SP1, Tomcat 5.0.19, Axis Beta 1.2

Description:
Attribute groups are added to deploy.wsdd during Java code generation in WSDL2Java. This behavior causes deployment errors since Java types are not generated for attribute groups.
The problem is in JavaDeployWriter.java, method writeDeployTypes:
code which is supposed to skip attribute groups population was not copied from JavaStubWriter.java.

>>> Original code

// 1) Don't register types that are base (primitive) types.
// If the baseType != null && getRefType() != null this
// is a simpleType that must be registered.
// 2) Don't register the special types for collections
// (indexed properties) or element types
// 3) Don't register types that are not referenced
// or only referenced in a literal context.
if (((type.getBaseType() != null) && (type.getRefType() == null))
    || (type instanceof CollectionTE)
    || (type instanceof Element) || !type.isReferenced()
    || type.isOnlyLiteralReferenced()) {
  process = false;
}

>>> Fixed code

// 1) Don't register types that are base (primitive) types or attributeGroups.
// If the baseType != null && getRefType() != null this
// is a simpleType that must be registered.
// 2) Don't register the special types for collections
// (indexed properties) or elements
// 3) Don't register types that are not referenced
// or only referenced in a literal context.
if (((type.getBaseType() != null) && (type.getRefType() == null))
    || (type instanceof CollectionTE)
    || (type instanceof Element) || !type.isReferenced()
    || type.isOnlyLiteralReferenced()
    || ((type.getNode() != null)
    && type.getNode().getLocalName().equals(
      "attributeGroup"))) {
  process = false;
}



---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.

If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa

If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira

[jira] Resolved: (AXIS-1473) Type mappings for attribute groups are added to deploy.wsdd while they should be skipped

Posted by ax...@ws.apache.org.
Message:

   The following issue has been resolved as FIXED.

   Resolver: Tom Jordahl
       Date: Thu, 29 Jul 2004 3:58 PM

Already fixed in latest CVS.
---------------------------------------------------------------------
View the issue:
  http://issues.apache.org/jira/browse/AXIS-1473

Here is an overview of the issue:
---------------------------------------------------------------------
        Key: AXIS-1473
    Summary: Type mappings for attribute groups are added to deploy.wsdd while they should be skipped
       Type: Bug

     Status: Resolved
   Priority: Major
 Resolution: FIXED

    Project: Axis
 Components: 
             Deployment / Registries
   Fix Fors:
             beta-3
   Versions:
             1.2 Beta

   Assignee: 
   Reporter: Max Kuperman

    Created: Fri, 23 Jul 2004 12:31 PM
    Updated: Thu, 29 Jul 2004 3:58 PM
Environment: Windows XP professional, SP1, Tomcat 5.0.19, Axis Beta 1.2

Description:
Attribute groups are added to deploy.wsdd during Java code generation in WSDL2Java. This behavior causes deployment errors since Java types are not generated for attribute groups.
The problem is in JavaDeployWriter.java, method writeDeployTypes:
code which is supposed to skip attribute groups population was not copied from JavaStubWriter.java.

>>> Original code

// 1) Don't register types that are base (primitive) types.
// If the baseType != null && getRefType() != null this
// is a simpleType that must be registered.
// 2) Don't register the special types for collections
// (indexed properties) or element types
// 3) Don't register types that are not referenced
// or only referenced in a literal context.
if (((type.getBaseType() != null) && (type.getRefType() == null))
    || (type instanceof CollectionTE)
    || (type instanceof Element) || !type.isReferenced()
    || type.isOnlyLiteralReferenced()) {
  process = false;
}

>>> Fixed code

// 1) Don't register types that are base (primitive) types or attributeGroups.
// If the baseType != null && getRefType() != null this
// is a simpleType that must be registered.
// 2) Don't register the special types for collections
// (indexed properties) or elements
// 3) Don't register types that are not referenced
// or only referenced in a literal context.
if (((type.getBaseType() != null) && (type.getRefType() == null))
    || (type instanceof CollectionTE)
    || (type instanceof Element) || !type.isReferenced()
    || type.isOnlyLiteralReferenced()
    || ((type.getNode() != null)
    && type.getNode().getLocalName().equals(
      "attributeGroup"))) {
  process = false;
}



---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.

If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa

If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira

[jira] Commented: (AXIS-1473) Type mappings for attribute groups are added to deploy.wsdd while they should be skipped

Posted by ax...@ws.apache.org.
The following comment has been added to this issue:

     Author: Tom Jordahl
    Created: Thu, 29 Jul 2004 3:53 PM
       Body:
I don't see where in JavaStubWrite this check is being made.  Can you point out a line number in the current CVS version?

Also, do you have a test WSDL for this?  Or better yet, can you modify a existing WSDL test to include attribute groups?

Thanks.

---------------------------------------------------------------------
View this comment:
  http://issues.apache.org/jira/browse/AXIS-1473?page=comments#action_36946

---------------------------------------------------------------------
View the issue:
  http://issues.apache.org/jira/browse/AXIS-1473

Here is an overview of the issue:
---------------------------------------------------------------------
        Key: AXIS-1473
    Summary: Type mappings for attribute groups are added to deploy.wsdd while they should be skipped
       Type: Bug

     Status: Unassigned
   Priority: Major

    Project: Axis
 Components: 
             Deployment / Registries
   Versions:
             1.2 Beta

   Assignee: 
   Reporter: Max Kuperman

    Created: Fri, 23 Jul 2004 12:31 PM
    Updated: Thu, 29 Jul 2004 3:53 PM
Environment: Windows XP professional, SP1, Tomcat 5.0.19, Axis Beta 1.2

Description:
Attribute groups are added to deploy.wsdd during Java code generation in WSDL2Java. This behavior causes deployment errors since Java types are not generated for attribute groups.
The problem is in JavaDeployWriter.java, method writeDeployTypes:
code which is supposed to skip attribute groups population was not copied from JavaStubWriter.java.

>>> Original code

// 1) Don't register types that are base (primitive) types.
// If the baseType != null && getRefType() != null this
// is a simpleType that must be registered.
// 2) Don't register the special types for collections
// (indexed properties) or element types
// 3) Don't register types that are not referenced
// or only referenced in a literal context.
if (((type.getBaseType() != null) && (type.getRefType() == null))
    || (type instanceof CollectionTE)
    || (type instanceof Element) || !type.isReferenced()
    || type.isOnlyLiteralReferenced()) {
  process = false;
}

>>> Fixed code

// 1) Don't register types that are base (primitive) types or attributeGroups.
// If the baseType != null && getRefType() != null this
// is a simpleType that must be registered.
// 2) Don't register the special types for collections
// (indexed properties) or elements
// 3) Don't register types that are not referenced
// or only referenced in a literal context.
if (((type.getBaseType() != null) && (type.getRefType() == null))
    || (type instanceof CollectionTE)
    || (type instanceof Element) || !type.isReferenced()
    || type.isOnlyLiteralReferenced()
    || ((type.getNode() != null)
    && type.getNode().getLocalName().equals(
      "attributeGroup"))) {
  process = false;
}



---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.

If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa

If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira