[GitHub] [ozone] jojochuang commented on a diff in pull request #5043: HDDS-8310. Recon goes down with RepeatedOmKeyInfo cannot be cast to OmKeyInfo

["jojochuang (via GitHub)" <gi...@apache.org>]

jojochuang commented on code in PR #5043:
URL: https://github.com/apache/ozone/pull/5043#discussion_r1261379582


##########
hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/tasks/OmUpdateEventValidator.java:
##########
@@ -0,0 +1,81 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ * <p>
+ * http://www.apache.org/licenses/LICENSE-2.0
+ * <p>
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.ozone.recon.tasks;
+
+import org.apache.hadoop.ozone.om.codec.OMDBDefinition;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.io.IOException;
+
+/**
+ * OmUpdateEventValidator is a utility class for validating OMDBUpdateEvents
+ * It can be further extended to different types of validations.
+ */
+public class OmUpdateEventValidator {
+
+  private static final Logger LOG =
+      LoggerFactory.getLogger(OmUpdateEventValidator.class);
+  private OMDBDefinition omdbDefinition;
+
+  public OmUpdateEventValidator(OMDBDefinition omdbDefinition) {
+    this.omdbDefinition = omdbDefinition;
+  }
+
+  /**
+   * Validates the OMDBUpdateEvent based on the expected value type for a
+   * given table.
+   *
+   * @param tableName        the name of the table associated with the event.
+   * @param actualValueType  the actual value type of the event.
+   * @param keyType          the key type of the event.
+   * @param action           the action performed on the event.
+   * @return true if the event is valid, false otherwise.
+   * @throws IOException if an I/O error occurs during the validation.
+   */
+  public boolean isValidEvent(String tableName,
+                              Object actualValueType,
+                              Object keyType,
+                              OMDBUpdateEvent.OMDBUpdateAction action)
+      throws IOException {
+    Object expectedValueType = omdbDefinition.getColumnFamily(tableName)
+        .getValueType();
+    // Check if both objects are of the same type
+    if (expectedValueType.getClass().equals(actualValueType.getClass())) {
+      // Both objects are of the same type
+      return true;
+    } else {
+      // Objects are not of the same type
+      logError(keyType.toString(), tableName, action.toString(),
+          expectedValueType.getClass().getName(),
+          actualValueType.getClass().getName());
+      return false;
+    }
+  }
+
+  private void logError(String keyType, String tableName, String action,
+                        String expectedValueType, String actualValueType) {
+    String errorMessage = String.format(
+        "Validation failed for keyType: %s, tableName: %s, action: %s, " +
+            "Expected value type: %s, Actual value type: %s",
+        keyType, tableName, action, expectedValueType, actualValueType);
+    // Log the error message as an ERROR level log
+    LOG.error(errorMessage);

Review Comment:
   nit: this is a WARN level log since the system continues to function after skipping the problem.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org