[GitHub] [spark] caican00 commented on a diff in pull request #41993: [SPARK-44414][SQL] Fixed matching check for CharType/VarcharType

["caican00 (via GitHub)" <gi...@apache.org>]

caican00 commented on code in PR #41993:
URL: https://github.com/apache/spark/pull/41993#discussion_r1263279866


##########
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/V2WriteAnalysisSuite.scala:
##########
@@ -744,6 +744,46 @@ abstract class V2WriteAnalysisSuiteBase extends AnalysisTest {
     }
   }
 
+  test ("SPARK-44414: Fixed matching check for CharType/VarcharType") {
+    // check varchar type
+    val json1 = "{\"__CHAR_VARCHAR_TYPE_STRING\":\"varchar(80)\"}"

Review Comment:
   > Consider using `Seq("{\"__CHAR_VARCHAR_TYPE_STRING\":\"char(80)\"}", "{\"__CHAR_VARCHAR_TYPE_STRING\":\"varchar(80)\"}").foreach { ... ` to minimize duplicates?
   
   updated. Thanks for reviewing @yaooqinn 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org