You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "codecov-commenter (via GitHub)" <gi...@apache.org> on 2023/06/30 01:41:48 UTC

[GitHub] [pulsar] codecov-commenter commented on pull request #20537: [feat][broker]PIP-255 Part-2: Make the partition assignment strategy pluggable

codecov-commenter commented on PR #20537:
URL: https://github.com/apache/pulsar/pull/20537#issuecomment-1613999091

   ## [Codecov](https://app.codecov.io/gh/apache/pulsar/pull/20537?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   > Merging [#20537](https://app.codecov.io/gh/apache/pulsar/pull/20537?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (1a278e0) into [master](https://app.codecov.io/gh/apache/pulsar/commit/0e603405c2a6faaa50a47881916a2c1268de9830?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (0e60340) will **increase** coverage by `0.51%`.
   > The diff coverage is `80.64%`.
   
   [![Impacted file tree graph](https://app.codecov.io/gh/apache/pulsar/pull/20537/graphs/tree.svg?width=650&height=150&src=pr&token=acYqCpsK9J&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)](https://app.codecov.io/gh/apache/pulsar/pull/20537?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #20537      +/-   ##
   ============================================
   + Coverage     72.60%   73.12%   +0.51%     
   - Complexity    32018    32053      +35     
   ============================================
     Files          1855     1869      +14     
     Lines        138569   138783     +214     
     Branches      15250    15264      +14     
   ============================================
   + Hits         100605   101481     +876     
   + Misses        29945    29266     -679     
   - Partials       8019     8036      +17     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | inttests | `24.18% <70.96%> (+0.07%)` | :arrow_up: |
   | systests | `25.00% <70.96%> (?)` | |
   | unittests | `72.39% <80.64%> (+0.03%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://app.codecov.io/gh/apache/pulsar/pull/20537?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [...ar/common/naming/TopicBundleAssignmentFactory.java](https://app.codecov.io/gh/apache/pulsar/pull/20537?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2NvbW1vbi9uYW1pbmcvVG9waWNCdW5kbGVBc3NpZ25tZW50RmFjdG9yeS5qYXZh) | `66.66% <66.66%> (ø)` | |
   | [...org/apache/pulsar/broker/ServiceConfiguration.java](https://app.codecov.io/gh/apache/pulsar/pull/20537?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cHVsc2FyLWJyb2tlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3B1bHNhci9icm9rZXIvU2VydmljZUNvbmZpZ3VyYXRpb24uamF2YQ==) | `99.38% <100.00%> (+<0.01%)` | :arrow_up: |
   | [...n/naming/ConsistentHashingTopicBundleAssigner.java](https://app.codecov.io/gh/apache/pulsar/pull/20537?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2NvbW1vbi9uYW1pbmcvQ29uc2lzdGVudEhhc2hpbmdUb3BpY0J1bmRsZUFzc2lnbmVyLmphdmE=) | `100.00% <100.00%> (ø)` | |
   | [...e/pulsar/common/naming/NamespaceBundleFactory.java](https://app.codecov.io/gh/apache/pulsar/pull/20537?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2NvbW1vbi9uYW1pbmcvTmFtZXNwYWNlQnVuZGxlRmFjdG9yeS5qYXZh) | `80.87% <100.00%> (+4.07%)` | :arrow_up: |
   | [.../apache/pulsar/common/naming/NamespaceBundles.java](https://app.codecov.io/gh/apache/pulsar/pull/20537?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2NvbW1vbi9uYW1pbmcvTmFtZXNwYWNlQnVuZGxlcy5qYXZh) | `79.74% <100.00%> (-0.98%)` | :arrow_down: |
   
   ... and [155 files with indirect coverage changes](https://app.codecov.io/gh/apache/pulsar/pull/20537/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org