You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2015/09/16 16:39:46 UTC
[jira] [Commented] (CB-9598) Factor out shared logic to
cordova-common module and publish it separately.
[ https://issues.apache.org/jira/browse/CB-9598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14769036#comment-14769036 ]
ASF GitHub Bot commented on CB-9598:
------------------------------------
GitHub user vladimir-kotikov opened a pull request:
https://github.com/apache/cordova-coho/pull/94
CB-9598 Adds support for cordova-common module
This is a support PR to simplify installation and setup for cordova-common: https://github.com/apache/cordova-lib/pull/309
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-coho CB-9598
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-coho/pull/94.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #94
----
commit e0206c445e1b38c3f817544af96793ec0d30c804
Author: Vladimir Kotikov <v-...@microsoft.com>
Date: 2015-08-25T14:19:29Z
CB-9598 Adds support for cordova-common module
----
> Factor out shared logic to cordova-common module and publish it separately.
> ---------------------------------------------------------------------------
>
> Key: CB-9598
> URL: https://issues.apache.org/jira/browse/CB-9598
> Project: Apache Cordova
> Issue Type: Sub-task
> Components: CordovaCommon, CordovaLib
> Reporter: Vladimir Kotikov
> Assignee: Vladimir Kotikov
>
> There also a potential problem of code duplication, since the PlatformApi needs for several classes, which currently being stored and exposed by cordova-lib: ConfigParser, PluginInfo, etc. The one of solutions of this problem - is to factor out the common classes and routines to shared module (proposed name - cordova-common), which then will be released separately. This approach is discussed in cordova-lib/#235
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org