You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Tim Armstrong (Code Review)" <ge...@cloudera.org> on 2020/08/25 00:16:16 UTC
[Impala-ASF-CR] IMPALA-10103: upgrade jquery to 3.5.1
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16355
Change subject: IMPALA-10103: upgrade jquery to 3.5.1
......................................................................
IMPALA-10103: upgrade jquery to 3.5.1
Testing:
Manually clicked through most of the web UI pages
and interacted with data tables, etc.
Change-Id: Icf0445163a6bf15c56de0c6ca10798e09e0a4fcb
---
M .gitattributes
M bin/rat_exclude_files.txt
M www/common-header.tmpl
D www/jquery/jquery-3.4.1.min.js
4 files changed, 4 insertions(+), 6 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/55/16355/1
--
To view, visit http://gerrit.cloudera.org:8080/16355
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Icf0445163a6bf15c56de0c6ca10798e09e0a4fcb
Gerrit-Change-Number: 16355
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-10103: upgrade jquery to 3.5.1
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16355 )
Change subject: IMPALA-10103: upgrade jquery to 3.5.1
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/6988/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/16355
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icf0445163a6bf15c56de0c6ca10798e09e0a4fcb
Gerrit-Change-Number: 16355
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 25 Aug 2020 16:01:55 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10103: upgrade jquery to 3.5.1
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16355 )
Change subject: IMPALA-10103: upgrade jquery to 3.5.1
......................................................................
Patch Set 3:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/6325/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/16355
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icf0445163a6bf15c56de0c6ca10798e09e0a4fcb
Gerrit-Change-Number: 16355
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 25 Aug 2020 16:11:53 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10103: upgrade jquery to 3.5.1
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16355 )
Change subject: IMPALA-10103: upgrade jquery to 3.5.1
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/16355
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icf0445163a6bf15c56de0c6ca10798e09e0a4fcb
Gerrit-Change-Number: 16355
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 25 Aug 2020 16:11:52 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10103: upgrade jquery to 3.5.1
Posted by "Bikramjeet Vig (Code Review)" <ge...@cloudera.org>.
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/16355 )
Change subject: IMPALA-10103: upgrade jquery to 3.5.1
......................................................................
Patch Set 1:
did you forget to add jquery-3.5.1.min.js?
--
To view, visit http://gerrit.cloudera.org:8080/16355
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icf0445163a6bf15c56de0c6ca10798e09e0a4fcb
Gerrit-Change-Number: 16355
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 25 Aug 2020 01:02:38 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10103: upgrade jquery to 3.5.1
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16355 )
Change subject: IMPALA-10103: upgrade jquery to 3.5.1
......................................................................
Patch Set 1:
Oops, thanks for pointing that out.
--
To view, visit http://gerrit.cloudera.org:8080/16355
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icf0445163a6bf15c56de0c6ca10798e09e0a4fcb
Gerrit-Change-Number: 16355
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 25 Aug 2020 15:40:47 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10103: upgrade jquery to 3.5.1
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16355 )
Change subject: IMPALA-10103: upgrade jquery to 3.5.1
......................................................................
Patch Set 3: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/16355
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icf0445163a6bf15c56de0c6ca10798e09e0a4fcb
Gerrit-Change-Number: 16355
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 25 Aug 2020 21:22:14 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10103: upgrade jquery to 3.5.1
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16355 )
Change subject: IMPALA-10103: upgrade jquery to 3.5.1
......................................................................
IMPALA-10103: upgrade jquery to 3.5.1
Testing:
Manually clicked through most of the web UI pages
and interacted with data tables, etc.
Change-Id: Icf0445163a6bf15c56de0c6ca10798e09e0a4fcb
Reviewed-on: http://gerrit.cloudera.org:8080/16355
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M .gitattributes
M bin/rat_exclude_files.txt
M www/common-header.tmpl
D www/jquery/jquery-3.4.1.min.js
A www/jquery/jquery-3.5.1.min.js
5 files changed, 6 insertions(+), 6 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/16355
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Icf0445163a6bf15c56de0c6ca10798e09e0a4fcb
Gerrit-Change-Number: 16355
Gerrit-PatchSet: 4
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-10103: upgrade jquery to 3.5.1
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Hello Bikramjeet Vig, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/16355
to look at the new patch set (#2).
Change subject: IMPALA-10103: upgrade jquery to 3.5.1
......................................................................
IMPALA-10103: upgrade jquery to 3.5.1
Testing:
Manually clicked through most of the web UI pages
and interacted with data tables, etc.
Change-Id: Icf0445163a6bf15c56de0c6ca10798e09e0a4fcb
---
M .gitattributes
M bin/rat_exclude_files.txt
M www/common-header.tmpl
D www/jquery/jquery-3.4.1.min.js
A www/jquery/jquery-3.5.1.min.js
5 files changed, 6 insertions(+), 6 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/55/16355/2
--
To view, visit http://gerrit.cloudera.org:8080/16355
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Icf0445163a6bf15c56de0c6ca10798e09e0a4fcb
Gerrit-Change-Number: 16355
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-10103: upgrade jquery to 3.5.1
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16355 )
Change subject: IMPALA-10103: upgrade jquery to 3.5.1
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/6974/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/16355
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icf0445163a6bf15c56de0c6ca10798e09e0a4fcb
Gerrit-Change-Number: 16355
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 25 Aug 2020 00:36:44 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10103: upgrade jquery to 3.5.1
Posted by "Bikramjeet Vig (Code Review)" <ge...@cloudera.org>.
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/16355 )
Change subject: IMPALA-10103: upgrade jquery to 3.5.1
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/16355
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icf0445163a6bf15c56de0c6ca10798e09e0a4fcb
Gerrit-Change-Number: 16355
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 25 Aug 2020 16:02:29 +0000
Gerrit-HasComments: No