You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2021/06/08 17:37:54 UTC
[kudu-CR](branch-1.15.x) [test] make new scenario in security-itest more robust
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17562
Change subject: [test] make new scenario in security-itest more robust
......................................................................
[test] make new scenario in security-itest more robust
This patch makes the newly introduced test scenario
SecurityITest.TxnSmokeWithDifferentUserTypes more robust and stable.
With awaiting for the first transaction to finalize, now there is no
risk for aborting the second transaction in case of a race.
Before this patch, if it took a long time to finalize aborting the
former transaction, the deadlock prevention logic would automatically
abort the latter one, failing the test scenario.
Before this fix, 1/4 (one if four) of runs failed if running with
--stress_cpu_threads=16. With this fix, I didn't see a failure
in hundreds of runs.
Change-Id: Ie99ad41a7a161f9046ba894c072eb92150f0e0e2
Reviewed-on: http://gerrit.cloudera.org:8080/17559
Tested-by: Kudu Jenkins
Reviewed-by: Andrew Wong <aw...@cloudera.com>
(cherry picked from commit 598304262439fed0819169d6b1a6bc56020a5eea)
---
M src/kudu/integration-tests/security-itest.cc
1 file changed, 14 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/62/17562/1
--
To view, visit http://gerrit.cloudera.org:8080/17562
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.15.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie99ad41a7a161f9046ba894c072eb92150f0e0e2
Gerrit-Change-Number: 17562
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR](branch-1.15.x) [test] make new scenario in security-itest more robust
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has removed a vote on this change.
Change subject: [test] make new scenario in security-itest more robust
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/17562
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.15.x
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: Ie99ad41a7a161f9046ba894c072eb92150f0e0e2
Gerrit-Change-Number: 17562
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR](branch-1.15.x) [test] make new scenario in security-itest more robust
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17562 )
Change subject: [test] make new scenario in security-itest more robust
......................................................................
[test] make new scenario in security-itest more robust
This patch makes the newly introduced test scenario
SecurityITest.TxnSmokeWithDifferentUserTypes more robust and stable.
With awaiting for the first transaction to finalize, now there is no
risk for aborting the second transaction in case of a race.
Before this patch, if it took a long time to finalize aborting the
former transaction, the deadlock prevention logic would automatically
abort the latter one, failing the test scenario.
Before this fix, 1/4 (one if four) of runs failed if running with
--stress_cpu_threads=16. With this fix, I didn't see a failure
in hundreds of runs.
Change-Id: Ie99ad41a7a161f9046ba894c072eb92150f0e0e2
Reviewed-on: http://gerrit.cloudera.org:8080/17559
Tested-by: Kudu Jenkins
Reviewed-by: Andrew Wong <aw...@cloudera.com>
(cherry picked from commit 598304262439fed0819169d6b1a6bc56020a5eea)
Reviewed-on: http://gerrit.cloudera.org:8080/17562
Tested-by: Andrew Wong <aw...@cloudera.com>
Reviewed-by: Bankim Bhavsar <ba...@cloudera.com>
---
M src/kudu/integration-tests/security-itest.cc
1 file changed, 14 insertions(+), 0 deletions(-)
Approvals:
Andrew Wong: Looks good to me, approved; Verified
Bankim Bhavsar: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/17562
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.15.x
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie99ad41a7a161f9046ba894c072eb92150f0e0e2
Gerrit-Change-Number: 17562
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR](branch-1.15.x) [test] make new scenario in security-itest more robust
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17562 )
Change subject: [test] make new scenario in security-itest more robust
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/17562/1//COMMIT_MSG
Commit Message:
PS1:
It's not something necessary to include into 1.15 release, but it might help reduce the test flakiness rate when running 1.15-related pre-commit builds and evaluating an upcoming RC.
--
To view, visit http://gerrit.cloudera.org:8080/17562
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.15.x
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie99ad41a7a161f9046ba894c072eb92150f0e0e2
Gerrit-Change-Number: 17562
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 08 Jun 2021 17:41:44 +0000
Gerrit-HasComments: Yes
[kudu-CR](branch-1.15.x) [test] make new scenario in security-itest more robust
Posted by "Bankim Bhavsar (Code Review)" <ge...@cloudera.org>.
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/17562 )
Change subject: [test] make new scenario in security-itest more robust
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/17562
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.15.x
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie99ad41a7a161f9046ba894c072eb92150f0e0e2
Gerrit-Change-Number: 17562
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 09 Jun 2021 00:05:58 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.15.x) [test] make new scenario in security-itest more robust
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17562 )
Change subject: [test] make new scenario in security-itest more robust
......................................................................
Patch Set 1: Verified+1 Code-Review+2
LGTM but will defer to Bankim.
--
To view, visit http://gerrit.cloudera.org:8080/17562
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.15.x
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie99ad41a7a161f9046ba894c072eb92150f0e0e2
Gerrit-Change-Number: 17562
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 08 Jun 2021 21:14:11 +0000
Gerrit-HasComments: No