You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2021/07/19 05:53:44 UTC
[GitHub] [hive] maheshk114 opened a new pull request #2489: HIVE-25342 : Optimize set_aggr_stats_for for mergeColStats path.
maheshk114 opened a new pull request #2489:
URL: https://github.com/apache/hive/pull/2489
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://cwiki.apache.org/confluence/display/Hive/HowToContribute
2. Ensure that you have created an issue on the Hive project JIRA: https://issues.apache.org/jira/projects/HIVE/summary
3. Ensure you have added or run the appropriate tests for your PR:
4. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP]HIVE-XXXXX: Your PR title ...'.
5. Be sure to keep the PR description updated to reflect all changes.
6. Please write your PR title to summarize what this PR proposes.
7. If possible, provide a concise example to reproduce the issue for a faster review.
-->
### What changes were proposed in this pull request?
For the path where stats merge is done, optimisation using direct sql was missing. Now if the direct sql mode is enabled, the stats are collected in a map and updated in a batch.
### Why are the changes needed?
perf improvement.
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
Ptest.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] maheshk114 merged pull request #2489: HIVE-25342 : Optimize set_aggr_stats_for for mergeColStats path.
Posted by GitBox <gi...@apache.org>.
maheshk114 merged pull request #2489:
URL: https://github.com/apache/hive/pull/2489
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] rbalamohan commented on a change in pull request #2489: HIVE-25342 : Optimize set_aggr_stats_for for mergeColStats path.
Posted by GitBox <gi...@apache.org>.
rbalamohan commented on a change in pull request #2489:
URL: https://github.com/apache/hive/pull/2489#discussion_r676262038
##########
File path: standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HMSHandler.java
##########
@@ -8976,8 +8981,12 @@ private boolean updatePartColumnStatsWithMerge(String catName, String dbName, St
if (!csNew.getStatsObj().isEmpty()) {
// We don't short-circuit on errors here anymore. That can leave acid stats invalid.
- result = updatePartitonColStatsInternal(t, csNew,
- request.getValidWriteIdList(), request.getWriteId()) && result;
+ if (MetastoreConf.getBoolVar(getConf(), ConfVars.TRY_DIRECT_SQL)) {
Review comment:
move this getConf computation out of the loop.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org