[jira] Assigned: (HARMONY-708) [classlib][nio] Remove an unnecessary FIXME in org.apache.harmony.nio.internal.MappedByteBufferFactory

["George Harley (JIRA)" <ji...@apache.org>]

     [ http://issues.apache.org/jira/browse/HARMONY-708?page=all ]

George Harley reassigned HARMONY-708:
-------------------------------------

    Assign To: George Harley

> [classlib][nio] Remove an unnecessary FIXME in org.apache.harmony.nio.internal.MappedByteBufferFactory
> ------------------------------------------------------------------------------------------------------
>
>          Key: HARMONY-708
>          URL: http://issues.apache.org/jira/browse/HARMONY-708
>      Project: Harmony
>         Type: Improvement

>   Components: Classlib
>     Reporter: Andrew Zhang
>     Assignee: George Harley
>     Priority: Minor
>  Attachments: nio.diff
>
> The FIXME in org.apache.harmony.nio.internal.MappedByteBufferFactory is unnecessary. 
> // FIXME: the long->int cast of size may be dangerous, but JavaSpec
> // specifies that the mmap size cannot be larger than
> // Integer.MAX_VALUE, may since the direct buffer only supports size of
> // 32 bits. Maybe int the later version(i.e. 64 bit platform)
> // this issue can be handled more elegantly
> The FIXME explains clearly why the method takes long->int cast. But it's not dangerous because spec says:
> "long size - The size of the region to be mapped; must be non-negative and no greater than Integer.MAX_VALUE".
> I'll upload a patch soon. 
> Thanks!
> Best regards,
> Andrew

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira