[jira] [Commented] (ARROW-5777) [C++] BasicDecimal128 is a small object it doesn't always make sense to pass by const ref

["Micah Kornfield (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ARROW-5777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16876964#comment-16876964 ] 

Micah Kornfield commented on ARROW-5777:
----------------------------------------

currently benchmarking shows now appreciable difference to slight performance loss for making this change.  According the literature it should improve things but we don't observe it so we will  just check in the benchmarks for now and this can be revisited later.

> [C++] BasicDecimal128 is a small object it doesn't always make sense to pass by const ref
> -----------------------------------------------------------------------------------------
>
>                 Key: ARROW-5777
>                 URL: https://issues.apache.org/jira/browse/ARROW-5777
>             Project: Apache Arrow
>          Issue Type: Improvement
>            Reporter: Micah Kornfield
>            Assignee: Micah Kornfield
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 12h 10m
>  Remaining Estimate: 0h
>
> For the builder use case we saw 10% improvement in performance by not using const ref.  
> Add benchmarks and look at where it makes sense to avoid passing by ref.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)