[GitHub] [airflow] uranusjr commented on a diff in pull request #32177: Refactor Sqlalchemy queries to 2.0 style (Part 3)

["uranusjr (via GitHub)" <gi...@apache.org>]

uranusjr commented on code in PR #32177:
URL: https://github.com/apache/airflow/pull/32177#discussion_r1250457728


##########
airflow/utils/db.py:
##########
@@ -1101,7 +1102,7 @@ def check_conn_type_null(session: Session) -> Iterable[str]:
 
     n_nulls = []
     try:
-        n_nulls = session.query(Connection.conn_id).filter(Connection.conn_type.is_(None)).all()
+        n_nulls = session.execute(select(Connection.conn_id).filter(Connection.conn_type.is_(None))).all()

Review Comment:
   And should also be rewritten to not actually select the values in the refacotring PR anyway



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org