You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by GitBox <gi...@apache.org> on 2021/01/06 16:52:25 UTC
[GitHub] [sling-org-apache-sling-models-impl] kwin commented on a change in pull request #23: Sling 10037 jdk11 build issues
kwin commented on a change in pull request #23:
URL: https://github.com/apache/sling-org-apache-sling-models-impl/pull/23#discussion_r552802100
##########
File path: pom.xml
##########
@@ -103,6 +104,22 @@
<attach>false</attach>
</configuration>
</plugin>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-compiler-plugin</artifactId>
+ <configuration>
+ <release>11</release>
Review comment:
Also "release" is only available since JDK9 and we must make sure that compilation still works with JDK8.
##########
File path: pom.xml
##########
@@ -103,6 +104,22 @@
<attach>false</attach>
</configuration>
</plugin>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-compiler-plugin</artifactId>
+ <configuration>
+ <release>11</release>
Review comment:
we must compile for Java 8 still (which is not a problem for JDK11, though)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org