You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by er...@apache.org on 2016/08/30 00:31:38 UTC
[1/2] commons-rng git commit: Minor change.
Repository: commons-rng
Updated Branches:
refs/heads/master a41fa0c5e -> dd0a4e5a5
Minor change.
Make unit test slightly clearer.
Project: http://git-wip-us.apache.org/repos/asf/commons-rng/repo
Commit: http://git-wip-us.apache.org/repos/asf/commons-rng/commit/efb4cc0c
Tree: http://git-wip-us.apache.org/repos/asf/commons-rng/tree/efb4cc0c
Diff: http://git-wip-us.apache.org/repos/asf/commons-rng/diff/efb4cc0c
Branch: refs/heads/master
Commit: efb4cc0c5763722c4635de4088875544ea4dd9ee
Parents: a41fa0c
Author: Gilles <er...@apache.org>
Authored: Tue Aug 30 04:12:07 2016 +0200
Committer: Gilles <er...@apache.org>
Committed: Tue Aug 30 04:12:07 2016 +0200
----------------------------------------------------------------------
.../org/apache/commons/rng/ProvidersCommonParametricTest.java | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/commons-rng/blob/efb4cc0c/src/test/java/org/apache/commons/rng/ProvidersCommonParametricTest.java
----------------------------------------------------------------------
diff --git a/src/test/java/org/apache/commons/rng/ProvidersCommonParametricTest.java b/src/test/java/org/apache/commons/rng/ProvidersCommonParametricTest.java
index 40c3077..ec0c14b 100644
--- a/src/test/java/org/apache/commons/rng/ProvidersCommonParametricTest.java
+++ b/src/test/java/org/apache/commons/rng/ProvidersCommonParametricTest.java
@@ -705,9 +705,6 @@ public class ProvidersCommonParametricTest {
* Dummy class for checking that restoring fails when an invalid state is used.
*/
class DummyGenerator extends org.apache.commons.rng.internal.source32.IntProvider {
- /** State. */
- private int state;
-
/** {@inheritDoc} */
@Override
public int next() {
@@ -717,12 +714,12 @@ class DummyGenerator extends org.apache.commons.rng.internal.source32.IntProvide
/** {@inheritDoc} */
@Override
protected byte[] getStateInternal() {
- return NumberFactory.makeByteArray(state);
+ return new byte[0];
}
/** {@inheritDoc} */
@Override
protected void setStateInternal(byte[] s) {
- state = NumberFactory.makeInt(s);
+ // No state.
}
}
[2/2] commons-rng git commit: Unit tests.
Posted by er...@apache.org.
Unit tests.
Project: http://git-wip-us.apache.org/repos/asf/commons-rng/repo
Commit: http://git-wip-us.apache.org/repos/asf/commons-rng/commit/dd0a4e5a
Tree: http://git-wip-us.apache.org/repos/asf/commons-rng/tree/dd0a4e5a
Diff: http://git-wip-us.apache.org/repos/asf/commons-rng/diff/dd0a4e5a
Branch: refs/heads/master
Commit: dd0a4e5a5205fbb39ed55851e0745f5fd698850b
Parents: efb4cc0
Author: Gilles <er...@apache.org>
Authored: Tue Aug 30 04:29:43 2016 +0200
Committer: Gilles <er...@apache.org>
Committed: Tue Aug 30 04:29:43 2016 +0200
----------------------------------------------------------------------
.../rng/ProvidersCommonParametricTest.java | 65 ++++++++++++++++++++
1 file changed, 65 insertions(+)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/commons-rng/blob/dd0a4e5a/src/test/java/org/apache/commons/rng/ProvidersCommonParametricTest.java
----------------------------------------------------------------------
diff --git a/src/test/java/org/apache/commons/rng/ProvidersCommonParametricTest.java b/src/test/java/org/apache/commons/rng/ProvidersCommonParametricTest.java
index ec0c14b..62cac35 100644
--- a/src/test/java/org/apache/commons/rng/ProvidersCommonParametricTest.java
+++ b/src/test/java/org/apache/commons/rng/ProvidersCommonParametricTest.java
@@ -377,6 +377,17 @@ public class ProvidersCommonParametricTest {
RandomSource.restoreState(generator, state);
}
+ @Test(expected=UnsupportedOperationException.class)
+ public void testSaveStateWrongClass() {
+ RandomSource.saveState(new ForeignDummyGenerator());
+ }
+
+ @Test(expected=UnsupportedOperationException.class)
+ public void testRestoreStateWrongClass() {
+ RandomSource.restoreState(new ForeignDummyGenerator(),
+ new RandomSource.State(new byte[0]));
+ }
+
///// Support methods below.
/**
@@ -723,3 +734,57 @@ class DummyGenerator extends org.apache.commons.rng.internal.source32.IntProvide
// No state.
}
}
+
+/**
+ * Dummy class for checking that "save" and "restore" fail when a
+ * class is passed that is not providing the necessary functionality
+ * (i.e. a class that is not implemented by this library).
+ */
+class ForeignDummyGenerator implements UniformRandomProvider {
+ @Override
+ public void nextBytes(byte[] bytes) {
+ return;
+ }
+
+ @Override
+ public void nextBytes(byte[] bytes,
+ int start,
+ int len) {
+ return;
+ }
+
+ @Override
+ public int nextInt() {
+ return 0;
+ }
+
+ @Override
+ public int nextInt(int n) {
+ return 0;
+ }
+
+ @Override
+ public long nextLong() {
+ return 0;
+ }
+
+ @Override
+ public long nextLong(long n) {
+ return 0;
+ }
+
+ @Override
+ public boolean nextBoolean() {
+ return false;
+ }
+
+ @Override
+ public float nextFloat() {
+ return 0;
+ }
+
+ @Override
+ public double nextDouble() {
+ return 0;
+ }
+}